From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6E54441040 for ; Wed, 21 Jan 2026 13:47:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769003238; cv=none; b=USElNF18GHpacwZIau3/2g7cHOApkE2GdGqMbVBxwmhc1IsLbid4w2FpL85pbS+pr5DONS9qeNQGhPd2xmyPB2eS9lxYsDW6MDV4VwxGj859uKWhyzAqFa3nwEBiTqW4Qtv2V2oIAuTUEBPVeuQi699GeuP5lQOCpM2lA7+pY+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769003238; c=relaxed/simple; bh=fn6QDJCmTOKiiaWIAjab6bH+PZ+yr8u3rj/vi81/cYA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dpV+qW7AyBh/9ZIOXRHbPXFOLg4XIfVKil4DhbWSlMmAglf98++0oPlikEaBFHYufW6HRme7IzL1VJ77RzGrHzjUFhY3Ti7Bd3MzOHe4kkJIVfghjO/TzRgCASWXGgxCy7G3s6sFnZLr1IguYLzN8jYsFYMin9cjT0/GK5dnYTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=f2ykpi5x; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="f2ykpi5x" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-8c5320536bfso700167285a.1 for ; Wed, 21 Jan 2026 05:47:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1769003233; x=1769608033; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yPFd5kAX+x+JPapHwkry8xE9pec/AtWEm0UrVlklyxQ=; b=f2ykpi5xV4AqsGPe+t+9MtvUDmlEc1u0/PQj3lUfq4aU/Hwo77wnVtB1eJvqw+N7FN xzw4bLrstDOy/0REMCSD0ORUqKGqxYQKiKStbNKYxQNp2WZZQkyzz0itbawmRWbgL2H1 skBwVkp2ffpngECJUXLObAycSsyoKYUXeuUlgvqOQ1kg+zZsoWSmce3o9BISVyx04BtZ AgQZ9HkSHxdLKj+2xGZJkeR2PiUR2+ajp8gLKlIvaoCY6LIqMmkKw5ciDOnVgL0oTANR 9ooarnFP/DPmR+r04BE9llj8PqxyLSQ2rKlR55DLPAonR+3okKBsSxwo0aSyKEbn36/H Me+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769003233; x=1769608033; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yPFd5kAX+x+JPapHwkry8xE9pec/AtWEm0UrVlklyxQ=; b=VJGa3vS0OSzK+oAv/XYh3TPJmt8tZJiDSEE8HTADMOrq5UGu6gGqH0DoLKSKyU294E zkcuc5EMUWUQs4I1Jp5bMdR7u3+fw+hSCkb44kNZGI6cJKfZiqnKJYUXaUr4cdOxZUQs zlZVi9HORuRuRQdatpTrl0jM2T99YsDpaYLB5/KcqjhHugvaUS9ICgSsmFuFWBMC5rP7 kZDtYmcOCQQo+B1Yp4VmhVtM2ybzDi+JLcSIP6cgP8ziQ48QT92eLTBvWNSnKoAft/ff JA1HhHHm2+BXiEM7KIduewxTAQwulpFRE2cpm9Y7T9rpm/Ht6LuChnt18AUUFoIAwz/R DILw== X-Forwarded-Encrypted: i=1; AJvYcCU9bHKZJ0c01GPpk8rr5bOWInhSA68cH6UpbWpP9OtNMsP3y/jnDtQ84SuXttowMws1QlF6tAvuCTn739I=@vger.kernel.org X-Gm-Message-State: AOJu0YxBBvUzn25aRIm/j1qcDclnq4oBb3p3y12aJzL3EFdbOT9hIova kbJ1+tnyNAcnhtVaIrQE7CVKQQX/C7qRqaB5V1pqoVWVnCIEsZRtyUWkHkxXiqszt7w= X-Gm-Gg: AZuq6aJQm5OSNMhIqEnpMztbi5WDJuGAZgg5CbbKfoVptHA78l6kQCcoc68uEHb8wh7 D+B/uYtZ0cvSK6OQoCovcNJ609Q1OmdTfryhjEBJlj4U+kFfNSsxz38VPWIBYNMDtUmwOnTKua4 5J0Rdg6OT4ACd3MhiTLg5c98XqSlDFyAzHPKVJp/3mXdQGOcDyqKYV3n3POmDxMmTPw8RJgMXxy Z7F9ZJvhcIpqBN40t6h3cY4QbSBGRDuUHvpJ2swRPkd5ORZfP+0nQfGm4PBc0fxntf7zg0B7Fob 91B8/Efm4IJh6+FSVXlF67eBXQDUl5sXDvEP6mRUCuxe3ZWlOg8nnRkXdkKNrWTpJmXkD515ivh sqpmAmZO8ns76Q19HMZVDgGIfWBWEnFD8Fgl/jddv5mjm9sxczfdiq1sS+0f+NqPcwrJqqXqSPl tL6oXDuMs/DQ9ZuyeEW+Kx+9ZkC4p3Equz1V9QI9da00uwGKgxWWL9ze25xlcy9YuNXevU9xsD4 TjPWA== X-Received: by 2002:a05:620a:4003:b0:8b2:f090:b167 with SMTP id af79cd13be357-8c6ccdbf81fmr639187685a.24.1769003233554; Wed, 21 Jan 2026 05:47:13 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c6a71ab288sm1307247385a.6.2026.01.21.05.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 05:47:12 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1viYYC-00000006Dum-1GTZ; Wed, 21 Jan 2026 09:47:12 -0400 Date: Wed, 21 Jan 2026 09:47:12 -0400 From: Jason Gunthorpe To: Leon Romanovsky Cc: Sumit Semwal , Christian =?utf-8?B?S8O2bmln?= , Alex Deucher , David Airlie , Simona Vetter , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lucas De Marchi , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Rodrigo Vivi , Kevin Tian , Joerg Roedel , Will Deacon , Robin Murphy , Felix Kuehling , Alex Williamson , Ankit Agrawal , Vivek Kasireddy , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org Subject: Re: [PATCH v4 8/8] vfio: Validate dma-buf revocation semantics Message-ID: <20260121134712.GZ961572@ziepe.ca> References: <20260121-dmabuf-revoke-v4-0-d311cbc8633d@nvidia.com> <20260121-dmabuf-revoke-v4-8-d311cbc8633d@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260121-dmabuf-revoke-v4-8-d311cbc8633d@nvidia.com> On Wed, Jan 21, 2026 at 02:59:16PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Use the new dma_buf_attach_revocable() helper to restrict attachments to > importers that support mapping invalidation. > > Signed-off-by: Leon Romanovsky > --- > drivers/vfio/pci/vfio_pci_dmabuf.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/vfio/pci/vfio_pci_dmabuf.c b/drivers/vfio/pci/vfio_pci_dmabuf.c > index 5fceefc40e27..85056a5a3faf 100644 > --- a/drivers/vfio/pci/vfio_pci_dmabuf.c > +++ b/drivers/vfio/pci/vfio_pci_dmabuf.c > @@ -31,6 +31,9 @@ static int vfio_pci_dma_buf_attach(struct dma_buf *dmabuf, > if (priv->revoked) > return -ENODEV; > > + if (!dma_buf_attach_revocable(attachment)) > + return -EOPNOTSUPP; > + > return 0; > } We need to push an urgent -rc fix to implement a pin function here that always fails. That was missed and it means things like rdma can import vfio when the intention was to block that. It would be bad for that uAPI mistake to reach a released kernel. It's tricky that NULL pin ops means "I support pin" :| Jason