From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2703428460 for ; Wed, 21 Jan 2026 15:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769008528; cv=none; b=UsFK8eIMtgJIm2gd7q1X2etU8r/sDYNpH8KF4dUMs6vjFKS+V+q8W7g6L5tTlYoU7bnGOuMbkNr7mGox9zp5fgjb7yyBjoFv1KRn3RNmN+lNrbb0akLMjnVpO7+pjVV7T7uHTw+FMWInW5s8CnD+MmuhFncciA2+8INbbEUTjto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769008528; c=relaxed/simple; bh=GTDYEFiega8YxWihJVfzhrRVHZNr2+ykLR1wXxa9TVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A5fNbLRVHjB9zIE1kdtwCwkv0y9gcjcpEd2QrEq0VE4B1s7/284/Y1WtvZxarUhI5hqqqbSILHngtr0hN2T3p+QzBF44cxpQ7buH1Xv1l9FIfp6ax2c5VnhPjUeV2nUm3F90BmLsmiDjYMMcQh4CB1prP3w6HPsqNVIMGVgJW98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iIVrbQlJ; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iIVrbQlJ" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4801bc32725so34634455e9.0 for ; Wed, 21 Jan 2026 07:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769008525; x=1769613325; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W91/nThu/hrkiQ9f4tK/HK4NnadCCD9MyZ0A6Cw7s6o=; b=iIVrbQlJ8IRL4p92YCZExrCKxYZhahtuE+EvuDoA81fggK3To6zpphtJRvyOsdfm8t +TJQ5X42sYmiIuElcuyubG+NBL4TqrkEmOnqQeAOh5PEOCGau3XoDks55zFquBG8fDlv h+9xsofcdtb3Jk107JovolPGJnEgElNZjuCbnes0auBToB6vONv5c6o+RXOnqYY4w+PD +DqH0n3lBp4NkSbOJbed/VX3m0Aw230HkyvHvNUOPNNqsXpVtMI8xNUGvKCEfY9Rx0fD 0DAreSwEDO+utU8hX93t/9PUBCGdkg3MmrgZIeqXjZIMGJVxyqFDRhqZa0pWURF1ScsO nzkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769008525; x=1769613325; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=W91/nThu/hrkiQ9f4tK/HK4NnadCCD9MyZ0A6Cw7s6o=; b=KyWXTiVYUA81G20lflpMA+Pt4bWJSqFTjv64nvtxIIKoNuTrxIolam7/ZoaVsKiGON tlV39HNVXc65i0tCRr2nFg4Dnk+1JnM3QPxVqdev5V0+jrVHu9/AxWw4qiqTlbZ++7YE 3uJ/0lMPJMhpG/MMYMDPlA4WJK1U6qfoPfNBfNGWui6Fwii3axLOI8p6qcNyZbXxg9MX nO3YBeC871Tp+ieP5JgTzqLCZwYXFposYfxqJUfDUGOk2PWrNym9V2mzW8mfYptyzlOH zu3BKR913JjIYQSR0FVvTrjINa5fwy8FycBA+pSoGfW2O1Myu8HVZEA7n0rmgh/lIZL+ hyag== X-Forwarded-Encrypted: i=1; AJvYcCXf277a5SVYl8BaMFUUIZQ55pp7G2iqOaVskjbfB1btVdD05jTRH57kMtBO75Jvt2pv4ZOohr4oiI0g3Qk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx26ZER2NhHQq02pJj/EEiOErqzO/0zzRBZOo31ukfDqEAcgOfZ tTFdzCmGKCcCPfYGgcoqe0f2GA0v+KWlzxb7xAisWErJYxtw4EB1GR2B X-Gm-Gg: AZuq6aJAGypBIR+AcrihDS2x6SkoZzkKAPeVXxwU0xJLmcHK4GZ7UwCAOyn7u+q3O3A pZGUAck51oNKoVpWFbUbA0K7JGGnp/pNH26EI6Bsy2IySUKvvOPDz2LJU1EA2rEjCFX10i6mutw Kk75g0Ioynhz6bLjU6jC24UzGvwiFAGUc05rQuUPNWEK1eucvFai74dwO5dj8UkCuXakejRGihp smUyrUMf6TmiG2RIgLFsfN7+P/51xH3dYWFMNqKXjVDDkZ3v2pAxlgzzk4kh6dzAJlhEBnrgNfj MW//0FwqwZXz7FdYyjsHddTV2EzCb0h/c2520BGQcj+4Dv952nA/CYCV01UTLeP/9PhKzLazdEm e/dTN8CHEGWRPKH+Pe8zmFVlXqypU3ljGq6WPf3FOfiBO1QEHYK9ds+bYKvUJsutQLQdjHCNi7r OcfUQcs2G0J4s= X-Received: by 2002:a05:600c:608a:b0:477:2f7c:314f with SMTP id 5b1f17b1804b1-48025ccb812mr216647125e9.10.1769008524782; Wed, 21 Jan 2026 07:15:24 -0800 (PST) Received: from nas.local ([2001:912:1ac0:1e00:c662:37ff:fe09:93df]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435924ae6f1sm10534349f8f.33.2026.01.21.07.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 07:15:24 -0800 (PST) From: Damien Dejean To: andrew@lunn.ch, krzk+dt@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, hkallweit1@gmail.com, Damien Dejean Subject: [PATCH v2 4/4] net: phy: realtek: add RTL8224 polarity support Date: Wed, 21 Jan 2026 16:15:06 +0100 Message-ID: <20260121151506.813783-4-dam.dejean@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260121151506.813783-1-dam.dejean@gmail.com> References: <20260121151506.813783-1-dam.dejean@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The RTL8224 has a register to configure the polarity of every pair of each port. It provides device designers more flexbility when wiring the chip. Unfortunately, the register is left in an unknown state after a reset. Thus on devices where the bootloader don't initialize it, the driver has to do it to detect and use a link. The MDI polarity swap can be set in the device tree using the property realtek,mdi-cfg-polarity. The u32 value is a bitfield where bit[0..3] control the polarity of pairs A..D. Signed-off-by: Damien Dejean --- drivers/net/phy/realtek/realtek_main.c | 39 +++++++++++++++++++++++++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realtek/realtek_main.c index 85b0eea936e4..d2dc4f7a1971 100644 --- a/drivers/net/phy/realtek/realtek_main.c +++ b/drivers/net/phy/realtek/realtek_main.c @@ -164,6 +164,7 @@ #define RTL8224_SRAM_RTCT_LEN(pair) (0x8028 + (pair) * 4) #define RTL8224_VND1_MDI_PAIR_SWAP 0xa90 +#define RTL8224_VND1_MDI_POLARITY_SWAP 0xa94 #define RTL8366RB_POWER_SAVE 0x15 #define RTL8366RB_POWER_SAVE_ON BIT(12) @@ -1719,9 +1720,45 @@ static int rtl8224_mdi_config_order(struct phy_device *phydev) RTL8224_VND1_MDI_PAIR_SWAP, val); } +static int rtl8224_mdi_config_polarity(struct phy_device *phydev) +{ + struct device_node *np = phydev->mdio.dev.of_node; + u8 port_offset = phydev->mdio.addr & 3; + u32 polarity, val; + int ret; + + ret = of_property_read_u32(np, "realtek,mdi-cfg-polarity", &polarity); + + /* Do nothing if the property is not present */ + if (ret == -EINVAL) + return 0; + + if (!ret) + return ret; + + if (polarity & ~0xf) + return -EINVAL; + + val = __phy_package_read_mmd(phydev, 0, MDIO_MMD_VEND1, + RTL8224_VND1_MDI_POLARITY_SWAP); + if (val < 0) + return val; + + val &= ~(0xf << port_offset); + val |= polarity << port_offset; + return __phy_package_write_mmd(phydev, 0, MDIO_MMD_VEND1, + RTL8224_VND1_MDI_POLARITY_SWAP, val); +} + static int rtl8224_config_init(struct phy_device *phydev) { - return rtl8224_mdi_config_order(phydev); + int ret; + + ret = rtl8224_mdi_config_order(phydev); + if (!ret) + return ret; + + return rtl8224_mdi_config_polarity(phydev); } static int rtl8224_probe(struct phy_device *phydev) -- 2.47.3