From: Peter Zijlstra <peterz@infradead.org>
To: Andrea Righi <arighi@nvidia.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Joel Fernandes <joelagnelf@nvidia.com>, Tejun Heo <tj@kernel.org>,
David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>, Shuah Khan <shuah@kernel.org>,
sched-ext@lists.linux.dev, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org,
Christian Loehle <christian.loehle@arm.com>
Subject: Re: [PATCH 4/7] sched_ext: Add a DL server for sched_ext tasks
Date: Wed, 21 Jan 2026 16:52:45 +0100 [thread overview]
Message-ID: <20260121155245.GG166857@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <aXDLYj0_VnbVZkJE@gpd4>
On Wed, Jan 21, 2026 at 01:49:38PM +0100, Andrea Righi wrote:
> On Wed, Jan 21, 2026 at 01:29:01PM +0100, Peter Zijlstra wrote:
> > On Tue, Jan 20, 2026 at 10:50:35PM +0100, Andrea Righi wrote:
> >
> > > @@ -1813,6 +1813,7 @@ void dl_server_stop(struct sched_dl_entity *dl_se)
> > > hrtimer_try_to_cancel(&dl_se->dl_timer);
> > > dl_se->dl_defer_armed = 0;
> > > dl_se->dl_throttled = 0;
> > > + dl_se->dl_defer_running = 0;
> > > dl_se->dl_defer_idle = 0;
> > > dl_se->dl_server_active = 0;
> > > }
> >
> > This should definitely not be in this patch. Why was this added? Were
> > you trying to do the same as:
> >
> > ca1e8eede4fc ("sched/deadline: Fix server stopping with runnable tasks")
> >
>
> The problem is that if remove this, RT can completely stall EXT tasks, also
> with ca1e8eede4fc applied.
But that's not something ext specific, right? Can you pull this change
out and write a sane Changelog for it, describing the problem and so?
next prev parent reply other threads:[~2026-01-21 15:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 21:50 [PATCHSET RESEND v11 sched_ext/for-6.20] Add a deadline " Andrea Righi
2026-01-20 21:50 ` [PATCH 1/7] sched/deadline: Clear the defer params Andrea Righi
2026-01-20 21:50 ` [PATCH 2/7] sched/debug: Fix updating of ppos on server write ops Andrea Righi
2026-01-20 21:50 ` [PATCH 3/7] sched/debug: Stop and start server based on if it was active Andrea Righi
2026-01-20 21:50 ` [PATCH 4/7] sched_ext: Add a DL server for sched_ext tasks Andrea Righi
2026-01-21 12:29 ` Peter Zijlstra
2026-01-21 12:49 ` Andrea Righi
2026-01-21 15:52 ` Peter Zijlstra [this message]
2026-01-21 17:27 ` Andrea Righi
2026-01-21 12:31 ` Peter Zijlstra
2026-01-21 12:51 ` Andrea Righi
2026-01-20 22:05 ` [PATCH 5/7] sched/debug: Add support to change sched_ext server params Andrea Righi
2026-01-20 22:05 ` [PATCH 6/7] selftests/sched_ext: Add test for sched_ext dl_server Andrea Righi
2026-01-20 22:05 ` [PATCH 7/7] selftests/sched_ext: Add test for DL server total_bw consistency Andrea Righi
2026-01-20 23:10 ` [PATCHSET RESEND v11 sched_ext/for-6.20] Add a deadline server for sched_ext tasks Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2026-01-26 9:58 [PATCHSET v12 " Andrea Righi
2026-01-26 9:59 ` [PATCH 4/7] sched_ext: Add a DL " Andrea Righi
2026-02-02 19:50 ` Peter Zijlstra
2026-02-02 20:32 ` Andrea Righi
2026-02-02 21:10 ` Peter Zijlstra
2026-02-02 22:18 ` Andrea Righi
2025-12-17 9:35 [PATCHSET v11 sched_ext/for-6.20] Add a deadline " Andrea Righi
2025-12-17 9:35 ` [PATCH 4/7] sched_ext: Add a DL " Andrea Righi
2025-12-17 15:49 ` Juri Lelli
2025-12-17 20:35 ` Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260121155245.GG166857@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arighi@nvidia.com \
--cc=bpf@vger.kernel.org \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=christian.loehle@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=joelagnelf@nvidia.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sched-ext@lists.linux.dev \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome