From: Peter Zijlstra <peterz@infradead.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Sasha Levin <sashal@kernel.org>,
acme@kernel.org, irogers@google.com, jpoimboe@kernel.org,
linux-kernel@vger.kernel.org, regressions@lists.linux.dev,
torvalds@linux-foundation.org, x86@kernel.org
Subject: Re: [PATCH] objtool: fix libopcodes linking with static libraries
Date: Wed, 21 Jan 2026 20:25:31 +0100 [thread overview]
Message-ID: <20260121192531.GN166857@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJZ5v0jRxwuVgody9TbUqhyj6Ajr+NjchUSo2m6Uzs3PrNoJHw@mail.gmail.com>
On Wed, Jan 21, 2026 at 08:08:51PM +0100, Rafael J. Wysocki wrote:
> On Wed, Jan 21, 2026 at 5:25 PM Sasha Levin <sashal@kernel.org> wrote:
> >
> > Commit 436326bc525d ("objtool: fix build failure due to missing libopcodes
> > check") tests for libopcodes using an empty main(), which passes even when
> > static libraries lack their dependencies. This causes undefined reference
> > errors (xmalloc, bfd_get_bits, etc.) when linking against static libopcodes
> > without its required libbfd and libiberty.
> >
> > Fix by testing with an actual libopcodes symbol and trying increasingly
> > complete library combinations until one succeeds.
> >
> > Fixes: 436326bc525d ("objtool: fix build failure due to missing libopcodes check")
> > Reported-by: Rafael J. Wysocki <rafael@kernel.org>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > ---
> >
> > Rafael, I'd appreciate if you could test this patch without the .so symlink
> > workaround. Thanks :)
>
> Works here, so
>
> Tested-by: Rafael J. Wysocki (Intel) <rafael@kernel.org>
Excellent, thanks all!
next prev parent reply other threads:[~2026-01-21 19:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 20:19 [Regression in 6.19-rc6] Build breakage after commit 436326bc525d Rafael J. Wysocki
2026-01-20 10:28 ` Peter Zijlstra
2026-01-20 17:40 ` Sasha Levin
2026-01-20 18:29 ` Rafael J. Wysocki
2026-01-20 19:58 ` Sasha Levin
2026-01-20 20:04 ` Rafael J. Wysocki
2026-01-20 20:22 ` Sasha Levin
2026-01-20 21:33 ` Rafael J. Wysocki
2026-01-21 1:18 ` Sasha Levin
2026-01-21 5:29 ` Josh Poimboeuf
2026-01-21 12:06 ` Sasha Levin
2026-01-21 16:25 ` [PATCH] objtool: fix libopcodes linking with static libraries Sasha Levin
2026-01-21 19:08 ` Rafael J. Wysocki
2026-01-21 19:25 ` Peter Zijlstra [this message]
2026-01-21 19:28 ` [tip: objtool/urgent] objtool: Fix " tip-bot2 for Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260121192531.GN166857@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=irogers@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=regressions@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®