From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012064.outbound.protection.outlook.com [52.101.43.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D16AC3A4AB2 for ; Wed, 21 Jan 2026 21:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.64 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769031042; cv=fail; b=b/AW7Acq23CIas1FemcngC/gRKLU3mF4jOAqgVkaTk1f6n4POoUE9BchoOZJgK8imnYhSfpuurlJwPXgPyBX7MEtL1tnKX1yM/UuiaTWBxDgEe4NWyOrxPNTmpdpZapPwVAhvu5dT/ZSdVqCPOnFTb9QIGeK7zH0Mzk6aEbH33U= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769031042; c=relaxed/simple; bh=TdQM0BhjV+sh/sCUEQCLNHVeTOBHiMHd+Jw6ZZP44Vo=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=WyG3QJ844MyaULQanxyoiVIaMBnFByQbrZJRsY4EzM4iMxfB+5O4vZdon9/IACwBhom36MNNySDfAjryqQmNY3X/38lKhtdu2HMqcO3UmGx96wryEnczotz/GOTjmW6xa0HwHIeOGUMrkBSARZN8qrjJyNcRpJXaxOj35ZB/mTU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=eeLjhFNo; arc=fail smtp.client-ip=52.101.43.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="eeLjhFNo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=v7WT9WKckDhiSUiso+NbzMleaQxZeG3YeI7GjAJ1HLtAWAY9f23v1KvdV9FNM9jOwe83LKD59EJRypKedWrqcwzx5XY1oobuglfD0l9PrCllw+SvrLd6zj098+WgOsq56hZmeHYsemRrxDgq23lxFPdH3o7MkdzqtTmBYrEUlKDG0Q6S2c2HgOxqCnDVCLqxOexH5p9TXeerNKPRkH5QRUxm5SvE3y95OrxVMJRQK6q4qCE4q0aZAe2wjZi6QULjcBOO9nq8QDrhrTIeefcrKFmh0SxqjYyFVeY18tOgOWvM8cn1L0aGDJpNGoFs9p4hc1oqbRrdDvnNLIxBlbSBLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nOelIFwX8gpUOXKhm4sA7wA3iBWfRdZOVNmsSVA0U/s=; b=OU6DEyYzE3dcPC147aClb7O5MOvG54lO2G2hbhDCOQbPh18wZcY3vEwhEzc0KtuyKvq/8kDyBxMAXM3SL8czjC9YsK9xLwq5NlzrhEz4eMNNc3qdFUMgnZoJN/wok7h1Tz3S/aBr3t1H354HRDPUZb/uiYO4Yz98RarM0mP57kkvx53hjOGHwlB0dS3qTVSC8bpfI+AkI6/YK/NepGXgL3E9M31tgs8mX6Cd8d9c2zz0vy306BK4YyqYvK/2QPMifJRJOs8So6C+X+dR1eDBRTsZbfxxbtwYNZmWJGOwNkhAqvaLRLojUpLLq1MLSH6zFdU68kVrBTZGtOgaFxLDkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nOelIFwX8gpUOXKhm4sA7wA3iBWfRdZOVNmsSVA0U/s=; b=eeLjhFNoNxR97k0oh2cKOe02n07L6+MGfn4NoltN4goR+p0ESrhrvx4GmDvnGMclY9ouYU7s4aF0snQ7kad4n2q/MYkOf2fnhLoofORsxSyB63cS03YzfdLHVbZbfCeZXLvdNMkRNX9CI2+Ds9rCBIxAhwrVCccyDVJXfP99wwY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB6373.namprd12.prod.outlook.com (2603:10b6:8:a4::7) by LV2PR12MB999096.namprd12.prod.outlook.com (2603:10b6:408:353::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.9; Wed, 21 Jan 2026 21:30:38 +0000 Received: from DM4PR12MB6373.namprd12.prod.outlook.com ([fe80::12f7:eff:380b:589f]) by DM4PR12MB6373.namprd12.prod.outlook.com ([fe80::12f7:eff:380b:589f%6]) with mapi id 15.20.9542.008; Wed, 21 Jan 2026 21:30:38 +0000 Date: Wed, 21 Jan 2026 16:30:30 -0500 From: Yazen Ghannam To: Mario Limonciello Cc: Jean Delvare , linux-kernel@vger.kernel.org, Borislav Petkov Subject: Re: [PATCH v4 6/6] x86/CPU/AMD: Print AGESA string from DMI additional information entry Message-ID: <20260121213030.GA1992440@yaz-khff2.amd.com> References: <20260121060431.432350-1-superm1@kernel.org> <20260121060431.432350-7-superm1@kernel.org> <20260121142654.GA1784626@yaz-khff2.amd.com> <3ec8b151-5f3a-48e4-bcb2-3e8524d85083@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ec8b151-5f3a-48e4-bcb2-3e8524d85083@kernel.org> X-ClientProxiedBy: BN0PR04CA0019.namprd04.prod.outlook.com (2603:10b6:408:ee::24) To DM4PR12MB6373.namprd12.prod.outlook.com (2603:10b6:8:a4::7) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB6373:EE_|LV2PR12MB999096:EE_ X-MS-Office365-Filtering-Correlation-Id: 185415ec-5c34-45d6-08fe-08de59345205 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?8fGzJVBF72WmB42ES8SGUeIrhnLny92GOzGtNIC+fu+umm6Vv/it33PhWhfj?= =?us-ascii?Q?wT2Jt2peUIwmGalOeH+C8p57147t/mTeqXAN7svQU2FXJs6H5yYEXYzlabj/?= =?us-ascii?Q?yJ0yo+sRaYDOzhEK8Hp40l7u5E5ce8aI72x7hVakNUG5l4903fy40p+ksBQS?= =?us-ascii?Q?twHt0X10xs29W5pEJve/8FGcfVjEILb1wqML0GOsAgaOpd0A9O2r0QuDwNbT?= =?us-ascii?Q?Ye7GpX/STIRBnOdFSMw4sbGasMDGDfvzEEJyuGV7gOw0EtyJNEVN6W/f2bQh?= =?us-ascii?Q?D9CL/AAWtmFLjXqFqbfu79zLG/hd+hhcvD5lEoMpN9GWrBsOEhH0ZNoQaTSU?= =?us-ascii?Q?rh4Pvli9EbngU/PM8mP44hy/2b4T1OoXRRtcOeqMxEO6b57gl//S4iOefCwI?= =?us-ascii?Q?MAp8O734ccb6NsAe/DpoxcS2U+2Mo0jHVPBacILJLkil0TlCN7WeGynx94NV?= =?us-ascii?Q?j7cYjR8pbat2bWa9W+Mfx0G9Jm/UquV5RwS98wz9ToX9DdQ52BShfi+WYeNb?= =?us-ascii?Q?rrduomUsyAoBg9SnDnVFAwrCZ1V5GMZskfiYQRY8q6pz1iBQ/lL4XdZ9zJPx?= =?us-ascii?Q?43A2+82JyagH2U3QoP3l96IX+lwJCXr2GdZkGGaK1hAI10sXThvCFj8Kg0Gd?= =?us-ascii?Q?CvkhHfuGMoUaFFX1GimisOKUmBm62iN9DZRtF+316NOQqGxu8TA3foFNJkwI?= =?us-ascii?Q?uSibf7E5oiF5q0XQ3QkLRf1A+bVoeWwyUi4hErbaX7EM2xeJ4zk8mWVWaU7k?= =?us-ascii?Q?mw249wHkyk0dW5vfcZz8eAwFB/cVcSXnwnYlxV0tFcLxAXOVw7hSV2TK46pP?= =?us-ascii?Q?iGjgXQyvnEGEvfEw8AWoFBZ8GtYFTHvhqMVL95WU6qcMUBAcqGOx61RabMwK?= =?us-ascii?Q?IorSI0OVDorGua2Hbx+APi+GDNnsErJ6tZmu3A7YflVNLkgq6AbtT7h1isZi?= =?us-ascii?Q?1tzTkZF1vrtQQ6vNXUTtEyBUzfFFJ1DvXlLIUgSUjL/5g4DJm1cQ4JsRsfGM?= =?us-ascii?Q?8MLzEp4xM1R8RoWBDtUyrHd00jQdloPOnkdr6aSmoUIqI4O5c6dNpvNOi5rf?= =?us-ascii?Q?TgmUZXcN0F5W6CFRpD9bQZAW6VaSGObNb27LejVewG7yJbxbqLD1lytWn3FC?= =?us-ascii?Q?bQQFt9MGV+eiIqWxrVnaoFkOxNRfBUhBYfy3hfaIiD4XAbYiNIh7kii+vpUf?= =?us-ascii?Q?noCHrHrqnTbsZrvki233J8UVYBnsJrhuR6hOXG5P+NrQ5c6jfPjI9YbY65jP?= =?us-ascii?Q?owXnr4sWjBXoGUrk4pjqAw/tkYyluC3xfIWAmuL6l2MtaXWWs8dlP46HdRD8?= =?us-ascii?Q?qqQF2I2Ao/fM1Jn2nw3aXed/Eh8w38oqOexQqyWKRnvCLFmxHan6rLRrgRBA?= =?us-ascii?Q?0cKfPkxduRpogyy7QF/8hX2YSBMdCLyN7k7dfELyCDoMV4HdLkK84NFpPiYM?= =?us-ascii?Q?CYX2sjb7VYfpyX//legHp/56a0Qx0h/MMKRfR4cNYVojUs1PX9e4j01Ic9k0?= =?us-ascii?Q?3CAN0klyQovofKzU1NF1u2UaC+yxsTARz35H0b1W1ZpjvCzMujctpjKMrWD5?= =?us-ascii?Q?eSFf4sYt08NGgyUVK/w=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB6373.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pxT1jr0GKrUNzSk8y1IICFsmIeW4PwC9xrANrrWxVZlwtK4IxPwMVsAFbscL?= =?us-ascii?Q?zftByFxG7MnBWBCuStrq/+9mMpTyZFogxuAYLLGR6BPDjgNkc3SBFKnLS3jT?= =?us-ascii?Q?ebAq9wx0VFtIZyV2s7naMyvSGMpyq1iJZeIIbu4CL0ht8s94e1GGeb3JhLm2?= =?us-ascii?Q?V6G4WN0PAg+ygVka9186wa6tHgXAUtCJjt3IsOMgpIU3aES/pHxIjHFbSvMf?= =?us-ascii?Q?AxDyPMOGXlF6ZLRw4Qk30Odw9cRDbK+IbBqC7pndb41owggLs+87YEkasgF+?= =?us-ascii?Q?+JBdeHVLl+MJJLdBwgfEzC2yVx0b0wVgi/zXtHWn/wNjE9fixj2yLbIYMC3K?= =?us-ascii?Q?CMaMP0I+o2xrYpNE3BItlM1g/ibCyriqCiwydmeZDTDlSlc3ttcNt45oXmHo?= =?us-ascii?Q?UM8lGsluCwopjBCOSeJWm7bZTvRu5RF0uJS4lpXBVSkv28ckMZGExs8pQ82X?= =?us-ascii?Q?HybId+/eWDGsOEtEbogVYwMh/RByHVO6rTJPwXJ0kV2eEG8moyfRG1W2DYya?= =?us-ascii?Q?YugDnfQP0GoWVGfWWX1SKtmOX4DBdwaKaSGcekU7VAZPu08ZPn6Cyy8JihC5?= =?us-ascii?Q?dzQCXtrgLI3PHoqqk1lBJxkb7eDIjBal4Nf/psNl0ZHjWdIdIfoIm4mrwWgS?= =?us-ascii?Q?S5lW2nGFYCuskeR9B0PJR27Hb+IWhU9iK8kxSQXQYT5Gx2rfGRZ+Co6oegUO?= =?us-ascii?Q?GFsSlZvzdOPj6S0UwUCXcxocPNeTRS7+Mc8YcRN6KZVOf2eAVb8zf9C5hgjD?= =?us-ascii?Q?KQalEqQiR7j/miBsrFum2xi8CFzKeDPXCEmCumNjjDHRrTG+eeyqUAI4Ni9P?= =?us-ascii?Q?o1abDr6eV6hcfRJizYGbvFSlJj4iuA/M2MIOXx/jz8X3tpxItb5df7NgH85Z?= =?us-ascii?Q?9Z61ckLOqlj/P4RIkKkoeBEmMXyc+87VOXonaJZSO6yBbMzkdyPAPFKwJhiq?= =?us-ascii?Q?Js727aSGR389wAJOZbYNL5KOLK+XOJe/crQv/W8P6yNMRiHzCVwbdO5EX2tz?= =?us-ascii?Q?EmzV3oAfApjDRTHvIYmdtNMnEjgTNaNy25WfEl3LuoYA3/I0ajahifp+eqBS?= =?us-ascii?Q?41qF/ztfS8sXTgdpk+HNqIZcTGKutFOa7FK34eG5IJ28CILJp1peqknHS5We?= =?us-ascii?Q?17BGjtCVJZVZ++HtZf6ok1bq7E1iV7iJV0Z4ScHHURpLhB6Mu3zeDVTsK5sR?= =?us-ascii?Q?Ljq62ptw0habUhGccCHTLBXsX+4Xsdgl2S3E89Q1epud6aXu8FvC6WDqGfxO?= =?us-ascii?Q?OumWOgJKwKeyc+WOd/xx3tVtazQbAiaiMiDAYPcK0msbKbDSHJ9kt/W9VnPH?= =?us-ascii?Q?bZ8+4V91E0Au5btMG9GRK7d7l1ZRXoZWSKaPPoYIojhI2SK+TjVctZeJn3cO?= =?us-ascii?Q?OH016ckronS8pDo+LXLGxA28FyscAzqX15oQK86deBxgQOt5krr8BOY7K7Pu?= =?us-ascii?Q?rjHSuUv3A5FH5mtbvygR/75U+qQ7jGK6IKcqYwCJhtYU814XBEjnxpm1k4Aj?= =?us-ascii?Q?Di3BhMi7fDIMMFtxso/5Z5NxwAHU9DQdlFXoisyCXMtvnv2N8JKcGmGVIGap?= =?us-ascii?Q?zw6oVGWgafMVkwsIOxF4FvA5XFBHpjNtjkuBUy61dph7PI99yYOttoGoD+HP?= =?us-ascii?Q?objhrQq4uJ/ANfmp0Epaj9wfALSwrMtNRTqBahe75vEqeuQVN4acIEBApTBZ?= =?us-ascii?Q?XuekvPTaheAbAq1kWD0VgA4XuVa/bIrNRMxWJjbW3Jc6qDsHWk1N77nK3tXp?= =?us-ascii?Q?zDexoOaR+Q=3D=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 185415ec-5c34-45d6-08fe-08de59345205 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB6373.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2026 21:30:38.4343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 96kOkH57n+/VcVCbkq54AfPazx9mopWVsB3AcdE5O172+g/fXJcMEA+UAEpZV9G/sJNUCtlQs30cxMh69GZJqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB999096 On Wed, Jan 21, 2026 at 02:50:49PM -0600, Mario Limonciello wrote: > On 1/21/26 8:26 AM, Yazen Ghannam wrote: [...] > > > + do { > > > + struct dmi_a_info_entry *entry; > > > + const char *string_ptr; > > > + > > > + entry = (struct dmi_a_info_entry *)next; > > > + > > > + /* > > > + * Not much can be done to validate data. At least the entry > > > + * length shouldn't be 0. > > > + */ > > > + if (!entry->length) > > > + return; > > > + > > > + string_ptr = dmi_string_nosave(&info->header, entry->str_num); > > > + > > > + /* Only one AGESA string is expected. */ > > > + if (!strncmp(string_ptr, "AGESA", 5)) { > > > + pr_info("%s\n", string_ptr); > > > + break; > > > + } > > > + [...] > > > +static inline const char * > > > + dmi_string_nosave(const struct dmi_header *dm, u8 s) { return dmi_empty_string; } > > > > The dmi_empty_string needs to be moved to this header file from > > dmi_scan.c. > > > > Otherwise, there's a build issue as the test bot reported. > > > > Thanks, > > Yazen > > I don't think it's actually appropriate to move dmi_empty_string in this > case. It's a static variable, shouldn't really be in a header. > > I would think it's better to just return NULL. dmi_string_nosave() should always return a string. The callers expect it. That's why we don't need a NULL pointer check above. +static inline const char * + dmi_string_nosave(const struct dmi_header *dm, u8 s) { return ""; } Rather than move the variable, just return the empty string directly. Thanks, Yazen