From: Felix Gu <ustc.gu@gmail.com>
To: Liviu Dudau <liviu.dudau@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Rob Herring <robh@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Felix Gu <ustc.gu@gmail.com>
Subject: [PATCH] bus: vexpress-config: Fix device node reference leak in probe
Date: Thu, 22 Jan 2026 20:33:04 +0800 [thread overview]
Message-ID: <20260122-b4-vexpress-config-v1-1-3f0c85bc4730@gmail.com> (raw)
In vexpress_syscfg_probe(), of_parse_phandle() is called inside a loop
but the returned device_node reference is never released.
Fix this by using the __free(device_node) cleanup handler to automatically
release the reference when the variable goes out of scope.
Fixes: a5a38765ac79b ("bus: vexpress-config: simplify config bus probing")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
drivers/bus/vexpress-config.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
index 64ee920721ee..a1fa583e9f5d 100644
--- a/drivers/bus/vexpress-config.c
+++ b/drivers/bus/vexpress-config.c
@@ -4,6 +4,7 @@
* Copyright (C) 2014 ARM Limited
*/
+#include <linux/cleanup.h>
#include <linux/err.h>
#include <linux/init.h>
#include <linux/io.h>
@@ -390,9 +391,8 @@ static int vexpress_syscfg_probe(struct platform_device *pdev)
}
for_each_compatible_node(node, NULL, "arm,vexpress,config-bus") {
- struct device_node *bridge_np;
-
- bridge_np = of_parse_phandle(node, "arm,vexpress,config-bridge", 0);
+ struct device_node *bridge_np __free(device_node) =
+ of_parse_phandle(node, "arm,vexpress,config-bridge", 0);
if (bridge_np != pdev->dev.parent->of_node)
continue;
---
base-commit: 053966c344dbd346e71305f530e91ea77916189f
change-id: 20260122-b4-vexpress-config-1d2051861d93
Best regards,
--
Felix Gu <ustc.gu@gmail.com>
next reply other threads:[~2026-01-22 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 12:33 Felix Gu [this message]
2026-01-22 13:30 ` Liviu Dudau
2026-01-22 15:54 ` Felix Gu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122-b4-vexpress-config-v1-1-3f0c85bc4730@gmail.com \
--to=ustc.gu@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®