mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>,
	 Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
	 Somnath Kotur <somnath.kotur@broadcom.com>,
	 Andrew Lunn <andrew+netdev@lunn.ch>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	 Igor Russkikh <irusskikh@marvell.com>,
	Simon Horman <horms@kernel.org>,
	 "K. Y. Srinivasan" <kys@microsoft.com>,
	 Haiyang Zhang <haiyangz@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>,  Dexuan Cui <decui@microsoft.com>,
	Long Li <longli@microsoft.com>,
	 Alexander Duyck <alexanderduyck@fb.com>,
	kernel-team@meta.com,  Edward Cree <ecree.xilinx@gmail.com>,
	Brett Creeley <brett.creeley@amd.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	 oss-drivers@corigine.com, linux-hyperv@vger.kernel.org,
	 linux-net-drivers@amd.com, Breno Leitao <leitao@debian.org>,
	 Subbaraya Sundeep <sbhatta@marvell.com>
Subject: [PATCH net-next v2 4/9] net: mana: convert to use .get_rx_ring_count
Date: Thu, 22 Jan 2026 10:40:16 -0800	[thread overview]
Message-ID: <20260122-grxring_big_v4-v2-4-94dbe4dcaa10@debian.org> (raw)
In-Reply-To: <20260122-grxring_big_v4-v2-0-94dbe4dcaa10@debian.org>

Use the newly introduced .get_rx_ring_count ethtool ops callback instead
of handling ETHTOOL_GRXRINGS directly in .get_rxnfc().

Since ETHTOOL_GRXRINGS was the only command handled by mana_get_rxnfc(),
remove the function entirely.

Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com>
Signed-off-by: Breno Leitao <leitao@debian.org>
---
 drivers/net/ethernet/microsoft/mana/mana_ethtool.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ethernet/microsoft/mana/mana_ethtool.c b/drivers/net/ethernet/microsoft/mana/mana_ethtool.c
index 0e2f4343ac67f..f2d220b371b5d 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_ethtool.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_ethtool.c
@@ -282,18 +282,11 @@ static void mana_get_ethtool_stats(struct net_device *ndev,
 	}
 }
 
-static int mana_get_rxnfc(struct net_device *ndev, struct ethtool_rxnfc *cmd,
-			  u32 *rules)
+static u32 mana_get_rx_ring_count(struct net_device *ndev)
 {
 	struct mana_port_context *apc = netdev_priv(ndev);
 
-	switch (cmd->cmd) {
-	case ETHTOOL_GRXRINGS:
-		cmd->data = apc->num_queues;
-		return 0;
-	}
-
-	return -EOPNOTSUPP;
+	return apc->num_queues;
 }
 
 static u32 mana_get_rxfh_key_size(struct net_device *ndev)
@@ -520,7 +513,7 @@ const struct ethtool_ops mana_ethtool_ops = {
 	.get_ethtool_stats	= mana_get_ethtool_stats,
 	.get_sset_count		= mana_get_sset_count,
 	.get_strings		= mana_get_strings,
-	.get_rxnfc		= mana_get_rxnfc,
+	.get_rx_ring_count	= mana_get_rx_ring_count,
 	.get_rxfh_key_size	= mana_get_rxfh_key_size,
 	.get_rxfh_indir_size	= mana_rss_indir_size,
 	.get_rxfh		= mana_get_rxfh,

-- 
2.47.3


  parent reply	other threads:[~2026-01-22 18:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22 18:40 [PATCH net-next v2 0/9] net: convert drivers to .get_rx_ring_count (last part) Breno Leitao
2026-01-22 18:40 ` [PATCH net-next v2 1/9] net: benet: convert to use .get_rx_ring_count Breno Leitao
2026-01-22 18:40 ` [PATCH net-next v2 2/9] net: atlantic: " Breno Leitao
2026-01-22 18:40 ` [PATCH net-next v2 3/9] net: nfp: " Breno Leitao
2026-01-22 18:40 ` Breno Leitao [this message]
2026-01-22 18:40 ` [PATCH net-next v2 5/9] net: fbnic: " Breno Leitao
2026-01-22 18:40 ` [PATCH net-next v2 6/9] net: ionic: " Breno Leitao
2026-01-22 18:40 ` [PATCH net-next v2 7/9] net: sfc: efx: " Breno Leitao
2026-01-22 18:40 ` [PATCH net-next v2 8/9] net: sfc: siena: " Breno Leitao
2026-01-22 18:40 ` [PATCH net-next v2 9/9] net: sfc: falcon: " Breno Leitao
2026-01-22 18:50 ` [PATCH net-next v2 0/9] net: convert drivers to .get_rx_ring_count (last part) Creeley, Brett
2026-01-23 19:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260122-grxring_big_v4-v2-4-94dbe4dcaa10@debian.org \
    --to=leitao@debian.org \
    --cc=ajit.khaparde@broadcom.com \
    --cc=alexanderduyck@fb.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=brett.creeley@amd.com \
    --cc=davem@davemloft.net \
    --cc=decui@microsoft.com \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=haiyangz@microsoft.com \
    --cc=horms@kernel.org \
    --cc=irusskikh@marvell.com \
    --cc=kernel-team@meta.com \
    --cc=kuba@kernel.org \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net-drivers@amd.com \
    --cc=longli@microsoft.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@corigine.com \
    --cc=pabeni@redhat.com \
    --cc=sbhatta@marvell.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=sriharsha.basavapatna@broadcom.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®