From: Eliot Courtney <ecourtney@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Alice Ryhl <aliceryhl@google.com>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Alistair Popple <apopple@nvidia.com>
Cc: nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Eliot Courtney <ecourtney@nvidia.com>
Subject: [PATCH 0/4] gpu: nova-core: gsp: fix command queue ring buffer bugs
Date: Thu, 22 Jan 2026 11:59:03 +0900 [thread overview]
Message-ID: <20260122-nova-core-cmdq1-v1-0-7f8fe4683f11@nvidia.com> (raw)
This series fixes a few bugs in the GSP command queue ring buffer
implementation in nova-core and also clarifies some of the comments.
The ring buffer uses read and write pointers (rx/tx) to track which areas
are available for the CPU vs the GSP to read/write into.
In the ring buffers there were some indexing issues which could end up
causing panics, so I fixed those and added more rigorous proofs of
correctness in the panic comments.
Signed-off-by: Eliot Courtney <ecourtney@nvidia.com>
---
Eliot Courtney (4):
gpu: nova-core: gsp: fix incorrect advancing of write pointer
gpu: nova-core: gsp: clarify comments about invariants and pointer roles
gpu: nova-core: gsp: fix improper handling of empty slot in cmdq
gpu: nova-core: gsp: fix improper indexing in driver_read_area
drivers/gpu/nova-core/gsp/cmdq.rs | 68 +++++++++++++++++++++++----------------
1 file changed, 40 insertions(+), 28 deletions(-)
---
base-commit: 6ea52b6d8f33ae627f4dcf43b12b6e713a8b9331
change-id: 20260121-nova-core-cmdq1-6aaa369824c4
Best regards,
--
Eliot Courtney <ecourtney@nvidia.com>
next reply other threads:[~2026-01-22 3:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 2:59 Eliot Courtney [this message]
2026-01-22 2:59 ` [PATCH 1/4] gpu: nova-core: gsp: fix incorrect advancing of write pointer Eliot Courtney
2026-01-23 18:28 ` Gary Guo
2026-01-26 4:02 ` Eliot Courtney
2026-01-22 2:59 ` [PATCH 2/4] gpu: nova-core: gsp: clarify comments about invariants and pointer roles Eliot Courtney
2026-01-22 2:59 ` [PATCH 3/4] gpu: nova-core: gsp: fix improper handling of empty slot in cmdq Eliot Courtney
2026-01-22 3:26 ` John Hubbard
2026-01-22 5:07 ` Eliot Courtney
2026-01-22 9:27 ` Alexandre Courbot
2026-01-23 14:19 ` Miguel Ojeda
2026-01-23 18:31 ` Gary Guo
2026-01-26 4:17 ` Eliot Courtney
2026-01-22 2:59 ` [PATCH 4/4] gpu: nova-core: gsp: fix improper indexing in driver_read_area Eliot Courtney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122-nova-core-cmdq1-v1-0-7f8fe4683f11@nvidia.com \
--to=ecourtney@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®