From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DFE43D331C for ; Thu, 22 Jan 2026 06:07:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769062076; cv=none; b=OTdy9dffqOe99wJ/djQyICh5v3vFrXmP4i2XXOjigT5OrCo4hcn+fZ1DqdGBGMoMbGVz5U1rH89bG9YAoVn/LHP33pBm7GnERtaMWx7p0pnvN3SGmvL0Op1GnRRiE6zl3ojBiLqYSjeVwXDTdXVlA/xpuYIN6xqVgHJvHhM8oXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769062076; c=relaxed/simple; bh=1o5NqahfDQ5VNbcqleS+o4wBaycfjfXYCwkC1X8D/Yw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=s1XsBpPhJ66x9L2xQU+NjUNSlsg6qTisZ88yj9Q3tZQiahLausy3eCiW7anfdqqJpOCnYLLmgscZFAd5jl30ZiiygXCyeXtCGIiZkMqMhJ050gGiJlG4EMfKjI5vaDmNpUHlWURC5pxeiqdMOlM/4pOgbO6cfmTySznor5Xmgwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=E6fE8EfQ; arc=none smtp.client-ip=209.85.221.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E6fE8EfQ" Received: by mail-wr1-f65.google.com with SMTP id ffacd0b85a97d-43246af170aso368541f8f.0 for ; Wed, 21 Jan 2026 22:07:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769062073; x=1769666873; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WNY/LXM5CUd8SovQrwoI4Q/jBB7ob8o4qFKazdU5gjs=; b=E6fE8EfQoT2TU/D2TUhyuS5CAPitE+TKJqi4jwHmSl/LvU9N8XetZudDtGmwde2Nhw AZpB+OxRvgBa0yXrekcEojBQ2znWGaYLCuxd2sIeADdmGN3Jp8tJZXcTSlYdxqcGzZms ykMBErdUJJnOPhp9lZWpcDz3+FE6awirjAtnliNRfTKk69jp7nv88mzy9Dwkp/3x/FEC Fkkyxw3nzICqD+RTC9NrtaIwt7/f1MATXCM1RCAfSVBS1A7CkYaKW5B499q4zX6qosld Pu2U+IeoiKWjkdzzSkLrfuigWf1qsd3FTICaO6kqLwjXAxGff7CPbwtUk/E+mTpi5nAn P0nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769062073; x=1769666873; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WNY/LXM5CUd8SovQrwoI4Q/jBB7ob8o4qFKazdU5gjs=; b=IsnY6hCowr4XXmB7nntRbKeVlRAvgRlnQ6CHvga4l/6e3nktcDyEBE7Vl12PcM/ylK 9LZmeQFcdyAigmh9Y6i+fCDaFQ1zr2mAgBOzlMezLQDohpr/mJ73be9vmW3FnsJXXkMa XAHNklc9nPsAiCCOVoanKT+msQD4mgWCc5Iia34xuOgwUsKqSLSosgx3drD8XwTLf3dM nu7zcnGNspNS9Tw21MTf8E850HqPtjC78Caiu7ZGV9LSww4GzIK/dpgwwSahMfmVH80s ySYu7ZAeTA1zjtsQ7kbVhzLPzCX3DQBqXZskyrXTfu+BM4NLnmbep7Yj2Zl5CeZ6a0xk Afjg== X-Forwarded-Encrypted: i=1; AJvYcCVru0tmE49P1oZWawRDSVWjajNJj0c7RpPwA+mp5rnVH5FMU+dRiPHggKuGbKDw+Vc6C2E4s97VFaiDfAg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4VvPupTrijnVIXtedonge6gsQIez8bDNRkA2iacnlPj/j0SXf XpXf3lcMWGNT8Xh2Ao4hdfC//z0cx4ZATwlHtng5hcudLlMjtA5H5zWLQHQ2w8V0Y24= X-Gm-Gg: AZuq6aKA5ryUkNONuxeFBrhqB/tTqvKEw1DMv0fUMHs6dqvbOFrpFHzNf4cTQjfw4m9 Lz0ADiqYeO2ogTrRohr0TOWt7kP9LZuA0hhAK4KeVLW4wViax16GBcfPEMVkKJK9yBHZphiW1vT QF/Xd3iCep2WavO4sMkoktOXm4IZxAm89IaddLAVOnQFpo48oRQbkVTXuOMlBh777w2FxIaE5xc JVeJjHOH7LrUbym5RqPZf8fb5QUc7CTr1QVfAj+Ndo6pxNcl1u5cErnyqAk0RQKIE1YrIh3/fBM Etv4YtKIt8dJSDZYK4uPm2hjX4x1AP74QWJ5GYBIxfRMiS9caebl5CK3X8ACKFflyMD6fJzcyod B0ZclqKlsQ34qPb+44/RUdW2uGM21ISrUSOnBwneQLsMQc8lkU3RFtGhdpPkaxp0y0WxP9oSTNH MY8oU7fuKsh0Y7uyll X-Received: by 2002:adf:e88b:0:b0:435:9635:2943 with SMTP id ffacd0b85a97d-435a5f757a6mr2857800f8f.17.1769062072600; Wed, 21 Jan 2026 22:07:52 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356992201csm43165202f8f.2.2026.01.21.22.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 22:07:52 -0800 (PST) Date: Thu, 22 Jan 2026 09:07:49 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, "Chia-Lin Kao (AceLan)" , Andreas Noever , Mika Westerberg , Yehezkel Bernat , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev Subject: Re: [PATCH v2] thunderbolt: Fix PCIe device enumeration with delayed rescan Message-ID: <202601220733.dS3GMZRD-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260121060857.237777-1-acelan.kao@canonical.com> Hi Chia-Lin, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Chia-Lin-Kao-AceLan/thunderbolt-Fix-PCIe-device-enumeration-with-delayed-rescan/20260121-141206 base: https://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git next patch link: https://lore.kernel.org/r/20260121060857.237777-1-acelan.kao%40canonical.com patch subject: [PATCH v2] thunderbolt: Fix PCIe device enumeration with delayed rescan config: arm64-randconfig-r073-20260121 (https://download.01.org/0day-ci/archive/20260122/202601220733.dS3GMZRD-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 8.5.0 smatch version: v0.5.0-8985-g2614ff1a If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202601220733.dS3GMZRD-lkp@intel.com/ smatch warnings: drivers/thunderbolt/tb.c:128 tb_pci_rescan_work_fn() error: uninitialized symbol 'dev'. drivers/thunderbolt/tb.c:2392 tb_tunnel_pci() error: uninitialized symbol 'dev'. vim +/dev +128 drivers/thunderbolt/tb.c d6d458d42e1e15 Mika Westerberg 2024-08-20 102 static void tb_queue_dp_bandwidth_request(struct tb *tb, u64 route, u8 port, d6d458d42e1e15 Mika Westerberg 2024-08-20 103 int retry, unsigned long delay); 4f807e47ee9a75 Mika Westerberg 2018-09-17 104 eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 105) static void tb_pci_rescan_work_fn(struct work_struct *work) eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 106) { eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 107) struct tb_pci_rescan_work *rescan_work = eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 108) container_of(work, typeof(*rescan_work), work.work); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 109) struct tb *tb = rescan_work->tb; eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 110) struct pci_bus *bus = rescan_work->bus; eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 111) int devices_after = 0; eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 112) struct pci_dev *dev; eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 113) struct tb_switch *sw; eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 114) struct tb_port *port; eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 115) eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 116) mutex_lock(&tb->lock); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 117) eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 118) sw = tb_switch_find_by_route(tb, rescan_work->route); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 119) if (!sw) { eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 120) tb_dbg(tb, "Switch at route %llx disappeared, skipping rescan\n", eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 121) rescan_work->route); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 122) goto out_unlock; eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 123) } eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 124) eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 125) port = &sw->ports[rescan_work->port]; eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 126) eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 127) pci_lock_rescan_remove(); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 @128) for_each_pci_dev(dev) ^^^ eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 129) devices_after++; eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 130) pci_unlock_rescan_remove(); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 131) eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 132) if (devices_after > rescan_work->devices_before) { eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 133) tb_port_dbg(port, "pciehp enumerated %d new device(s)\n", eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 134) devices_after - rescan_work->devices_before); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 135) } else { eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 136) tb_port_info(port, "pciehp failed to enumerate devices, triggering rescan\n"); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 137) eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 138) pci_lock_rescan_remove(); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 139) pci_rescan_bus(bus); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 140) eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 141) devices_after = 0; eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 142) for_each_pci_dev(dev) eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 143) devices_after++; eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 144) pci_unlock_rescan_remove(); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 145) eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 146) if (devices_after > rescan_work->devices_before) eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 147) tb_port_info(port, "rescan found %d new device(s)\n", eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 148) devices_after - rescan_work->devices_before); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 149) else eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 150) tb_port_warn(port, "no devices found even after rescan\n"); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 151) } eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 152) eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 153) tb_switch_put(sw); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 154) out_unlock: eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 155) mutex_unlock(&tb->lock); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 156) kfree(rescan_work); eb51ddfd22dbc5 Chia-Lin Kao (AceLan 2026-01-21 157) } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki