From: Kory Maincent <kory.maincent@bootlin.com>
To: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
Cc: "Jyri Sarha" <jyri.sarha@iki.fi>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Tony Lindgren" <tony@atomide.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Markus Schneider-Pargmann" <msp@baylibre.com>,
"Bajjuri Praneeth" <praneeth@ti.com>,
"Louis Chauvet" <louis.chauvet@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Miguel Gazquez" <miguel.gazquez@bootlin.com>,
"Herve Codina" <herve.codina@bootlin.com>,
<dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCH v4 18/25] drm/tilcdc: Convert to DRM managed resources
Date: Thu, 22 Jan 2026 15:48:40 +0100 [thread overview]
Message-ID: <20260122154840.5185671a@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <DFSVOBV5UY37.3HTQHOJT3A40N@bootlin.com>
On Mon, 19 Jan 2026 22:19:26 +0100
"Luca Ceresoli" <luca.ceresoli@bootlin.com> wrote:
> On Fri Jan 16, 2026 at 6:02 PM CET, Kory Maincent (TI.com) wrote:
> > Convert the tilcdc driver to use DRM managed resources (drmm_* APIs)
> > to eliminate resource lifetime issues, particularly in probe deferral
> > scenarios.
> >
> > This conversion addresses potential use-after-free bugs by ensuring
> > proper cleanup ordering through the DRM managed resource framework.
> > The changes include:
> > - Replace drm_crtc_init_with_planes() with drmm_crtc_alloc_with_planes()
> > - Replace drm_universal_plane_init() with drmm_universal_plane_alloc()
> > - Replace drm_simple_encoder_init() with drmm_simple_encoder_alloc()
> > - Remove manual cleanup in tilcdc_crtc_destroy() and error paths
> > - Remove drm_encoder_cleanup() from encoder error handling paths
> > - Use drmm_add_action_or_reset() for remaining cleanup operations
> >
> > This approach is recommended by the DRM subsystem for improved resource
> > lifetime management and is particularly important for drivers that may
> > experience probe deferral.
> >
> > Signed-off-by: Kory Maincent (TI.com) <kory.maincent@bootlin.com>
> > ---
> >
> > Change in v4:
> > - Newt patch.
>
> Why? Adding patches along the way does not help getting your series merged
> timely. If there's a good reason for adding a new patch, please mention it
> here.
Thanks for your review.
Sorry for that. The reason is that I faced a null pointer dereference koops if
for example the panel module is not installed. Then the
drm_of_find_panel_or_bridge() function return eprobe defer and something goes
wrong with the DRM resources. Using DRM managed resources solves it.
I will mention it for the v5.
> > + tilcdc_crtc = drmm_crtc_alloc_with_planes(dev, struct tilcdc_crtc,
> > base,
> > + &primary->base,
> > + NULL,
> > + &tilcdc_crtc_funcs,
> > + "tilcdc crtc");
> > + if (IS_ERR(tilcdc_crtc)) {
> > + dev_err(dev->dev, "Failed to init CRTC: %pe\n",
> > tilcdc_crtc);
> > + return PTR_ERR(tilcdc_crtc);
> > + }
> > +
> > + tilcdc_crtc->primary = primary;
>
> (*) see below
>
> >
> > init_completion(&tilcdc_crtc->palette_loaded);
> > tilcdc_crtc->palette_base = dmam_alloc_coherent(dev->dev,
> > @@ -978,10 +992,6 @@ int tilcdc_crtc_create(struct drm_device *dev)
> >
> > crtc = &tilcdc_crtc->base;
> >
> > - ret = tilcdc_plane_init(dev, &tilcdc_crtc->primary);
> > - if (ret < 0)
> > - goto fail;
> > -
> > mutex_init(&tilcdc_crtc->enable_lock);
> >
> > init_waitqueue_head(&tilcdc_crtc->frame_done_wq);
> > @@ -989,20 +999,12 @@ int tilcdc_crtc_create(struct drm_device *dev)
> > spin_lock_init(&tilcdc_crtc->irq_lock);
> > INIT_WORK(&tilcdc_crtc->recover_work, tilcdc_crtc_recover_work);
> >
> > - ret = drm_crtc_init_with_planes(dev, crtc,
> > - &tilcdc_crtc->primary,
> > - NULL,
> > - &tilcdc_crtc_funcs,
> > - "tilcdc crtc");
> > - if (ret < 0)
> > - goto fail;
> > -
> > drm_crtc_helper_add(crtc, &tilcdc_crtc_helper_funcs);
> >
> > + ret = drmm_add_action_or_reset(dev, tilcdc_crtc_destroy, priv);
> > + if (ret)
> > + return ret;
>
> Not related to your patch, but if the dmam_alloc_coherent() (not visible in
> the diff) fails, tilcdc_crtc_destroy() won't be called. Is this intended?
> At first sight this drmm_add_action_or_reset() should be moved at (*), just
> after the allocation.
You are totally right.
> However being not related to your patch I'd leave this for another series
> anyway, to avoid making this series a moving target.
I think it is related to this patch.
Before this patch there was no need for cleanup as the only action before the
dmam_alloc_coherent() was a devm_kzalloc().
Now the plane and the crtc are initialize before the dmam_alloc_coherent() so
the cleanup need to happen if it fails an error.
> I find this patch hard to read and I think because it is converting
> multiple things at once. Splitting it in small steps would have been nice,
> even thought I'm not 100% sure it would have been doable.
Yes, it brought more error when not converting the whole to DRM Managed
resources in one go.
>
> Nevertheless it looks correct, so:
>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Thanks, but I will remove it due to the small change.
Or maybe it is ok for you if I keep it with only the move of
drmm_add_action_or_reset().
Regards.
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-01-22 14:48 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 17:02 [PATCH v4 00/25] Clean and update tilcdc driver to support DRM_BRIDGE_ATTACH_NO_CONNECTOR Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 01/25] dt-bindings: display: tilcdc: Convert to DT schema Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 02/25] dt-bindings: display: tilcdc: Mark panel binding as deprecated Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 03/25] drm/tilcdc: Remove simulate_vesa_sync flag Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 04/25] drm/tilcdc: Add support for DRM bus flags and simplify panel config Kory Maincent (TI.com)
2026-01-19 16:18 ` Luca Ceresoli
2026-01-16 17:02 ` [PATCH v4 05/25] drm/tilcdc: Convert legacy panel binding via DT overlay at boot time Kory Maincent (TI.com)
2026-01-19 16:18 ` Luca Ceresoli
2026-01-21 14:13 ` Herve Codina
2026-01-16 17:02 ` [PATCH v4 06/25] drm/tilcdc: Remove tilcdc panel driver Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 07/25] drm/tilcdc: Remove component framework support Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 08/25] drm/tilcdc: Remove tilcdc_panel_info structure Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 09/25] drm/tilcdc: Remove redundant #endif/#ifdef in debugfs code Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 10/25] drm/tilcdc: Remove unused encoder and connector tracking arrays Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 11/25] drm/tilcdc: Rename external_encoder and external_connector to encoder and connector Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 12/25] drm/tilcdc: Rename tilcdc_external to tilcdc_encoder Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 13/25] drm/tilcdc: Remove the useless module list support Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 14/25] drm/tilcdc: Use drm_module_platform_driver() helper Kory Maincent (TI.com)
2026-01-19 16:18 ` Luca Ceresoli
2026-01-16 17:02 ` [PATCH v4 15/25] drm/tilcdc: Move tilcdc_init/fini closer to probe/remove Kory Maincent (TI.com)
2026-01-19 16:18 ` Luca Ceresoli
2026-01-16 17:02 ` [PATCH v4 16/25] drm/tilcdc: Modernize driver initialization and cleanup paths Kory Maincent (TI.com)
2026-01-19 16:18 ` Luca Ceresoli
2026-01-16 17:02 ` [PATCH v4 17/25] drm/tilcdc: Remove the use of drm_device private_data Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 18/25] drm/tilcdc: Convert to DRM managed resources Kory Maincent (TI.com)
2026-01-19 21:19 ` Luca Ceresoli
2026-01-22 14:48 ` Kory Maincent [this message]
2026-01-23 16:06 ` Luca Ceresoli
2026-01-16 17:02 ` [PATCH v4 19/25] drm/tilcdc: Convert to drm_device-based logging helpers Kory Maincent (TI.com)
2026-01-19 18:00 ` Luca Ceresoli
2026-01-22 14:59 ` Kory Maincent
2026-01-16 17:02 ` [PATCH v4 20/25] drm/tilcdc: Use devm_drm_of_get_bridge() helper Kory Maincent (TI.com)
2026-01-19 21:18 ` Luca Ceresoli
2026-01-22 14:03 ` Maxime Ripard
2026-01-22 15:03 ` Kory Maincent
2026-01-16 17:02 ` [PATCH v4 21/25] drm/bridge: tda998x: Remove component support Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 22/25] drm/bridge: tda998x: Move tda998x_create/destroy into probe and remove Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 23/25] drm/bridge: tda998x: Remove useless tda998x_connector_destroy wrapper Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 24/25] drm/bridge: tda998x: Add support for DRM_BRIDGE_ATTACH_NO_CONNECTOR Kory Maincent (TI.com)
2026-01-16 17:02 ` [PATCH v4 25/25] rm/tilcdc: " Kory Maincent (TI.com)
2026-01-19 17:58 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122154840.5185671a@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=herve.codina@bootlin.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jyri.sarha@iki.fi \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=louis.chauvet@bootlin.com \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=miguel.gazquez@bootlin.com \
--cc=mripard@kernel.org \
--cc=msp@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=praneeth@ti.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tony@atomide.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®