From: Felix Gu <ustc.gu@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Christian Marangi <ansuelsmth@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Felix Gu <ustc.gu@gmail.com>
Subject: [PATCH] thermal/drivers/airoha: Fix a device node reference leak in airoha_thermal_probe()
Date: Fri, 23 Jan 2026 19:55:23 +0800 [thread overview]
Message-ID: <20260123-airoha-v1-1-ab167bb12fb7@gmail.com> (raw)
In airoha_thermal_probe() function, chip-scu node is acquired through
of_parse_phandle(), but it fails to release this reference if
syscon_node_to_regmap() returns an error.
Add the missing of_node_put() call to the error path to ensure the
reference count is properly decremented.
Fixes: 42de37f40e1b ("thermal/drivers: Add support for Airoha EN7581 thermal sensor")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
drivers/thermal/airoha_thermal.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/airoha_thermal.c b/drivers/thermal/airoha_thermal.c
index b9fd6bfc88e5..308ea846ba26 100644
--- a/drivers/thermal/airoha_thermal.c
+++ b/drivers/thermal/airoha_thermal.c
@@ -431,8 +431,10 @@ static int airoha_thermal_probe(struct platform_device *pdev)
return -EINVAL;
priv->chip_scu = syscon_node_to_regmap(chip_scu_np);
- if (IS_ERR(priv->chip_scu))
+ if (IS_ERR(priv->chip_scu)) {
+ of_node_put(chip_scu_np);
return PTR_ERR(priv->chip_scu);
+ }
of_address_to_resource(chip_scu_np, 0, &priv->scu_adc_res);
of_node_put(chip_scu_np);
---
base-commit: a0c666c25aeefd16f4b088c6549a6fb6b65a8a1d
change-id: 20260123-airoha-ccd6a16a6ef6
Best regards,
--
Felix Gu <ustc.gu@gmail.com>
next reply other threads:[~2026-01-23 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 11:55 Felix Gu [this message]
2026-01-28 16:56 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123-airoha-v1-1-ab167bb12fb7@gmail.com \
--to=ustc.gu@gmail.com \
--cc=ansuelsmth@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®