From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF3801BC08F for ; Fri, 23 Jan 2026 15:37:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769182659; cv=none; b=DAgBrzP15iB4s81d96V7SeU9p0LcpaufCGuITt6bkeDDvoleQQHARYdX6uVtELffMwwhr0rB6rWN0z291kZAme1xj+EDo5hyIyj6UcQT0HpOy94jinBC3YesDJsrrjPhiUJgWdHBcTQ99c0LENtZ1xVENjHgCCnFD1npxAkvD8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769182659; c=relaxed/simple; bh=ALA8Iqxg2vHmVol5d2QOlDr2cJHk+iqHw1IwBAKQ4tQ=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=M4NZiIxwBdQ9BZ+zxnwXCOm6Asn7ZMEAKo/3LvzPq+bzrgo643JZsHfx30wNQdB+SRl8DrB4VDmuGW9d+fsb4WJwrkyIgq6aFeIrwVPP5jYnVpkefRoVKrWnVRUHyTMRr+eF8ejHXCXt8aJX/angVHBsyNv1GTxlGdxZso2kHGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=sWBgR98M; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="sWBgR98M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18917C4CEF1; Fri, 23 Jan 2026 15:37:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1769182659; bh=ALA8Iqxg2vHmVol5d2QOlDr2cJHk+iqHw1IwBAKQ4tQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sWBgR98MV3+VI1p/UnbuBRi0vAtcUaWfI0R3eBgDTMwbtxSMTNZeEpnaeC7uMIJjW yhL0ESUS+hPY/SrwFnZ0swoL6+f4elJJtEr4Bipx8QrX4YT4Kd4mYWhjlzBwyp7zuY wd36g3IJOYnKRHY790k+r3SQ/XCYJUTis1vnCw2g= Date: Fri, 23 Jan 2026 07:37:38 -0800 From: Andrew Morton To: "Garg, Shivank" Cc: Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , David Hildenbrand , Ryan Roberts , Barry Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wei Yang , Lorenzo Stoakes Subject: Re: [PATCH V3 2/5] mm/khugepaged: count small VMAs towards scan limit Message-Id: <20260123073738.76b9e59521270e45eae70f88@linux-foundation.org> In-Reply-To: <836669ac-473f-4c30-a368-c05bfa86c306@amd.com> References: <20260118192253.9263-4-shivankg@amd.com> <20260118192253.9263-8-shivankg@amd.com> <829b62c8-e3eb-485f-8d7b-01419c841cc8@arm.com> <7193b89e-ac2d-47c9-8fa5-68e35c57d4b6@amd.com> <836669ac-473f-4c30-a368-c05bfa86c306@amd.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 23 Jan 2026 16:12:07 +0530 "Garg, Shivank" wrote: > >> I was worrying about a case that doesn't actually happen. > >> > > You're right, thp_vma_allowable_order() is taking care of this, making > > hend <= hstart check redundant. > > > > Thank you for catching this. > > > > I'll drop this change and send revision keeping only the unsigned int type > > change for 'progress'. > > > > Hi Andrew, > > Please drop this patch. thud. > As Dev and Lance noted that the hend <= hstart handling check is redundant. > > The 'progress' variable to unsigned int is not critical either. OK. Were you thinking of adopting Dev's suggestion? https://lkml.kernel.org/r/6486c6dd-2702-4a4d-9662-09639532ce6f@arm.com. If so, let's defer until the next cycle, please. Now is the time to be focusing on stabilization, test, finishing up review, etc.