From: Qiliang Yuan <realwujing@gmail.com>
To: viro@zeniv.linux.org.uk
Cc: brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, realwujing@gmail.com,
yuanql9@chinatelecom.cn
Subject: [PATCH v2] fs/file: optimize close_range() complexity from O(N) to O(Sparse)
Date: Fri, 23 Jan 2026 03:12:21 -0500 [thread overview]
Message-ID: <20260123081221.659125-1-realwujing@gmail.com> (raw)
In-Reply-To: <20260122171408.GF3183987@ZenIV>
In close_range(), the kernel traditionally performs a linear scan over the
[fd, max_fd] range, resulting in O(N) complexity where N is the range size.
For processes with sparse FD tables, this is inefficient as it checks many
unallocated slots.
This patch optimizes __range_close() by using find_next_bit() on the
open_fds bitmap to skip holes. This shifts the algorithmic complexity from
O(Range Size) to O(Active FDs), providing a significant performance boost
for large-range close operations on sparse file descriptor tables.
Signed-off-by: Qiliang Yuan <realwujing@gmail.com>
Signed-off-by: Qiliang Yuan <yuanql9@chinatelecom.cn>
---
v2:
- Recalculate fdt after re-acquiring file_lock to avoid UAF if the
table is expanded/reallocated during filp_close() or cond_resched().
v1:
- Initial optimization using find_next_bit() on open_fds bitmap to
skip holes, improving complexity to O(Active FDs).
fs/file.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/fs/file.c b/fs/file.c
index 0a4f3bdb2dec..51ddcff0081a 100644
--- a/fs/file.c
+++ b/fs/file.c
@@ -777,23 +777,29 @@ static inline void __range_close(struct files_struct *files, unsigned int fd,
unsigned int max_fd)
{
struct file *file;
+ struct fdtable *fdt;
unsigned n;
spin_lock(&files->file_lock);
- n = last_fd(files_fdtable(files));
+ fdt = files_fdtable(files);
+ n = last_fd(fdt);
max_fd = min(max_fd, n);
- for (; fd <= max_fd; fd++) {
+ for (fd = find_next_bit(fdt->open_fds, max_fd + 1, fd);
+ fd <= max_fd;
+ fd = find_next_bit(fdt->open_fds, max_fd + 1, fd + 1)) {
file = file_close_fd_locked(files, fd);
if (file) {
spin_unlock(&files->file_lock);
filp_close(file, files);
cond_resched();
spin_lock(&files->file_lock);
+ fdt = files_fdtable(files);
} else if (need_resched()) {
spin_unlock(&files->file_lock);
cond_resched();
spin_lock(&files->file_lock);
+ fdt = files_fdtable(files);
}
}
spin_unlock(&files->file_lock);
--
2.51.0
next prev parent reply other threads:[~2026-01-23 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 16:35 [PATCH] " Qiliang Yuan
2026-01-22 17:14 ` Al Viro
2026-01-23 8:12 ` Qiliang Yuan [this message]
2026-01-23 11:23 ` [PATCH v2] " Jan Kara
2026-01-23 14:38 ` Christian Brauner
2026-01-27 3:03 ` Qiliang Yuan
2026-02-18 1:34 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123081221.659125-1-realwujing@gmail.com \
--to=realwujing@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yuanql9@chinatelecom.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®