From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4123C2D7D2A for ; Fri, 23 Jan 2026 20:08:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769198901; cv=none; b=JLmdeMa3Og8Piw0j8G2wD33ledZRBX0XHf9p0FUBtOAEMJA/+xaBIAhhg91Ks1/SG3lwWVWtDPokuDMhLgH+iRn4Sgr/qLtZva9qvoj2uuH5qexeE5JoE8h3IzY+uZsKGpY4a8HvPZEAYF/NgY73qBfFDNMILb+L66G2pDNd/U8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769198901; c=relaxed/simple; bh=8/ehURtlp0jdPibG93INsZuVJg0EguVNeHLaSyIXcKg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XQZhkTOiVT7BjLA/uB/1g9L7KJd0Vt35ncy9pvAWf+o+S4ePnchV8jdmeuf/zZ42WbqvLt47BdvonX2zkGxED1YUxWvdsz4dNfkOaj5XE4FnvqsgsTavKeBCTzh2ioq+G0o/nsnszew1nry9NKSGYni7I2U5QNYz3xZXNhwP52o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1D80359D54; Fri, 23 Jan 2026 20:08:18 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf10.hostedemail.com (Postfix) with ESMTPA id 21D3544; Fri, 23 Jan 2026 20:08:15 +0000 (UTC) Date: Fri, 23 Jan 2026 15:08:43 -0500 From: Steven Rostedt To: Peter Zijlstra Cc: tglx@linutronix.de, arnd@arndb.de, anna-maria@linutronix.de, frederic@kernel.org, luto@kernel.org, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, oliver.sang@intel.com Subject: Re: [PATCH v2 5/6] entry,hrtimer: Push reprogramming timers into the interrupt return path Message-ID: <20260123150843.3f68d4cc@gandalf.local.home> In-Reply-To: <20260121162508.011240183@infradead.org> References: <20260121162010.647043073@infradead.org> <20260121162508.011240183@infradead.org> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: s6qcprigbq8gxnyfzn93rga9kqxfmp8q X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: 21D3544 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/i3c0E8M0TLN6tCXBuYudZzum8dK2k5jM= X-HE-Tag: 1769198895-764274 X-HE-Meta: U2FsdGVkX1+29So0jYQnHJR6oOADx7cfQ2VVZ1sjP4a40j/0oR51TuO4+65r6HrqPO3tt4MF5yQ81ftVb9D+PBPNPcBg7/ZcDTlyZpINhXuB1j5PQD0wsVY1MSizX5uZ74H7+1mqzIWOwkmbThDsx04InT1cSH46k4JZ4kwlCbxKPYqWzZS6iTmK5bIOxzZn+e4nAXQpLmQybPdVgssx7pgFHWUyhBCzuS3FpmvLV6KR6eeOKGhCO2IFtOsoM1YO8fSHzHovngrStWP4oA1VDnfhFv8PkAtNcplFcGl+3iJEgoCQIGcKC0DK1xu6xmDzLKkZQ/KdKbv82AhWG5FOOPsBS666dLeWNXGaXuIaeAOPw18Tp3/JYTFQ/tBo/xiZ On Wed, 21 Jan 2026 17:20:15 +0100 Peter Zijlstra wrote: > +#ifdef TIF_HRTIMER_REARM > +void _hrtimer_rearm(void) > +{ > + struct hrtimer_cpu_base *cpu_base = this_cpu_ptr(&hrtimer_bases); > + ktime_t now, expires_next; > + > + lockdep_assert_irqs_disabled(); > + > + scoped_guard (raw_spinlock, &cpu_base->lock) { > + now = hrtimer_update_base(cpu_base); > + expires_next = hrtimer_update_next_event(cpu_base); > + __hrtimer_rearm(cpu_base, now, expires_next); > + clear_thread_flag(TIF_HRTIMER_REARM); > + } > +} I'm curious to why you decided to use scoped_guard() here and not just guard() and not add the extra indentation? The function is small enough where everything is expected to be protected by the spinlock. -- Steve