From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9B55149C6F for ; Sat, 24 Jan 2026 00:49:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769215792; cv=none; b=cGINfERAWjZG2U/nrGejSuOdYQtCgT7ma2yiz0CXFEP16Op96mkIC21e+kvjfAy7IX8WN3nCVmHaALhRuX9i2rQ280fGLuqQgWhTXQ+l9iH64adMTCK3oiPwxxRWvlVf0kEaVumOeEHDWH4GJgyFU3VaZRn9BfWgrr+mKlhLRDM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769215792; c=relaxed/simple; bh=RC250Qo91D1SSQtyrBlzyoXzDHdyy/XToYcR08gF8A8=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=edSznMv2fCH96TAd25rtF7BXzvN6/EZwGUb3IN6199pAFf8ExizIgIfIoiCO5R+bWIeuOes235Fmr/VEbZA039UNQRVPqqkDT7sGB5QLBPSguABjWJwSXnsvi/IH4j6dwsAgLL16h+1O1QbjUCtT+ZsH7NbsgXynWyvE5H70ZAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=WUkkYw+z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="WUkkYw+z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30277C4CEF1; Sat, 24 Jan 2026 00:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1769215791; bh=RC250Qo91D1SSQtyrBlzyoXzDHdyy/XToYcR08gF8A8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WUkkYw+zNNeFQCbcNG2+ocoLhT2A2uWpWOZwnMs3Da2ugSchDJWcaw0CzysJglkGh YJ7pLINRdAUeb6yWmgDEdz9HhQ7lwGWOZuhVqD1R4JJjAlv2lVpYm5nVfC+CFW8cvo 3nYV0c1SHOI/O3uFol5AtXaqJJ5WsRRAAg+4dLg0= Date: Fri, 23 Jan 2026 16:49:50 -0800 From: Andrew Morton To: Breno Leitao Cc: Baoquan He , vgoyal@redhat.com, dyoung@redhat.com, xueshuai@linux.alibaba.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, osandov@osandov.com, kernel-team@meta.com Subject: Re: [PATCH v2] vmcoreinfo: make hwerr_data visible for debugging Message-Id: <20260123164950.6988b5fe7e11d5986e399752@linux-foundation.org> In-Reply-To: References: <20260122-fix_vmcoreinfo-v2-1-2d6311f9e36c@debian.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 23 Jan 2026 01:24:17 -0800 Breno Leitao wrote: > Hello Baoquan, > > On Fri, Jan 23, 2026 at 08:19:40AM +0800, Baoquan He wrote: > > On 01/22/26 at 02:39am, Breno Leitao wrote: > > > If the kernel is compiled with LTO, hwerr_data symbol might be lost, and > > > vmcoreinfo doesn't have it dumped. This is currently seen in some > > > production kernels with LTO enabled. > > > > > > Remove the static qualifier from hwerr_data so that the information is > > > still preserved when the kernel is built with LTO. Making hwerr_data > > > a global symbol ensures its debug info survives the LTO link process and > > > appears in kallsyms. Also document it, so, it doesn't get removed in the > > > future as suggested by akpm. > > > > > > Signed-off-by: Breno Leitao > > > --- > > > Changes in v2: > > > - Add a comment to explain why the array is global (akpm) > > > - Link to v1: https://patch.msgid.link/20260121-fix_vmcoreinfo-v1-1-39e96fab670e@debian.org > > > --- > > > kernel/vmcore_info.c | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > LGTM, > > > > Acked-by: Baoquan He > > > > BTW, is it worth a 'Fixes' tag? > > I am not sure, but, if we prefer to, this is the correct tag: > > Fixes: 3fa805c37dd4d ("vmcoreinfo: track and log recoverable hardware errors") 3fa805c37dd4d was added in 6.19-rc1, so this patch is a fixup against this rc series. So yes, it should go into 6.19-rcX also. I hadn't noticed the timing here so thanks both for pointing it out.