From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACAB01C5D57 for ; Sat, 24 Jan 2026 01:21:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769217703; cv=none; b=Vw5I2K5O99rUyQqQrqtJ6YIJ4jv/dYWkQBEP50GEmTvub4MdXB3z6XKTTXSnPF8MrrDTufb3q3uEqB5Jg8x8/qQ8y3QXaxTW4pXXoyE9Thk3FPInLjk1cAnOBPCyJBFkXqNHWiqnuZGSPJ3l3k92Pf2DVkOHU/X0f2tqaD40GFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769217703; c=relaxed/simple; bh=00WbMUzAQnN9I1jPeJC3yMlN67r8CEu8MJSgu37GGo4=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=PdS21qvOZlGH4xJPCXPTSwSbA1p7fCuFX+cdp+I6jQ1lbbksvRcmxcIHZ06hWEUJKp7kIjkuDN9B/mrVol+zKq8umuaMQZQML5XAj+rHdQiQjMWErLVae1wawUm3g9xJZN+qRyXzuNbPkU+ib10goW9S58lOlGywMN+nhQX4MAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=igSrjhCO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="igSrjhCO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7907C4CEF1; Sat, 24 Jan 2026 01:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1769217703; bh=00WbMUzAQnN9I1jPeJC3yMlN67r8CEu8MJSgu37GGo4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=igSrjhCOt1C3ikvNK04MoxSamznh/YF7Ie010d2C03CG6lgk8Q05RVTMEPRA0Oov9 clbV9O2XJiVuyt9Qpe6/2+s2l4ZDh2O8ynNGcdTbtIe1pIC6oFpIye1Nh29O874DGZ 8kW5qmzywKEvjm4Qk2Qp0f3UhmGueNRJ2re/7UEU= Date: Fri, 23 Jan 2026 17:21:42 -0800 From: Andrew Morton To: "Garg, Shivank" Cc: Dev Jain , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wei Yang , Anshuman Khandual Subject: Re: [PATCH V3 5/5] mm/khugepaged: make khugepaged_collapse_control static Message-Id: <20260123172142.4bcdee865bc768d5c70b6a50@linux-foundation.org> In-Reply-To: References: <20260118192253.9263-4-shivankg@amd.com> <20260118192253.9263-14-shivankg@amd.com> <6486c6dd-2702-4a4d-9662-09639532ce6f@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 23 Jan 2026 15:03:58 +0530 "Garg, Shivank" wrote: > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -829,10 +829,6 @@ static void khugepaged_alloc_sleep(void) > remove_wait_queue(&khugepaged_wait, &wait); > } > > -static struct collapse_control khugepaged_collapse_control = { > - .is_khugepaged = true, > -}; > - > static bool hpage_collapse_scan_abort(int nid, struct collapse_control *cc) > { > int i; > @@ -2629,13 +2625,16 @@ static void khugepaged_wait_work(void) > > static int khugepaged(void *none) > { > + struct collapse_control cc = { > + .is_khugepaged = true, > + }; > struct mm_slot *slot; > > set_freezable(); > set_user_nice(current, MAX_NICE); > > while (!kthread_should_stop()) { > - khugepaged_do_scan(&khugepaged_collapse_control); > + khugepaged_do_scan(&cc); > khugepaged_wait_work(); > } > lol, OK, I droppped $Subject and did this: From: "Garg, Shivank" Subject: mm/khugepaged: make khugepaged_collapse_control a local Date: Fri, 23 Jan 2026 15:03:58 +0530 Make this collapse_control instance local to the only function which uses it. Link: https://lkml.kernel.org/r/ba4502f7-0c35-460e-a42c-d32dea9ab9eb@amd.com Signed-off-by: Shivank Garg Cc: Anshuman Khandual Cc: Baolin Wang Cc: Barry Song Cc: David Hildenbrand (Red Hat) Cc: Dev Jain Cc: Lance Yang Cc: Liam R. Howlett Cc: Lorenzo Stoakes Cc: Nico Pache Cc: Ryan Roberts Cc: Wei Yang Cc: Zi Yan Signed-off-by: Andrew Morton --- mm/khugepaged.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) --- a/mm/khugepaged.c~mm-khugepaged-make-khugepaged_collapse_control-a-local +++ a/mm/khugepaged.c @@ -827,10 +827,6 @@ static void khugepaged_alloc_sleep(void) remove_wait_queue(&khugepaged_wait, &wait); } -struct collapse_control khugepaged_collapse_control = { - .is_khugepaged = true, -}; - static bool hpage_collapse_scan_abort(int nid, struct collapse_control *cc) { int i; @@ -2618,13 +2614,16 @@ static void khugepaged_wait_work(void) static int khugepaged(void *none) { + struct collapse_control cc = { + .is_khugepaged = true, + }; struct mm_slot *slot; set_freezable(); set_user_nice(current, MAX_NICE); while (!kthread_should_stop()) { - khugepaged_do_scan(&khugepaged_collapse_control); + khugepaged_do_scan(&cc); khugepaged_wait_work(); } _