From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ED9C2367DF for ; Sat, 24 Jan 2026 03:02:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769223734; cv=none; b=rwdfQ/a2L9ayqaZo6PjzX6o21NHSak1Ejpr2uqTcji5O9osDAf2JyVtcmshkmITHPYrnx+G0vtAW/LtfnZKtD/tyosCKzgpcy0wQsiVfQKTUdZWN2kBEn0a+5UvzMww+jcMPto0pc0GVlNevWgDDdeeq9ez0M1U7AxGZH7lID2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769223734; c=relaxed/simple; bh=ECIz6G7sqHtGF3FvPa2g4fUPkCAoXuc7uzfPsdhRNgY=; h=Date:From:To:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=XRQ8cg+BH9jCxIosYzHtd42R24jQubhdML0ZegOflptKUrulsSv1C9jdLYledCx3YR9IXzfg8+G8qO9x46JjO0Bol2jIcpIyZngCUUD2hECmHeKM769Z4Wdy4z8xJ4J0Af4ia9HpvVlru2zopHcU+umhqIXz32yaieeutp2gEEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=gYwABHSr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="gYwABHSr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3930C4CEF1; Sat, 24 Jan 2026 03:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1769223734; bh=ECIz6G7sqHtGF3FvPa2g4fUPkCAoXuc7uzfPsdhRNgY=; h=Date:From:To:Subject:In-Reply-To:References:From; b=gYwABHSr92F0aEqCkIsLGo/vshlKkGtNkCA+nhVyuHMcBHaHcjryZZaWuajd3gqlT 9OQvv94COUuv1NtiX+xU1Oz6baBy4OD0VFR0/bOx2QRvB/70FQTHZ9Ymgj7+/7dbRG RED6sBmsmrdNK+NCt+hMNCfVIQXQohq9TciHaNmo= Date: Fri, 23 Jan 2026 19:02:13 -0800 From: Andrew Morton To: "Garg, Shivank" , Dev Jain , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Wei Yang , Anshuman Khandual Subject: Re: [PATCH V3 5/5] mm/khugepaged: make khugepaged_collapse_control static Message-Id: <20260123190213.7f90fcbc6706d9ad57d2c974@linux-foundation.org> In-Reply-To: <20260123172142.4bcdee865bc768d5c70b6a50@linux-foundation.org> References: <20260118192253.9263-4-shivankg@amd.com> <20260118192253.9263-14-shivankg@amd.com> <6486c6dd-2702-4a4d-9662-09639532ce6f@arm.com> <20260123172142.4bcdee865bc768d5c70b6a50@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 23 Jan 2026 17:21:42 -0800 Andrew Morton wrote: > > lol, OK, I droppped $Subject and did this: > > --- a/mm/khugepaged.c~mm-khugepaged-make-khugepaged_collapse_control-a-local > +++ a/mm/khugepaged.c > @@ -827,10 +827,6 @@ static void khugepaged_alloc_sleep(void) > remove_wait_queue(&khugepaged_wait, &wait); > } > > -struct collapse_control khugepaged_collapse_control = { > - .is_khugepaged = true, > -}; > - > static bool hpage_collapse_scan_abort(int nid, struct collapse_control *cc) > { > int i; > @@ -2618,13 +2614,16 @@ static void khugepaged_wait_work(void) > > static int khugepaged(void *none) > { > + struct collapse_control cc = { > + .is_khugepaged = true, > + }; nope, that thing's really big! mm/khugepaged.c: In function 'khugepaged': mm/khugepaged.c:2637:1: error: the frame size of 4696 bytes is larger than 2048 We could kzalloc() it but I think I'll just restore the make-it-static patch. Someone please add to the todo list?