From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C288D13B5AE for ; Sat, 24 Jan 2026 08:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769243828; cv=none; b=DpX0IDuS6dubO2La/vgqlt5y1PXdgp8OPvkm4hDSYabi20FHXLmEfFjEI4PZaoVXGEseO0WNIXGU8lTBl1G35sK1AHqLQgSKJAS/MEkm2l6EFkXJG7Hk2wvam+5mm7k5tLsEBpU1tmqb59xm5pORkDlcrRZofgkSix0i+LW+CxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769243828; c=relaxed/simple; bh=yBi19T5gG8BLiVfxxhJjA+yHmC4/2vPx96tRERd+cBU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mDsdoNB5Ezdv6hg02kksMle4eb+yrJBAvRnEUYCxxNvRewwrlx7T0flyDyQ0qGxgtTzJeOnxfty+BILbpHkq5p45xtHhz0SqfO5XyzeLIq+BjSxJFItsqF2ERapl/qcN82uMVoXEa6u7UfjbUJSDYVWeGTyHnE0XvX5jQiaQn+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kgUUY7jX; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kgUUY7jX" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-432dee2b55fso344331f8f.1 for ; Sat, 24 Jan 2026 00:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769243825; x=1769848625; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=t3Uf+uON7+JhKvsd7FkUSsmqwCPr9nA+llFpVr7IvEo=; b=kgUUY7jXdiuC1m/u7p04YJGSgYH/qz8D67gWCi5QJGq7/r7tPq/LKT9Qlrs3yH+8kS SjBOGwh/1b98BmMVvIryrikXXLpiSFzWP7v9uqslzsnU6T4MzetkarctrbCg1QL/osOX UoW0wVpbro8qey97NdKYTy9eBB7cKaooIGTMSarvUH4Pwi41B0ND2cIW/JIkV6atEU8k 0NCQGtTNhJWmQGIA2GflSFB/BLJ8liO/2J9uYqOfqZxZidHSddndQU3JyzMlkLXR6PfS k290SKIHcWJSM8++OTcobYivdXp3yuq7gFXeS+sG9L4VR0NdXESun+tP6iQCkGtU3MPH no1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769243825; x=1769848625; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t3Uf+uON7+JhKvsd7FkUSsmqwCPr9nA+llFpVr7IvEo=; b=EK9jEQPAPdtS3QYJnOq480uqjruaROGmihvV5zsCLhH3m50tmc0N/7x45NrYzMnlyf HAPH/B2VnXqOfTaQ+A4jV+7SWWYL3blqTrFbTxEocY1Mh2y2O9dgDvPJwbrIUOjw25jK kdL6Z9UinSw3q4eQ+WWSE25N8jvk2ts0H7/pbXvFWEzpFIbT2iruHPF9RIrT8ofWHlbQ 7tFvJ/SjHC2/WenQiCGXuykTnXTG7wC3n/A+/VOyyqP+979aqT3SjSKb7Cll6zFuTBQq knaeUhh5hyVMjSgBf6dHLcBNh8QIlw9JVQNAob/SYJ9OK20VJsh5jXrihEZfZpky6Kxs hP5g== X-Forwarded-Encrypted: i=1; AJvYcCXU0KxfG+EqsQAcQQ/dmxLtgGPDFWu29VpJ8649O2fItEDcucCl+nIrT15awvwvdXkDO5JOpSIvGQuGX+4=@vger.kernel.org X-Gm-Message-State: AOJu0YycqRCj9CT1LufiJhVAxFaZtQ1AuQEKs7Z+UYB9+CCk49ICNgUI ickcakLDF79GU25i4MUTQ5PxX0INcTjqISvKcbVJzu3WWMktVy8+NQj4 X-Gm-Gg: AZuq6aL+DqaH3zGR7rX/BNUMAPGQrUz2zptpo52Agl6afJZsxsAx3jDoyuTcuJ+EVgP bPzoq+LjkIbTsECPiFvtJuVuqUwNhvXk8lVEMPPy7iD8AXUEop4QaxbqmDwRa0hFfARthgIyLv+ /v26QfK/ownvEscv8FoIMLrwd/pZYMzJNjl89U49hYuimN/mBTcO06lKL99K48w54pg8g5+HN7H Sd4rp4ntDqnAsXX9G4ZC0FduJTOrnPdO8AghqiWKcQ87OpwAhZPdhXhDusNYBORH1zJC8ZBoTHk iVjOkYGe+XYu/yETLA2QujuqxEuH89pmc8yg/UfWtqcOVPJFUpzhId8tfXFwJHaMmzApr6rNTxa LW4g2KLfMyKKH0F0QOHUJeqOBhSN3qeZATsMTi1FrUQYLmdWACIdAfQYiQC1jPIH7dEtrVyCZjc WI8w== X-Received: by 2002:a05:600c:3f0b:b0:477:9a4d:b92d with SMTP id 5b1f17b1804b1-480541df18cmr18937555e9.5.1769243824865; Sat, 24 Jan 2026 00:37:04 -0800 (PST) Received: from skbuf ([2a02:2f04:d501:d900:1430:8b48:2d45:6c1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4804d84ef51sm101897005e9.5.2026.01.24.00.37.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jan 2026 00:37:04 -0800 (PST) Date: Sat, 24 Jan 2026 10:37:01 +0200 From: Vladimir Oltean To: Yangfl Cc: Oleksij Rempel , netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Russell King , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 2/2] net: dsa: yt921x: Add DCB/priority support Message-ID: <20260124083701.ihffncswmoe6fw5k@skbuf> References: <20260122194233.2777550-1-mmyangfl@gmail.com> <20260122194233.2777550-3-mmyangfl@gmail.com> <20260123234759.bj2gik3oobluyjs4@skbuf> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Jan 24, 2026 at 10:05:58AM +0800, Yangfl wrote: > On Sat, Jan 24, 2026 at 7:48 AM Vladimir Oltean wrote: > > > > Are you sure the "port" selector represents the Ethernet port default > > priority? It seems odd for it to have any other trust order in hardware > > than last. What would be the use case for that? Sure it's not an L4 port, > > which could be mapped over IEEE_8021QAZ_APP_SEL_ANY? > > > > No (with the "port" selector) but I'm wondering, do we have > corresponding port prio methods > port_add_stream_prio()/port_add_dgram_prio() or something like? No, but it doesn't mean dsa_user_dcbnl_ieee_setapp() can't be extended with the IEEE_8021QAZ_APP_SEL_ANY selector if necessary. I wouldn't bother to do that just for testing, though, just hack something up to determine what it's about.