From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 200D12222C0 for ; Sat, 24 Jan 2026 23:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769296963; cv=none; b=QbDrpZA8FYrvAxalhs33xM6o5/ZUw9GM4GR0ywWZk4JZEkmZxIWxujxe0jwdltaUHNSFlkhXgcIlGBqmL9epd7GpMB+IA8RO5RCeJ3QnlcmJvIGFGxD356CUkIoF4bGw7B73RtSJUH3kPBCZavH8gvZvzvmc6VDlvEGsB6aM+ZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769296963; c=relaxed/simple; bh=E+qta5MzZKOrVv7h+RGiMPJteij1PKPCstlitf9VJMU=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=cxis2/2uel1O+n9I1oIq//Wy02y0eqqesMXCuDVAMcx/G3ZMfJddzrrMIowWVqpTwiRZXTnn6qHlbPk6IBWBH27XRHUJfzKLc/6N1NVjUkk+Qib5wbMzsPwITDEiw0o13Mq4cGAFnL8jXh9R9eHnMj+yjuM5eYiM4J10vZGV4JE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=uVSmrjwo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="uVSmrjwo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FC42C116D0; Sat, 24 Jan 2026 23:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1769296962; bh=E+qta5MzZKOrVv7h+RGiMPJteij1PKPCstlitf9VJMU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uVSmrjwo34hh6Cp2RmvC1RqY9QlHv2S4pQy+uADQuG3ewRnvLup3M1JGwOj2gVbRf J7Ogmrsq6yys/CMz2EjuRLL4kicfqIYsyJEteo87vsWWVw7IqJ6nQp5MRfKYw1QfTY JH0kfjVp6rZdnyzEDz/eOy12wScG5c2k2qJJeJKs= Date: Sat, 24 Jan 2026 15:22:41 -0800 From: Andrew Morton To: Sebastian Andrzej Siewior Cc: Marco Crivellari , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Michal Hocko Subject: Re: [PATCH v2 3/3] mm: add WQ_PERCPU to alloc_workqueue users Message-Id: <20260124152241.d97b8b525c1d67ad2b0423f7@linux-foundation.org> In-Reply-To: <20260124222135.XyGv6OqY@linutronix.de> References: <20260113114630.152942-1-marco.crivellari@suse.com> <20260113114630.152942-4-marco.crivellari@suse.com> <20260124222135.XyGv6OqY@linutronix.de> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 24 Jan 2026 23:21:35 +0100 Sebastian Andrzej Siewior wrote: > On 2026-01-13 12:46:30 [+0100], Marco Crivellari wrote: > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -8542,7 +8542,9 @@ void __init kmem_cache_init(void) > > > > void __init kmem_cache_init_late(void) > > { > > - flushwq = alloc_workqueue("slub_flushwq", WQ_MEM_RECLAIM, 0); > > +#ifndef CONFIG_SLUB_TINY > > This ifndef does not belong here. > > > + flushwq = alloc_workqueue("slub_flushwq", WQ_MEM_RECLAIM | WQ_PERCPU, > > + 0); > > WARN_ON(!flushwq); > > } Yup, thanks, mm.git is carrying a -fix patch, which is actually wrong. From: Andrew Morton Subject: mm-add-wq_percpu-to-alloc_workqueue-users-fix Date: Tue Jan 13 05:59:13 PM PST 2026 fix mm/slub.c Cc: Marco Crivellari Signed-off-by: Andrew Morton --- mm/slub.c | 1 + 1 file changed, 1 insertion(+) --- a/mm/slub.c~mm-add-wq_percpu-to-alloc_workqueue-users-fix +++ a/mm/slub.c @@ -8546,6 +8546,7 @@ void __init kmem_cache_init_late(void) flushwq = alloc_workqueue("slub_flushwq", WQ_MEM_RECLAIM | WQ_PERCPU, 0); WARN_ON(!flushwq); +#endif } struct kmem_cache * I'll add this: --- a/mm/slub.c~mm-add-wq_percpu-to-alloc_workqueue-users-fix-fix +++ a/mm/slub.c @@ -8542,11 +8542,9 @@ void __init kmem_cache_init(void) void __init kmem_cache_init_late(void) { -#ifndef CONFIG_SLUB_TINY flushwq = alloc_workqueue("slub_flushwq", WQ_MEM_RECLAIM | WQ_PERCPU, 0); WARN_ON(!flushwq); -#endif } struct kmem_cache * _