From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34C0718A6A7 for ; Sat, 24 Jan 2026 23:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769296571; cv=none; b=rZbJpVkt3fImqiztDaDoZG5fnWkq8gRMnf3pKTadqfJF2JxuNjZOJNz1nJ3tWnn2Ct5F3IRK+N/m9asWdTlw8F8+IAHE3BpQDXy3Lm8DzDYbRVWoWUd5wW1Kh5W98lMIzo4E9ZxI6/07yiiOs1cVyb7z1tutBO0f6nvABBGTjG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769296571; c=relaxed/simple; bh=VUMzjVSS8dP0GK855gmrvyI0Pgm0KUYLoP7vkV0GZ8U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rtNbNWsMxXgDFUN5aLujYVX9LMuYlwXYn6S66FRRIt9saxTNtXDylQUuJAO5i0Bum8S3ovZW7i1tQ5UEDx5FtzCjtp30jqPeTOxjvIQcf7ajviFjB6c6QpOak/nYHjAlu53xZkrLw6TWCg0gkF2I4F+nRGlnWZ4/IKFgkDD8cqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z7kzAVvo; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z7kzAVvo" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2a79ded11a2so20437085ad.3 for ; Sat, 24 Jan 2026 15:16:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769296569; x=1769901369; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FqRHnF/Kmqh8JjtTS/h08Xf4/E1jwltyp2WHm6FwYbA=; b=Z7kzAVvo7SE5gejf0yuEhk1rlBNGNFSRVbw6LEOHTYVyqC0UneQH/EEQ4Um0jASojt RuVDHxU/G8f6C/Y4jIVLwk+XHyaJpAmMB3Zpt0PII0pXNMDKU/e71HxF+WrjeLivNzq9 Tzg+zYBLBbJVyzQ8UBMF/ikTnTqpCEYjNGk7oNphonLufq/cYpVReu7hZfIR6MXPl8nZ oa0Aba8d9yFzUz+jVwyxOqz87G8xDF8gJkqp4AOYOWx4Kv/+aOJiTUBZSHwCKY0K/8Dn v5I0fpHXiga8jpL3GINvAbDckdXKw4wib1pVWLafVbisHSutzNki183MyOKdQxI5RzPd Q0Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769296569; x=1769901369; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FqRHnF/Kmqh8JjtTS/h08Xf4/E1jwltyp2WHm6FwYbA=; b=MiJaxapluy4K6fZdulq4+ufwCr7SpJMKLtvecpnsKSjsFtKe1td12n60uHFikvXWcj 7DmYP+HDh8VRM1gsSIsK60r0wOLiaqznlHYPQcp5PGz5jX/i5IyfYkApPnE9sQ7IRluP CIYBnCXjsbioj4ix8QmRR3pof/27NDeXW3aO9e0azJ5saY+dwN9Fssr5zdXFvnK42xXQ bqMX6hTDUAsilBwYSSS3z054JTeZd7nYInCtb32X9Rwnh7OeDWnpZWmNNbiazI/Z9DS0 0KVp6EhFR0Z9qzFJ6sZUP5+zmD3AQkpXetQ9XhJt6nheIfrgCfZ50rf1qHPYfhcudZ8o S2DA== X-Forwarded-Encrypted: i=1; AJvYcCVcI618fLHl4swO0zX9iLJetJnfX5aCkxz1QmfwbErhvM4FLqW0oyi94oWmMGQbze+pLqbNToLmNUufdws=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf2+z7dl2Pqht0bOmHaswbOvaCMettowuyGnOGjpyPZnTmgStN 7VzUbff17IQxC5cQmUl1YnQzbQRY9Cs0wqQnllz2eFtQzIOLk5PtreY0 X-Gm-Gg: AZuq6aI0Qw8nMY/H7X8ZIPIOD/QxjrRkjK5JlzFGJvDYPt7yE4F0GqYO8Q2Gu3lAOlX G9S7v25CiFZ5pQsn2ws/yAxocRTsX9KmwXCnZz+dX03+8T0J3l10rxEsgX56D/PNisXLnECCZhg bSv0fkgYV+KvKD+2MHYH1q3akH+icsOSaXpMuycf4544l+T119XPxyFOW2dhRxziHnYcSn95/uC f/RbUDn4DdA25sF1BMuk9MDaYGTj2yhtJxd8WyfTL01/c5SDfvW2cHEzX6f+bBZo6x8n8mkkmkw y2wQGJCyeMYFsbbw4CKUjMwHHwi6QYytWi8uch10Oxd9qlt5SeqDP4v/lDpxjTbl0rZt+YarzlT YSHN7bd/+qGtvPSRvkyoRBWm6H2xrAnidrZd7T8M8JA3NtVjZ5OUekw52TFpydzvx1mIHjZB/EM laUV/8XsfHxzAS2Rea7iEpznTZd6RsvjY9 X-Received: by 2002:a17:902:d48c:b0:2a0:e532:242e with SMTP id d9443c01a7336-2a8451f904bmr1758775ad.11.1769296569314; Sat, 24 Jan 2026 15:16:09 -0800 (PST) Received: from tehuang-Alienware-m16-R2.. ([50.47.240.160]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8231873bf53sm5604506b3a.45.2026.01.24.15.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jan 2026 15:16:08 -0800 (PST) From: Michael Huang To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Huang Subject: [PATCH v5 0/7] staging: rtl8723bs: cleanup and refactorcleanup and indentation refactoring Date: Sat, 24 Jan 2026 15:15:50 -0800 Message-ID: <20260124231557.18189-1-tehsiu.huang@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260124104920.5721-1-tehsiu.huang@gmail.com> References: <20260124104920.5721-1-tehsiu.huang@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series refactors the function in rtw_mlme_ext.c to improve readability and comply with Linux kernel coding standards. Following feedback from Dan Carpenter, this version (v5) deconstructs the previous changes into seven atomic patches. This separation ensures that logical changes (such as flattening nested loops) are isolated from purely stylistic cleanups (such as fixing indentation or NULL checks), making the review process more straightforward and less error-prone. Each patch focuses on a single category of improvement: 1. Logic flattening: Use continue statements to reduce indentation. 2. Comment positioning: Adjust comments to align with new logic. 3. New lines cleanup: Removed unnecessary new lines 4. Line length compliance: Resolve 100-column limit warnings. 5. Operator spacing: Add missing spaces around logical operators. 6. Braces removal: Clean up unnecessary braces in single-line branches. 7. NULL check simplification: Use the "!ptr" convention for brevity. --- Changes in v5: - Split the series into 7 atomic patches for easier review. - Renamed "guard clauses" to "continue statements" description per feedback. - Separated logic changes, comment refactoring, and style cleanups. - Fixed indentation issues (replaced spaces with tabs). - Simplified NULL pointer checks to use the !ptr convention. Changes in v4: - Corrected the patch format by moving the changelog below the "---" line. - Initial clean public submission of this series. Michael Huang (7): staging: rtl8723bs: use continue statements to reduce indentation staging: rtl8723bs: refactor comments to fix the line length warning for exceeding 100 columns staging: rtl8723bs: remove unnecessary new lines staging: rtl8723bs: Fix the line length exceeding 100 columns warning in the code staging: rtl8723bs: add missing space around operators staging: rtl8723bs: remove unnecessary braces staging: rtl8723bs: use !ptr instead of ptr == NULL drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 129 ++++++++++-------- 1 file changed, 70 insertions(+), 59 deletions(-) -- 2.43.0