From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C9AB2FFDEB for ; Sun, 25 Jan 2026 20:03:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769371391; cv=none; b=d3iJp4lE7MHW/u/fy6In9U7Nj0YO9x/PyNLUKYSVcDDARQLGn5aySWnmnIzqcSh2wvZRKMC77CSLt8Whn1eUvopF7J/nKWouUVfHzuOO/fhsfGJQvgRgM7VCnGd/xDpsmqO70ESwUHHvDpSf6KHd/R4vbXbjLMWmdMOJJOoNBbM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769371391; c=relaxed/simple; bh=4ISCSbP1GHcNi8YVt/KPuKGZhNss45uvPh4/YQABkJ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k5m4i7BbrJ0O2MvhCxejHDpuCOAEfmKCJ+PvNv0vhFEcW1gz2qR3SzMcjpn6FhxjQCscYqkHGRtajLSxEo9wjZ7EYjlHmORzsyLwdvbUtFTc9xg9VehuGjF7ElUK/AS11iRp4OMVw1enIRMLJx6AIu8ZR+VvA8YiqvnvVuK97ks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QTEfiv53; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QTEfiv53" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4801c731d0aso30069655e9.1 for ; Sun, 25 Jan 2026 12:03:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769371388; x=1769976188; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qdDdAuh4mZgLombsRYAsCKtJ/m83RDaQrk7CHsW3INE=; b=QTEfiv53ugakoksFFqjesYXCq8QBHTOI/yk55ezhhyvV2MGyjhgpJngzZNl35cxPuA CUyUGdjHjX4k0KRLBqmS2/oTumhX5tBZK/4KeOxiGERw2jEUwYSIe6qIFH1x1dYvnIdV 85R62Bxo4Xcm1LcoZEt6EWFfsBWIwToC7UUQ9Pg7NsLV+rsZ6eMzPAUch71izBGztsfx CsWDJQcIrus83Z+FGtpgAcSR+LsQAsNNAFYUtHwzuBVoG9sp+akuEIGISwfusQSxeQvz yI/g9XSJkFUYv0SlwfwXN12vsEBdVBl1Wo3uNX43j7yvwvTU9grPOMTqasTBZa3nG4e4 wvEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769371388; x=1769976188; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qdDdAuh4mZgLombsRYAsCKtJ/m83RDaQrk7CHsW3INE=; b=IZ1Gne568Sfnl9NwrbS/FcabAYqpBC0qsPF4UJZ6SPYNk+s8SH/oFw5IpoIIQG6i87 3iEAzv0it6LbVeZoQa1En0CI/If4KcJBZnE9gOf5vzTzz4m8FIaImIu35qRnnIdbWKfB Lmz98QWtjBZYeCTL+dux6jwmC9dGT/3+odvlkpd+8jINZ2VAUfrDo3DM4sWvVqbSzyvY tVkluOOsNi5wwFtezr20PNuBZmwORkX8fqLO4cdtxgYAlk7YqSe4CwhUBnlpZlb1JxfU J1u/OZx22f93xAQH/xcUhxE7VxobJ5bc4R+tG69g0WqV1FGbU69YSZbzAsgEk8IMuEaD suzw== X-Forwarded-Encrypted: i=1; AJvYcCVSyp3caQy4FMjztbZ/bFv5T0V0/Pxd1Rv9s4l0znuXdWcxOj6VfdMjumM70HS17Gs55MRtcbGuoer/+2Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3RbfnnoUdEOgxuo5licUE8PC2dimIt54J+UrxMVwWdusK+Gwi +2yrCtJIzzvQlFyGuYGcwG75lNsMYXqRWI9qud4pco4lULG0qVA79Hde X-Gm-Gg: AZuq6aI+mr3QdyVOAjTK5YaXY5RbMgRSsXQy2AVhq2OVPj75mF7GJdFkF6zPorkt/5a fWu4Jay/vXqjXk/eowkQ6u+WwnmXz8iHyd5C0vzU1kzcdsiQVps3hTvJ6hpj+k3NzqNjFsXyD82 YajIVVfdPQwX04uqQ7f27jvH35j12cVYbL2wPpj6qRzIrjSFHQn4LQWkHMKBwOeLyR8HXKpEVvv 6AFo30drnHhBiT/26RHR0oQZdvwew6fi6YGII/z1EKO8qYWXM0cAGg5ec4Fi3eixRdJ4nxyLqAD Zw1mSIFISwkNFF7YpvLliM0hGFcmN3oNW5BI7xqTI2IK0lMhTZAUE8XMgSqyp4JMiDRJDlQkoC2 2wCk3Ukl/mwINVMY6o5BPrpYvLVRNEv6xEypt5NgHsFAmkXYrG+Qjn+WX4uKSu/hrixh9cVsVkL JkPl/1rkxuEP4= X-Received: by 2002:a05:600c:4f09:b0:47a:8154:33e3 with SMTP id 5b1f17b1804b1-4805cf66b06mr40577535e9.28.1769371388491; Sun, 25 Jan 2026 12:03:08 -0800 (PST) Received: from nas.local ([2001:912:1ac0:1e00:c662:37ff:fe09:93df]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1f7c269sm24418036f8f.43.2026.01.25.12.03.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jan 2026 12:03:08 -0800 (PST) From: Damien Dejean To: andrew@lunn.ch, krzk+dt@kernel.org, robh@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, hkallweit1@gmail.com, Damien Dejean Subject: [PATCH v3 4/4] net: phy: realtek: add RTL8224 polarity support Date: Sun, 25 Jan 2026 21:02:59 +0100 Message-ID: <20260125200259.2903271-4-dam.dejean@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260125200259.2903271-1-dam.dejean@gmail.com> References: <20260125200259.2903271-1-dam.dejean@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The RTL8224 has a register to configure the polarity of every pair of each port. It provides device designers more flexbility when wiring the chip. Unfortunately, the register is left in an unknown state after a reset. Thus on devices where the bootloader don't initialize it, the driver has to do it to detect and use a link. The MDI polarity swap can be set in the device tree using the property enet-phy-lane-polarity. The u32 value is a bitfield where bit[0..3] control the polarity of pairs A..D. Signed-off-by: Damien Dejean --- drivers/net/phy/realtek/realtek_main.c | 39 +++++++++++++++++++++++++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realtek/realtek_main.c index 9c149b05c767..f98431a8f0ba 100644 --- a/drivers/net/phy/realtek/realtek_main.c +++ b/drivers/net/phy/realtek/realtek_main.c @@ -164,6 +164,7 @@ #define RTL8224_SRAM_RTCT_LEN(pair) (0x8028 + (pair) * 4) #define RTL8224_VND1_MDI_PAIR_SWAP 0xa90 +#define RTL8224_VND1_MDI_POLARITY_SWAP 0xa94 #define RTL8366RB_POWER_SAVE 0x15 #define RTL8366RB_POWER_SAVE_ON BIT(12) @@ -1719,9 +1720,45 @@ static int rtl8224_mdi_config_order(struct phy_device *phydev) RTL8224_VND1_MDI_PAIR_SWAP, val); } +static int rtl8224_mdi_config_polarity(struct phy_device *phydev) +{ + struct device_node *np = phydev->mdio.dev.of_node; + u8 port_offset = phydev->mdio.addr & 3; + u32 polarity = 0; + int ret, val; + + ret = of_property_read_u32(np, "enet-phy-lane-polarity", &polarity); + + /* Do nothing if the property is not present */ + if (ret == -EINVAL) + return 0; + + if (ret) + return ret; + + if (polarity & ~0xf) + return -EINVAL; + + val = __phy_package_read_mmd(phydev, 0, MDIO_MMD_VEND1, + RTL8224_VND1_MDI_POLARITY_SWAP); + if (val < 0) + return val; + + val &= ~(0xf << port_offset); + val |= polarity << port_offset; + return __phy_package_write_mmd(phydev, 0, MDIO_MMD_VEND1, + RTL8224_VND1_MDI_POLARITY_SWAP, val); +} + static int rtl8224_config_init(struct phy_device *phydev) { - return rtl8224_mdi_config_order(phydev); + int ret; + + ret = rtl8224_mdi_config_order(phydev); + if (ret) + return ret; + + return rtl8224_mdi_config_polarity(phydev); } static int rtl8224_probe(struct phy_device *phydev) -- 2.47.3