From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010004.outbound.protection.outlook.com [52.101.201.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10CD72F6573; Mon, 26 Jan 2026 08:01:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.4 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769414490; cv=fail; b=giJL4r0enDBliVwfV9Pu7/7EVgivsTbyhRwMUPIEswO6e0TzUKCP3YY1/5v0YV5ldc7GdTlTDmWprNvWG2Ib/jGHChAmRPqkBdrC3t/Qap46FLTeCwr2xfZBQlkT64kpWw/N+fo77WpBjCOne5paiyQM2+NIUs3nbmK8/8UU7LM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769414490; c=relaxed/simple; bh=JJ7a5dHGMQVPUQtQJw3EvpSNQm/hqs5JwGN9O4JFbIg=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Sga38iItw0PAACXsUH+ZQYZeSKL6yXQtpj05aVZuHfaAbWmazWmwLBWAYWEcnAPinefZnRJ+SEK/jYI+sHJoaqCF2ZByAEIDSZD3+Yja7XqtttaM/Pqhy+usgVJT+YPBd6uEsAjxAW+coS8bCT6vXVT8F2na4GerE/iZDpkPYIE= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=fZppHxII; arc=fail smtp.client-ip=52.101.201.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="fZppHxII" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P040wZUGTKiath8iDRKxgQZhB7nmeR4cPu64VPw9s2Bi2esu3z0J08btER2Y3c7v9byDs/hRLi2B4Mk7OHSZAvS8LO8aQCtFc5NQqw3G1/lIn0KvFGCfJmP5aXMymxTEVe4xpxrWlC0Oc9/+CaCGIj1h95muXK3W4zZD2oK5Br3GzHFhn8r2ppDXsyS1NKZAROiQeHC3LIA/VslDNxRxY1oH9RNhV+ok0RCIOpcz8a3wSXfAkSp6deB7egvoAH4Rle2VTQWgNo8LWgQIH4TexV0iZ4KCpbowbRz6tAfqDRpk/JH/NbjnqpKeha5KNrqZVV+iHIQ1/WPsO29O8UOlAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=02hEdgefenIji/s22rcGcymB0W68O3PM7mj75fROR78=; b=AhN1rXL6N3iKHlyxOneo0kqqG5GgIY5jFJXpS5yIY+PyTS02S0JhM7G6oqWpcDd2gRD7vM+62KMdxXKnFiVa1OdX+gtLWSRId61LQTbsjbr/mY8Kk29OrdqQb1/Gg5RXRUNq8yepDXDqSK6s7iFGvZxzMnRqoQ1MYA3ZkVH/gbN3A5A5396+/lpq+X6vPyoqU/Jr9sj2JIo1PFygavSGow3fEg9joJC/BgSyih+rlltgNhFTTBQdShC+1V17XXIl67qM/mz2R3MuPtktWCTxIgDrQ8uENQmkZThfIsC5S5Cd3b5uOrgLTDC44TPZjpaRoouf9C7f8lc9roKiLJjoXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=02hEdgefenIji/s22rcGcymB0W68O3PM7mj75fROR78=; b=fZppHxIIH5CX152rIMjG32gpsYottVmZzmlAjliQCtWw3pcjeMxgn05Gc+dQ+uGktSsjrKQkRo+bl86ZwJpQBDP/594Hu6A4rKK0RQV/UW1v6oA3T4fGgBRpaxkwZSADoOIw8OLCVQOFsgg7gjz+m7yozwOBnMLPJk4SeuIYNP/q4Xj1vJlb4PaSEB9l6FkuL1SXBgfhw2Vl88TveYVU0aMJ9B4ntfS8bdJEBVlNQ6HwpEcYd5GjOLgounq4dyUEltZMJ2AJwfx3aauEDvVgHfu7t+tNnJUULjuueml1pB6GFtSMq5QzFhjJ5QeV6s9n1Irmb+wKpSeXFT4Z3tdciA== Received: from BYAPR02CA0005.namprd02.prod.outlook.com (2603:10b6:a02:ee::18) by DS0PR12MB8318.namprd12.prod.outlook.com (2603:10b6:8:f6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.15; Mon, 26 Jan 2026 08:01:23 +0000 Received: from SJ5PEPF000001F5.namprd05.prod.outlook.com (2603:10b6:a02:ee:cafe::8) by BYAPR02CA0005.outlook.office365.com (2603:10b6:a02:ee::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9542.15 via Frontend Transport; Mon, 26 Jan 2026 08:01:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SJ5PEPF000001F5.mail.protection.outlook.com (10.167.242.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.3 via Frontend Transport; Mon, 26 Jan 2026 08:01:22 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 26 Jan 2026 00:01:13 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 26 Jan 2026 00:01:13 -0800 Received: from inno-thin-client (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 26 Jan 2026 00:01:08 -0800 Date: Mon, 26 Jan 2026 10:01:08 +0200 From: Zhi Wang To: Joel Fernandes CC: , Danilo Krummrich , Alexandre Courbot , Alice Ryhl , David Airlie , Simona Vetter , "Alistair Popple" , Bjorn Helgaas , "Miguel Ojeda" , Alex Gaynor , Boqun Feng , Gary Guo , "=?UTF-8?B?QmrDtnJu?= Roy Baron" , Benno Lossin , Andreas Hindborg , Trevor Gross , , , Subject: Re: [PATCH v1 4/5] gpu: nova-core: use checked arithmetic in BinFirmware::data Message-ID: <20260126100108.7f65d262.zhiw@nvidia.com> In-Reply-To: <20260124231830.3088323-5-joelagnelf@nvidia.com> References: <20260124231830.3088323-1-joelagnelf@nvidia.com> <20260124231830.3088323-5-joelagnelf@nvidia.com> Organization: NVIDIA X-Mailer: Claws Mail 4.3.1 (GTK 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001F5:EE_|DS0PR12MB8318:EE_ X-MS-Office365-Filtering-Correlation-Id: e6a02f6a-7ad2-4d30-d2a5-08de5cb118d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|376014|7416014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?sbk42pyTRMbmFc9ITSLc0rK0eDAiG5llSvU2Hg1A3FlffT1/A17fFVefSIeT?= =?us-ascii?Q?0IIL0Q/E7SqOFiI7DCAZQV9tBAoSr0mdyv992iSiCBYQWkEW2EmHkPUYTHGB?= =?us-ascii?Q?Q64+w1eG8uWKNY4sHeTEh2q1qzmXppB0hxRTbohJMplB2jhrQBXdbejOx5vN?= =?us-ascii?Q?O6EYIoUAVez778cg1hIqEVie1bp5GQzRqcT4PniVCn4OEmtvACG3OKiiJYZ5?= =?us-ascii?Q?B7omAaDoAx+1kSUa28dz0Q6kx+kIv5f6U/js/2pKgeTobdWIAWHnSuB66xia?= =?us-ascii?Q?FsauX4pI9UNLHLPxMKyaodq9flHoAyEHx9rzl/07ibj+TcJA+hEWjdFju5jp?= =?us-ascii?Q?TPrpwL/2Tvz2ahCLvnCki72SpKUq0Rfhk5FRooA8bHW91L0HUrN6RJgXhK0a?= =?us-ascii?Q?mzRgIBH6S932eusAMv1ZFFVKDtqDF1uAHC4fU6KpjUR+zrWffUv+vYXnMc25?= =?us-ascii?Q?AHAdGK+cLPJ302a2AW0qJB26ArIDKN3fC7efr91LoL/6DQ6UIOVWV95UoKx7?= =?us-ascii?Q?uguS+8nHOV9ZMwTreZVLJWPTVyYFXePLrU+9SzZOm6dpDZwTr+LbhQfD0NaH?= =?us-ascii?Q?UBABHr52kPpkF7R63jpEoO/oYoLqwFpwXeQ/OQzDHo7pE+nb+6X2nW1FsdDf?= =?us-ascii?Q?GeD/lErE2gP7CYIZ8R5rq+fcmaSpsMJ6D+8laGePePQhg8uaQKVAR6wA6XPj?= =?us-ascii?Q?/EXMh28A/YjwmYvzgtC4Y8j739h3hKnpRsmMH44L6nubUdRNTpABn5r8aaGz?= =?us-ascii?Q?2o4rPh0KDSSIHjNF8BHZc9e0yJjnMYqNNc2zReli0QMrtgfpHTDSQi7N7Xml?= =?us-ascii?Q?fI7o19pap00M6f1MZ685eNxITpIYtdDvzKsFE5wc/HUdqOH2HyNyhEW4+2Ry?= =?us-ascii?Q?4291ZzLmY7Qbn2naeJ8URKXSvMngzsWcfr58OWp0Dbihm4PrccdydDujEakb?= =?us-ascii?Q?+CpeghNiuuvqtn7c/Qz8IIdAQB+5oq1fJiv4kDrueGRyEKfUtessko8cbevz?= =?us-ascii?Q?dkCYqnLo8WoTGESnRRmd2IC8rWRd7XOZrN264SF+x579GXH3arcl4SvjgH/a?= =?us-ascii?Q?gfexQgWVqD7i5ca65bglfLODBN5PQt8xMAKS1v9g5TzxL2c/zuqVRUx+5cmk?= =?us-ascii?Q?I4zUZ21kSx/8oEFmYMOnJGLwWwIuFXpTJxp2aZzvVZcCZxVh17SGjAsnRSLC?= =?us-ascii?Q?RihiZV5KacicY+O9oU2vLx887l+BwCDVNSYrThBocmuPwLKmmaDVkeeTsvx1?= =?us-ascii?Q?xdH3QA3tgB9zE8AkOWAANbZD3yqozttAoyetvLiSVSTHx3BL57YkWGWW9B7q?= =?us-ascii?Q?v9UPLmVZ5l3D2zNkwPpRe/9PKPHeMhynsHz7xDOIF/3glRhBPnM6NLVvq7RS?= =?us-ascii?Q?2s8iou7CvhRhrPYE2LSV4n9WyHvB0ciSviqF0nMQHulyWstoUyHedPdodK8V?= =?us-ascii?Q?mBY0bGukPodpGC9aC9eSKNaZ8ysM3mehm/tAIObP3mVC/NIB9Abmyb5SIDWx?= =?us-ascii?Q?gOi9P/h0IbG03zhtsKw9vDrVD0Fu6/tc2CneaG1eL7A1Fy2d2UpIuopB2Iie?= =?us-ascii?Q?OasQ9v5xbMVIUXG7559Vlhuh5yW6f9bmmEGlZebrEZYlFWjhFXpbn+8z7+xj?= =?us-ascii?Q?5HVd6Nez9LH7VHFy+SLZvukknbwGpEBeeAWMR3l0xJBzWFHD95vw4D76ayeE?= =?us-ascii?Q?KkXF/A=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(376014)(7416014)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2026 08:01:22.8601 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e6a02f6a-7ad2-4d30-d2a5-08de5cb118d5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001F5.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8318 On Sat, 24 Jan 2026 18:18:29 -0500 Joel Fernandes wrote: > Use checked_add() when computing the firmware data end offset in the > BinFirmware::data() method. The data_offset and data_size fields come > from the BinHdr structure parsed from the firmware file header. > > Signed-off-by: Joel Fernandes > --- > drivers/gpu/nova-core/firmware.rs | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/nova-core/firmware.rs > b/drivers/gpu/nova-core/firmware.rs index 68779540aa28..4f57a270e142 > 100644 --- a/drivers/gpu/nova-core/firmware.rs > +++ b/drivers/gpu/nova-core/firmware.rs > @@ -394,8 +394,9 @@ fn new(fw: &'a firmware::Firmware) -> Result { > fn data(&self) -> Option<&[u8]> { > let fw_start = usize::from_safe_cast(self.hdr.data_offset); > let fw_size = usize::from_safe_cast(self.hdr.data_size); > + let fw_end = fw_start.checked_add(fw_size)?; > > - self.fw.get(fw_start..fw_start + fw_size) > + self.fw.get(fw_start..fw_end) > } > } > Reviewed-by: Zhi Wang