From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jocelyn Falempe <jfalempe@redhat.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Nicolas Pitre <npitre@baylibre.com>,
Calixte Pernot <calixte.pernot@grenoble-inp.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] vt: Add enable module parameter
Date: Mon, 26 Jan 2026 10:33:08 +0100 [thread overview]
Message-ID: <2026012613-cotton-jellied-b67a@gregkh> (raw)
In-Reply-To: <20260126092234.713465-1-jfalempe@redhat.com>
On Mon, Jan 26, 2026 at 10:21:50AM +0100, Jocelyn Falempe wrote:
> This allows to build the kernel with CONFIG_VT enabled, and choose
> on the kernel command line to enable it or not.
This says what is happening, but not why?
> Add vt.enable=1 to force enable, or vt.enable=0 to force disable.
Why are we using a 1990's technology for a new feature? What is this
going to allow to have happen? Who needs/wants this? Who will use it?
For what?
> Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
> ---
> drivers/tty/Kconfig | 13 +++++++++++++
> drivers/tty/vt/vt.c | 5 +++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig
> index 149f3d53b7608..2b94c2710687a 100644
> --- a/drivers/tty/Kconfig
> +++ b/drivers/tty/Kconfig
> @@ -41,6 +41,19 @@ config VT
> If unsure, say Y, or else you won't be able to do much with your new
> shiny Linux system :-)
>
> +config VT_ENABLE
> + depends on VT
> + default y
> + bool "enable VT terminal" if EXPERT
So no one will ever really use this config option?
And you are doing 2 things in this patch, not just one, unlike what the
changelog said :(
thanks,
greg k-h
next prev parent reply other threads:[~2026-01-26 9:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 9:21 Jocelyn Falempe
2026-01-26 9:33 ` Greg Kroah-Hartman [this message]
2026-01-26 9:43 ` Jocelyn Falempe
2026-01-26 10:20 ` Greg Kroah-Hartman
2026-01-26 10:30 ` Greg Kroah-Hartman
2026-01-26 10:49 ` Jocelyn Falempe
2026-01-26 10:57 ` Greg Kroah-Hartman
2026-01-26 10:48 ` Jocelyn Falempe
2026-01-26 10:59 ` Greg Kroah-Hartman
2026-01-26 12:26 ` Jocelyn Falempe
2026-01-26 12:46 ` Greg Kroah-Hartman
2026-01-26 13:05 ` Jocelyn Falempe
2026-01-26 14:36 ` Greg Kroah-Hartman
2026-01-26 17:24 ` Nicolas Pitre
2026-01-26 22:59 ` Jocelyn Falempe
2026-01-26 23:00 ` Jocelyn Falempe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026012613-cotton-jellied-b67a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=calixte.pernot@grenoble-inp.org \
--cc=jfalempe@redhat.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=npitre@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®