From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFC2F3B2BA
	for <linux-kernel@vger.kernel.org>; Tue, 27 Jan 2026 00:54:51 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1769475292; cv=none; b=Gjr6ne+ajI/N2KIuRrNM1J0EqlV0MtRGjmzIRv0EJEeXT/TaEZ1SPqL5VHOWARGrhYq58OTef2t1lP9HOYpacUeHZiPfe2Qeh4/XpUlPkUaqtTq+2JlcEoXMf8roBNhRzwzjnWwFd76mj2ot36+vsgJuILYB4nObj5GkNL5sdhU=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1769475292; c=relaxed/simple;
	bh=LZPriA/jHuid6pYIukx5fnT/307wVTdTm8js7QxCA5g=;
	h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:
	 Mime-Version:Content-Type; b=BH5g2bxyhpe1Xke6hxntJX0xOzSbSVwIe7ynEEcZUkmt0TbqA5ycdj4xy62SzPgqUhGhhcWhipk82nDCGQ1puXjb9YbubfvpYiwHliHvp1uo+KRIPnq4ImO3qcGyME0uDeQ/2TQU2hPBVnMYiasIQBQciGYF0ycJjwgh3uzhCrQ=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=MYvDOf/r; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="MYvDOf/r"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B346C116C6;
	Tue, 27 Jan 2026 00:54:51 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
	s=korg; t=1769475291;
	bh=LZPriA/jHuid6pYIukx5fnT/307wVTdTm8js7QxCA5g=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=MYvDOf/rpiicmFao9wc13j0PnuLuUnOdgbThX6PnZwFE3Udy9CnMozPLoyNRY/YEs
	 zsI9niOa1x+AL35JS5pb1DAelpX7aPke/S70VA3baJMA0q9jbYB1qATNfAcZqA3FZ4
	 FcF7AuHIhcVKIgc1cFmtrXOUoZA5AnrMQIzrvcD8=
Date: Mon, 26 Jan 2026 16:54:50 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: SeongJae Park <sj@kernel.org>
Cc: Thorsten Blum <thorsten.blum@linux.dev>, David Hildenbrand
 <david@kernel.org>, Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
 "Liam R. Howlett" <Liam.Howlett@oracle.com>, Vlastimil Babka
 <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>, Suren Baghdasaryan
 <surenb@google.com>, Michal Hocko <mhocko@suse.com>, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/cma: Replace snprintf with strscpy in cma_new_area
Message-Id: <20260126165450.f83b1895deeda8e4332a57d3@linux-foundation.org>
In-Reply-To: <20260127004723.74422-1-sj@kernel.org>
References: <20260126174516.236968-1-thorsten.blum@linux.dev>
	<20260127004723.74422-1-sj@kernel.org>
X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 26 Jan 2026 16:47:22 -0800 SeongJae Park <sj@kernel.org> wrote:

> > @@ -233,7 +234,7 @@ static int __init cma_new_area(const char *name, phys_addr_t size,
> >  	cma_area_count++;
> >  
> >  	if (name)
> > -		snprintf(cma->name, CMA_MAX_NAME, "%s", name);
> > +		strscpy(cma->name, name);
> 
> Any reason to drop CMA_MAX_NAME protection?  You can pass the size of
> destination buffer as the third argument of strscpy().

strscpy() will now use sizeof(cma->name):

	char name[CMA_MAX_NAME];