From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E1A23128A7 for ; Mon, 26 Jan 2026 23:38:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769470720; cv=none; b=FAQ+MPZs0wz2AJ4frtw1CRuvFmRSfD5PKlEWAIsy2K5EsxtWitMMvZQVk3hqTQpzBRULvUUqwBlrONhn+s4mrHF3MrAlHYvtI2n+BkJ2YY9pphBCk1dHZTZ3I+GsOVeXYoGFdHTzEcRjQnnu9m2CKVCKSc1vh4ExNs3j9xLHmz8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769470720; c=relaxed/simple; bh=9B1FnLaHALjYfJ8RPCg5eOxKik1XLzUO5cKu4vZ+ZZw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=by/jfXqVkaLZF1fMr9wgmJ+1Vi2WcAQArwF/He45Tb5NdIZRsHj/ph1/7UD6T/MW753Yxsl89n+GcY+PZhd9ae8JC0xKsB8NHq70FJ/3en8/jE4oySZClxcUFrIi4r4RE2dIilMzfPYyj655zA06Q2gqst+yTpFCN0dA90WaXtE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TtPimG74; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R2s8rRQP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TtPimG74"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R2s8rRQP" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60QKgxIp3400445 for ; Mon, 26 Jan 2026 23:38:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=1qylKAN4jaI gqx7JT64dI6YQstiaPDg+rYzw4T90x1I=; b=TtPimG74CKtPf7oPPv3tG/NYnVB /ZHHF4GvKs9T7jk2s1523Xw2fLjTfNyCuattR5lOtKg/9qjiPv5EVpFezNEnrwqg A6phNAKOmBG7tOnhLa5mH/JJMMdp0imRBtWrGkGQCo0l2kOxE7aCefVGGcdhyDoO Wp/iDmDCHW3T0F6o81/hivcUamP4tWvioK5Xw7A1+PleTCPlz8pVS7dHJyanOMoa +ZGBTah8pBBREkOEPWJyYC1xFJC1Q+T2XT2w7uLy+AGKE4fv2GGcm8bge2VNPBBe Vt194H23L6pu51Q82X1h6sB00crgmo8ryWwScrJT0XegUCFkR9FcsgY7MKg== Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bxdv9gqx4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 26 Jan 2026 23:38:37 +0000 (GMT) Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-12338d13f2cso6030144c88.1 for ; Mon, 26 Jan 2026 15:38:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769470717; x=1770075517; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1qylKAN4jaIgqx7JT64dI6YQstiaPDg+rYzw4T90x1I=; b=R2s8rRQPoCzvV0FpE7eueEWZrCjDp+s/jBjHX1xrgwoROYcl32/IiTHpwwREHrgI+/ y5jF+F+sVj5jK6cxeafQqt23F0/E1Ky1VrFXzs78CNHg4Pbd019VQMEuxdyXAZlMk4vE Dk6mwwRWiwhUl/awCihVgIfsyS8B+imCNdq5Uh89b2TdKMu+Zk/HCjg6kLM27uybsFdb EcMyROvmMOXf59UWjHjU2HRXVciyXxyqGFElxgBFF6ZL6cBoaFqPtY9Vqcvacc2VYBO0 EtUxjFtZo0pbmHDx5zmOemIWeZs0yNIe6KW6noqBszSpcQpNy68z7crRrIovl5VVwwl3 iSYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769470717; x=1770075517; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1qylKAN4jaIgqx7JT64dI6YQstiaPDg+rYzw4T90x1I=; b=lGfedMe/SbIp3h0KIUByRXdighJf0HEq7FuRNv9PmeEh5VXaBLf3lY62Uynl/3DLq/ FBOGbi8fzNxjn72eO7KyBakHQT/UfoKLd/WeCz7aC+lcXvBpo39LQE/qUTE97Uh2f73s WwdTtRVhNqAaXKyhfEyZcyu6Psm5LVEpy3p5oCfZTdi6zPzwpSQ7S42zSD7mpEmYGeBk mRY5nYoTah3aQWcRlLpptyLvbI0mTC/G8t9rYxbhYMz4thIDqqaIONo3JAsIDiwwYZ7y feje251FLySMWn6OFeitVCbLZg16H/fXrMjqVxTJ5/Q85dZYOmkbqWKLSp4JcR5jTEfR QCAg== X-Forwarded-Encrypted: i=1; AJvYcCU1T4SEwvWJ9StyAkHzVoLPjWE7R/umRE3VV+QXZMZqvgnbMFeeyhsko2FeeGjKX0C5l5LvD9xQ5En/Lyc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8vgWbv1Q1hs5TKbGchZkdklR84sV+anfXuzVUchDOavnyC5bO 6cLbZoS7SoWtYzN28NaoirWB/0Zen6Qsi5HUnplDvrpnn5zrF0e0z3MC4bxYtYSzFp82W/gC4cp +pvTkotH7dsMw4k7fsEJgUNOYxJQgwtsJOlXJ9/uKs+BqCZ1Pw9Fc0YbMXF7PdhwiuT2UeECI9i I= X-Gm-Gg: AZuq6aLz8hY5kzhMu807YnRjbZKsexZKV3Q7mgQdHjbzIZva4jkaWp+UsZ5mkY59v4W 14bE+3tJdN5KGkm6OzLJT3VcJwMpVFYp6AK1BpS6eZtxNq3PG8v1htzUjo9wiqInZBJv3VUqXkP L+lVxVbSnmXAzujp0LRW8t435iIxfV8408Ipq1u/IFAE4VeNZdw4O6VMoXqiWDAjD7mltGZ40Q5 751y6M944afQU9f3wOqedoqeAxkD28LLS0sQmsSeZu77OaZSev54z8EmKnN2IOmpDPjQr9GILnF Fy3pqX6/5aygKIscahnjvp2vZ64bhDQmoH+nGY9JInw5RTyEdbGFY4BKwI9QlGJCWPj6uDoq5UG FCJ4CwEj0jaTJKIcZNojL9wf99RyumIsQu7pQzSiwAXMYZdNBAUufjV7oQg4yo4E= X-Received: by 2002:a05:7022:671e:b0:119:e569:f61e with SMTP id a92af1059eb24-1248ec5acf2mr3215088c88.23.1769470716750; Mon, 26 Jan 2026 15:38:36 -0800 (PST) X-Received: by 2002:a05:7022:671e:b0:119:e569:f61e with SMTP id a92af1059eb24-1248ec5acf2mr3215069c88.23.1769470716223; Mon, 26 Jan 2026 15:38:36 -0800 (PST) Received: from hu-eserrao-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1247d90ce0dsm19948967c88.4.2026.01.26.15.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 15:38:35 -0800 (PST) From: Elson Serrao To: Greg Kroah-Hartman , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Souradeep Chowdhury Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/9] usb: misc: qcom_eud: improve enable_store API Date: Mon, 26 Jan 2026 15:38:26 -0800 Message-Id: <20260126233830.2193816-6-elson.serrao@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260126233830.2193816-1-elson.serrao@oss.qualcomm.com> References: <20260126233830.2193816-1-elson.serrao@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=OYOVzxTY c=1 sm=1 tr=0 ts=6977fafd cx=c_pps a=SvEPeNj+VMjHSW//kvnxuw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=iEam2xx7WbKG8qDqzoQA:9 a=Kq8ClHjjuc5pcCNDwlU0:22 X-Proofpoint-GUID: 5IcGEtqx0BjQMmt8AZzISVnJWLJ7QWHv X-Proofpoint-ORIG-GUID: 5IcGEtqx0BjQMmt8AZzISVnJWLJ7QWHv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI2MDIwMiBTYWx0ZWRfXxhcxYLUEJgxz VGeBgtGng063ldwyAmbTvYQjTPPp+MixVkPlPowBKUL8Q4cmi8fhF1tj0vixozCOfnSPKuwLBG6 VtHwj+vsq4y9sWaRN6y3OQcBh6f8qmcwHKEJuL+tropULUKFtFi2CvbFmJGx0VnbOuxGkbc0fDh m2+Uq2D/4bfzBcZp/qWl8BMjtqUbh+SgC0SBkEzr0P4mUpz/+KBCstDcvC0uVEti1moeFFWkP8Z Erfw1TfxNZ5zUnJz+IfRTsy792BdlYEskCDI9w8HhhfL9zXc7MlEJ+yy/SMioUnZeSydTt6VmjT 75Cw0dQ1DR9qMaeMEq5hxhVV9dw99EngfsmeGEVbmm6YHRwcHzqdVIRI0zidprxZz+yKzHUIhY+ A+2gJ8M4tJvzbSyDHS3dKOAHB30W2ek/g+m20pnKK1Jz5HFb+uA9kBGjbKTHq84hTZcF+S9RDZG Vavz6Lt829hpmG/62RQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-26_04,2026-01-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 spamscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601260202 Currently enable_store() allows operations irrespective of the EUD state, which can result in redundant operations. Avoid this by adding duplicate state checks to skip requests when EUD is already in the desired state. Additionally, improve error handling with explicit logging to provide better feedback. Signed-off-by: Elson Serrao --- drivers/usb/misc/qcom_eud.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c index a58022f50484..0ea6491f963c 100644 --- a/drivers/usb/misc/qcom_eud.c +++ b/drivers/usb/misc/qcom_eud.c @@ -168,18 +168,27 @@ static ssize_t enable_store(struct device *dev, if (kstrtobool(buf, &enable)) return -EINVAL; + /* Skip operation if already in desired state */ + if (chip->enabled == enable) + return count; + if (enable) { ret = enable_eud(chip); - if (!ret) - chip->enabled = enable; - else - disable_eud(chip); - + if (ret) { + dev_err(chip->dev, "failed to enable eud\n"); + return ret; + } } else { ret = disable_eud(chip); + if (ret) { + dev_err(chip->dev, "failed to disable eud\n"); + return ret; + } } - return ret < 0 ? ret : count; + chip->enabled = enable; + + return count; } static DEVICE_ATTR_RW(enable); -- 2.34.1