From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3840C342518 for ; Tue, 27 Jan 2026 10:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769510418; cv=none; b=LAeFps9r1I7R1acxPMwBuMsFHs7dUELeOlQH95hl+lMNzFwLqIc6HdD74WP27jdHSYZcobryO1sIOtFss/eA3qwiMe71fiLZo/MXid3MqkIaMyOpMZ9Ik82SKeFIUZsvQB0X/lsvvBOtYxv19UHT0IWOeydmJ+6gxIf/7ZGE84A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769510418; c=relaxed/simple; bh=P9g5e/OuAoGiuTqQFV/COqX22+aRYbcTZ9ZxgA8VVto=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pAnjzRI6mcmqCpJ9vku6ZapHZIbvt/Ngv7lFHMdisBE6zH7qjq2xpll0d79IJrmdZZty4begg890ny8FhgqR1TeXNisc3p4kHeFc680FuScDOEnerfXcUWiUQKv/Pz644/xEUdnsdxIVrMaiaoZyFus8BX4iRCY8g6ezVWHGPaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ts8K3hqd; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ts8K3hqd" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-81e821c3d4eso5182814b3a.3 for ; Tue, 27 Jan 2026 02:40:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769510416; x=1770115216; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=a4iJWQpRhO1oWXfwOzDLew+HQSAfx5T/zlqt/osxBI4=; b=Ts8K3hqdaYDGgU15AFQgKXg79ULuhVhMMThlWVDPc5ft6vGrr7WzTDQ0EbXAvCdgJw 8h8XrFU9009WSns9Wuv68eX6YOpuhe4JoFqgWQKzJEwW8HFsv2IJ/xd+0x8y+T/mq2yW ZLBN2IOYF0zwHe9J3frrItf2ybOT7otk9Qq/dKDYerWo/c8sJ/44mbdnWObPAGu/1444 g5t/CfvJ2KTF93vDWmUrvbAWZ7YxeOAcy1mt2YEttROsr9IBYRF5+Bx3T/YPb1ICUoh3 OFzG0zHTU485PQGxKOArQ8EfQ0BqCZhjpp1/s6hrL+4w6pMy9prBMefbt0SA2tpXzyvU G6SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769510416; x=1770115216; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a4iJWQpRhO1oWXfwOzDLew+HQSAfx5T/zlqt/osxBI4=; b=C0X5D65JnyfJzruzMtAnEr7S/bT3DFFIhH5EoJUarl6sD6Jms9hURA6ps0eXF+T2Lu WtDxLD2haQOoxUkzfEc5yJIbKfgM/c1enVbntKoz7ocmvStWk7QAOvwQ0uRh/4v4rTgI hGEz3woU+Slhae2sLP8nPWUDb6Wgfa9ION6fNKJ2zmp8RnI0x3HO6nEPdqYsnJsRIkrn 0xk/0kUjTTyyr4IT1fgD3pPHel9nMLCc7rDsVshMOiystAaHhcKOxRlYBucTuMpPy4NY rvsDo+es3yikIYBDwH7XJZAPvSombS4mFgnSC2Hbwlk8dn6GPP0V2fatzPxUmdsUepvg ZaCA== X-Forwarded-Encrypted: i=1; AJvYcCWdvUP9RlGKwkqRCb8BbXrqPasAovFnqP/e4h0ZWGzKXJo5ajJZ6UJcsEdpqBfcUo3ov0MO47DvC6JCcvw=@vger.kernel.org X-Gm-Message-State: AOJu0YwW0MsGxTh/Muq9dpr3yG4K1z2BDSjcuJ9p+d/vgWtSqLKtHEaJ s763Eh3tyBE+3WOUbb8kwD6uFTuNQyN/VLx/F8GlmDiOqbnqh70pAJqjo6KG6g== X-Gm-Gg: AZuq6aL052IApvtaL8ZVj9adfxyDGNe/B93faEopYTJWeJXYrdeicZUMo18yJc85W68 Bw0TMbFmaY2hHdSJl82k6Iweg8oZSqevTgh43+nBgjg5Kn+0y36Rk4VBU+kYbTaSswGw3WUZGdB EZGiiTLbz/Ykmi1DFl0JsYdXZa/Y2Zd6PYW4MUC5wJNFvlUS2HkQhFn8b/UmSvL/yvKEmyFR8us vJJJu4jlAFcPZYk6q6rtJN5wnECPA6BcAQTv3bD1+WC65H/cB0gX16LM4C0LJVLGyZm3/RVE44/ YzvSBhHQH3YCA4sRDS1nfgzn9LpHvR3F0UC7ZUxTJRWD2Fb7SUo5r5AtIQrUyVdJ6AAvBwdHS4z TLBgrP0lPVErLFiUlvrdusEuIMQRjBdHFTECrxL43pNjO4cmdyRxepNe9Kq40E6Bbyz032xfyYs qkMDjl9jc093ZXzANNL73NuCTi2UQJ+Tkstxw+cA== X-Received: by 2002:a05:6a00:1f0f:b0:81f:4dc7:d39 with SMTP id d2e1a72fcca58-823692a3787mr1400668b3a.45.1769510416317; Tue, 27 Jan 2026 02:40:16 -0800 (PST) Received: from c12-ThinkPad-X1-Carbon-Gen-12 ([2400:2410:5f2b:700:38fe:3edc:7f99:7e99]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82339095c85sm7218907b3a.67.2026.01.27.02.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 02:40:15 -0800 (PST) From: Vishnu Sankar To: mpearson-lenovo@squebb.ca, dmitry.torokhov@gmail.com, hmh@hmh.eng.br, hansg@kernel.org, corbet@lwn.net, derekjohn.clark@gmail.com, ilpo.jarvinen@linux.intel.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, linux-doc@vger.kernel.org, platform-driver-x86@vger.kernel.org, vsankar@lenovo.com, Vishnu Sankar Subject: [PATCH v6 0/3] TrackPoint doubletap enablement and user control Date: Tue, 27 Jan 2026 19:39:04 +0900 Message-ID: <20260127103907.20269-1-vishnuocv@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series adds support for TrackPoint doubletap with a clear and simple separation of responsibilities between drivers: 1. Firmware enablement (trackpoint.c): Automatically enables doubletap on capable hardware during device detection. 2. User control (thinkpad_acpi.c): Provides a sysfs interface to enable or disable delivery of doubletap events to userspace. The approach follows the KISS principle: - The TrackPoint driver enables hardware functionality by default. - The thinkpad_acpi driver controls whether ACPI doubletap events are delivered, using existing hotkey filtering infrastructure. - No cross-driver APIs or dual filtering paths are introduced. Changes in v6: - Documentation: fix formatting of the doubletap_enable sysfs attribute description (separate "Values" list) Changes in v5: - Rename sysfs attribute from doubletap_filter to doubletap_enable to reflect actual behavior. - Fix inverted logic so events are delivered only when doubletap is enabled. - Suppress ACPI hotkey delivery instead of injecting or filtering input events. - Register the sysfs attribute via hotkey_attributes[] instead of device_create_file(). - Drop unnecessary helper wrappers and debug logging. - Update Documentation to reflect the new naming and semantics. Changes in v4: - Complete redesign based on reviewer feedback. - trackpoint.c: Simplified to only enable doubletap by default. - trackpoint.c: Removed all sysfs attributes and global variables. - trackpoint.c: Uses firmware ID detection with deny list. - thinkpad_acpi.c: Added sysfs interface for kernel-level event control. - thinkpad_acpi.c: No cross-driver dependencies. - Documentation: Updated to reflect simplified sysfs approach. Changes in v3: - No changes. Changes in v2: - Improved commit messages. - Removed unnecessary comments and debug messages. - Switched to strstarts() usage. - Simplified firmware capability detection logic. This version addresses the remaining review feedback by correcting the naming and logic inversion, aligning sysfs semantics with behavior, and fully integrating with existing thinkpad_acpi hotkey handling. Vishnu Sankar (3): input: trackpoint - Enable doubletap by default on capable devices platform/x86: thinkpad_acpi: Add sysfs control for TrackPoint double-tap Documentation: thinkpad-acpi - Document doubletap_enable attribute .../admin-guide/laptops/thinkpad-acpi.rst | 21 +++++++++ drivers/input/mouse/trackpoint.c | 47 +++++++++++++++++++ drivers/input/mouse/trackpoint.h | 5 ++ drivers/platform/x86/lenovo/thinkpad_acpi.c | 42 ++++++++++++++--- 4 files changed, 108 insertions(+), 7 deletions(-) -- 2.51.0