From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 196DC27FD4A for ; Tue, 27 Jan 2026 13:59:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769522366; cv=none; b=fjFDo9T4S+EsA7q6irwU2OGk+eMmH1cEqXy9Tw4ocGKzPbm5uUSWEHWETag73fUEFwNDauYlVLDm9UbRHdiSbrA1qSGaHpR/4mpoPFzxL/DbQ+71e/OQaSbD0m9fnUUZXsrSELde4a9eaYs3Qd6qe0D9FG5BbVVn9vdqWxZyUh4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769522366; c=relaxed/simple; bh=O1LOvbIWe6XftbcstULNkzFohU4YkiqNllkpI91xcAM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FkA87QS6QwdrsJ3wqo/OKkPp3PZOe4bOz6pNu21IoN3Usi5PlArXYICAn/E3/hUY5LCte3OQ2aF0JMHQ+5a+mOMBgB0USuunsrpqwIkzDiv9ywWsPvyUTS9VNxCLLAeHdSzayxxYXc5LsHS0q5X9TjGMaIrAyQdNwxpRJHSuDno= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=Trn8ouMb; arc=none smtp.client-ip=209.85.210.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="Trn8ouMb" Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-7d1890f7ee4so154283a34.0 for ; Tue, 27 Jan 2026 05:59:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1769522364; x=1770127164; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SgaSJG2JDBJWo7rSVGWXUpnG8BKa/5wc97GnXzAZusQ=; b=Trn8ouMbDlEaiSzTHvSfnHkBsi+q1DvzalJxCCk6Ul6kAS/dc5gj7fOp+K2L5rT9Sn plQ8mqOIEi4+vHvJU9YWwAFycFyV4p9Pt49uzx7jni3xyynV5zF69k1u8VsJ0N1H8vm9 IkdssthghC1T5x8hpV/uYRFT0XMJyOG6aZ1Yf5eFSKCsprkWlJJBNzLZfBxuO7F9f86s ApWSYew5rZXv2+X8ZN7oZFEKcSmqmnZSD5jWe10cTtzuiDLjkrZRRhROQobKA9xyG2w4 GtLxFuv4jUsgWbtkuZdNah1g+IIe2Pl2btRU4z0SIePPfgdKcNN3Uv/6IIzJO7+Ox/gy PEgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769522364; x=1770127164; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SgaSJG2JDBJWo7rSVGWXUpnG8BKa/5wc97GnXzAZusQ=; b=kyeNqvLZ6UeZ5vWHuOJYGeKlVqYBfF4qQF4O4fvC52lFJC2m/9ycwaQLW1nIMdG/YI gI8vvtJuVJUr3vVuAO2rmlXeuGf6lQAYKZ3NEnEQn4OmAL3NLxJNNYzTqz9Yn0eOeFIY WzgJ7RQbLge39yzLbLgpA96PkuGDE2RTmbgAXW5wsBb0RHh7zZfmwPXanVQjgSanHTX0 /Hjm/LY8ReJ2EwSrjCROEejBu048kvEcMKvxMSJkaRZ6PaKS0075VMK4456oXtfUILPf F9jAF5u+jIE/9j1V1qIO11BBAlvhIEyzui9sd8ymt1PYBimGErCyGNlzPngVsapbJ3Cw OrBA== X-Forwarded-Encrypted: i=1; AJvYcCXShsbViItWn0U6tD8BFAO1wj6+jFkeJrmssULbjJFWwmJshdqkYmerlavvJYjO688IXHA+xSGosKGUKoQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxAzthkGZtghQ4Ztx2C8CZrxAEPX7EkHRBObQh/tQGmIsngJ/rH amy9ytS2IRpnnOU0zy7UKyO7uIsr51poqDM9g23vILAhCLOl6EBa4QRyFGUAKgLzemQ= X-Gm-Gg: AZuq6aIPXeOMcxdxPPNkVHr1pA6GhjEi8w/NxM1Trk4ggIJxFyivAs/YerIE2x5huSe B1epejK4/7oJ0Q2zuDmDoOe44f/svA6AyAmEQY9HjuAN9ZMVnKwE527C7sxQ5nVM3KDJXep2Qlr urLjBAeiKr7k+ZvEmyKvuoMPL+Gx0XJv6jIZe7+OpBrDdLPLWtXO4f9690Ym/yOUw8zxCPioFVW b0PsecCdK26uwybv6Krh/LQZs5xwXkUpE5lBqiDOtvDYESLKEPM8LdJtuRcZH10/ejYTdCJtfE+ FWkzbWFUDxA9pFOikUjHCYt+XmGeqg/ckCiGUBlnCodbDWitTlC8qEVlNIL4TP9+eM0IEvExtX3 pBn/3rzZpACf/FiLz3HQym7nwJEi/1m2IBKx9e7mccD0s2WHUte+es+FGQ/Voz+6kcf8mLNlT/h 1cDbr5ZBkI4miBBwBPW3mim8/6z8gGf/mHjU0fnu6KehRQD+yxs3RWCBPFgDzXDXrnGQ== X-Received: by 2002:a05:6830:81eb:b0:7cf:d187:f278 with SMTP id 46e09a7af769-7d1850ca2dcmr1247675a34.17.1769522364059; Tue, 27 Jan 2026 05:59:24 -0800 (PST) Received: from localhost ([2001:470:b8f6:1b:a1a5:d807:e7a1:53eb]) by smtp.gmail.com with UTF8SMTPSA id 46e09a7af769-7d15b3d3340sm10034350a34.23.2026.01.27.05.59.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 05:59:23 -0800 (PST) From: Corey Minyard To: Breno Leitao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel-team@meta.com Subject: Date: Tue, 27 Jan 2026 07:54:38 -0600 Message-ID: <20260127135917.1597762-1-corey@minyard.net> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260127-ipmi-v1-0-ba5cc90f516f@debian.org> References: <20260127-ipmi-v1-0-ba5cc90f516f@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Fix a bug in error handling in the IPMI driver, reported by Breno Leitao. Also move the xmit_msgs_lock lock to a function and move the run to completion check there so the if check isn't on every one, making things hard to read. Passes the IPMI test suite. Adding a test for this would be very difficult, unfortunately. Thanks Breno and others who obviously worked on this. -corey