From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66FBA2E9ED8 for ; Tue, 27 Jan 2026 22:56:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769554612; cv=none; b=qcvjxJwOOmQnlcu2yNOsgQ3L+ViBXNQpQ/l6R2sLzzZm9phzHwrV5FgtidkRSfa+zyc7G9kyMZy0Kj0gb5omO6PcO3hUquQ6WM5es9fmXahKt6rGWQsNALLeqY2/n7Top99R/cuVw49j2ZhaeHUwHGRNyHzorTJCSMsCddP0GBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769554612; c=relaxed/simple; bh=6vaafjP0Uwb9/080lF02t8LDytLkowHMim8pDa81jso=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ML0RnKnf4OTrFd+fR+2nYJmBE9f9io61tOcLLjGvk/HBUGU3G2gWt1buE8QqS9pK2IMMiqemsfDtqYmBg0MAV4bvkBuDn/6NZAfFOWo43Dd0uSy04y1CL2uIwpHmcu+pFZuUghv8KIH7d8YIApeYVeZEYy8y4UUrUUBmO4nrtdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kqWEf1Ex; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kqWEf1Ex" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-432dee2b55fso761274f8f.1 for ; Tue, 27 Jan 2026 14:56:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769554607; x=1770159407; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YJj3rkrCWGO4XsqbS2RQcoD9sLDEl4QbuTlyvB/piF4=; b=kqWEf1ExfgqWjQwDLkioLUA2cNmyAZn38A+Gt3WYsSaxnL1qsLV18FlnfIvZXcjsaV E+Q4PbZDL9jd8BXSh0DF63GfOguP1TrvEgoP5Wm/E4GdTimzcg2c7fqTFa4fFdOu0u2p EK9NklqXrhrB2wQualKWSXHtFl0e8JKSoYq+oLzUcIAblqABypCAo0KsMy71aQhP/lzP A85lcVE6nPLFIl//qBBesYjIJV8WhQAe4O7T3esb36SbwhKZzZKpKmx5qQ0JZO1+FH8X SH1V7SSqWqu5JdEXkSNUs0b6seQawTT/CpkQFg7wzk5PYrzayTG8TeeFXXges4reBzMo gAww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769554607; x=1770159407; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YJj3rkrCWGO4XsqbS2RQcoD9sLDEl4QbuTlyvB/piF4=; b=qh3FWAv2HTMyS19qFVKatrecDp/qZ7cRA2gimMoB1qBkMXrNVdNI9DRCsUzsEViqeI qpJk2uYrhQ7D9acMwyNABgXlZ0oJKBhawij1rXYjk5FxSVQMiGCHxyOAs85mLEgTSGfq StvTxyaQ45XLKpHI6wIWiHMkCcDQadhPQRKKm1ZkQgMX8Ajo6kfQILP2iqBZq9H/6FJy ufzoiJBJF1ZWzA+/DqXiVXMdaqEb0XUscapmggS12SOMF0+xhie9Pd0wddab7QJsK8Wx 8LNKCMZsK6r6Bg5ceBDv9ZPBbJ/q8OwwbZZ6ax7L3kLOLUbMlMVde0v64ZfXUInTZMVs R31w== X-Forwarded-Encrypted: i=1; AJvYcCWQoG1zhjkKRKe9R2h5MRcAJcaJNQNaoDCKpr1v8kLi9yf4Tn9LNF6Bj0fUtXbNI9TOP/iqT1f3Ky7teXc=@vger.kernel.org X-Gm-Message-State: AOJu0YzzKAmIsehIUWLqUzdzYJlyH5XbrdWG85NfvEeHsMKDvYIryxus xhxj9WySpiXLqLNACsnR30qcluTY2rF9kBas97MqeEm8sGwTr63wK2Tq X-Gm-Gg: AZuq6aJp05M6boBjMl3rlvcQzQttPc30sK/uLvW1IsT/M1mlO3bv47jkUkE+Lymyv2j paxRRGSvYNhVn5l7A8xOk8BpvA9DYW/9lHkDXnh4xW88iSdWLf1/AUyD9lx6P82KS8lIIRiqacJ rDY86cg32+3TJLdB2FBbUi+hdv8+bCsSeMzhATvBThCvtmwQjsKEK4j5y1OGX1lY3bX4akyoBD6 yULBUMzRHYuNLCtIvZE90vcL70kjJpKbKBXpHg48I+rW7r275mbkVBBJiop1qM1b/wqn7aGzPpI HahuXXG/IR/zQ0k5iv+A+FFux+QaB8Mqvpp9sXv20RPUGsQqOctSKw7jGc9Fe1nh6RvTWuCxOxB S2gWpdDAOlZYfH4G0IPh8VJJ+npl4bk3NsLHni/F4EPSj6G/K2i7UUv0KRP+jxafCV0xVHIGSok IhOQ== X-Received: by 2002:a05:600c:3b19:b0:47d:3ffb:39ed with SMTP id 5b1f17b1804b1-4806e5a17b9mr2102095e9.4.1769554607085; Tue, 27 Jan 2026 14:56:47 -0800 (PST) Received: from skbuf ([2a02:2f04:d501:d900:6c51:3f46:e918:f0b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806cdebf86sm19928945e9.8.2026.01.27.14.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 14:56:46 -0800 (PST) Date: Wed, 28 Jan 2026 00:56:43 +0200 From: Vladimir Oltean To: Daniel Golle Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , Russell King , Simon Horman , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Wunderlich , Chad Monroe , Cezary Wilmanski , Avinash Jayaraman , Bing tao Xu , Liang Xu , Juraj Povazanec , "Fanni (Fang-Yi) Chan" , "Benny (Ying-Tsan) Weng" , "Livia M. Rosu" , John Crispin Subject: Re: [PATCH net-next v9 0/4] net: dsa: initial support for MaxLinear MxL862xx switches Message-ID: <20260127225643.qe4lpeyjmtl6flc4@skbuf> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 27, 2026 at 09:37:40PM +0000, Daniel Golle wrote: > This series adds very basic DSA support for the MaxLinear MxL86252 > (5 PHY ports) and MxL86282 (8 PHY ports) switches. > > MxL862xx integrates a firmware running on an embedded processor (running > Zephyr RTOS). Host interaction uses a simple netlink-like API transported > over MDIO/MMD. > > This series includes only what's needed to pass traffic between user > ports and the CPU port: relayed MDIO to internal PHYs, basic port > enable/disable, and CPU-port special tagging. > Follow up series will bring bridge, VLAN, ... offloading, I'm surprised the Kconfig help text says: These switches have two 10GE SerDes interfaces, one typically used as CPU port. yet only PHY_INTERFACE_MODE_INTERNAL is set in phylink supported_interfaces. You're also not making any mention of future SerDes support. What's up with that, how do the SerDes ports currently work and how are they described? (as internal?!) > and support for using a 802.1Q-based special tag instead of the > proprietary 8-byte tag. Why is that? Another (related) question. You have this comment in tag_mxl862xx.c: /* switch firmware expects ports to be counted starting from 1 */ from which I don't completely understand how is the firmware involved (does it process the tags?). Would the expectation also apply to the 802.1Q based tagger? What's the real story behind port index 0? Does it really not exist, or is it some attempt to hide an internal port that's not supposed to be used? If the latter, I guess something like the snippet below (seen in arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dts) would simplify the driver by a bit: ethernet-switch@0 { ... ethernet-ports { ... /* Microcontroller port */ port@0 { reg = <0>; status = "disabled"; };