From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CF471E1DFC for ; Tue, 27 Jan 2026 14:56:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769525775; cv=none; b=aC0Oo/JV3WQXF1TQT1quOijgaXEUmxoeSdrEzMWsNOkWfxRwpm/cKtMWvHP2VEjJLSpux/XGfw7OUoczwFlyqmeINTNvxaFIImaWnlfFRVbW2NYf8A6jdUa5sYEi5lzAaZEPwD1dERAkSyoCOAcSgWba8Bo701CrIXGqMyh0Fvw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769525775; c=relaxed/simple; bh=oe6GLkZRubK79QrsXWLTFmDTkpUsXJTRLUbgP+ZUqvs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FuvbH5hPM48dVX3/4P+z113y1svaM/Pugu2WSHW/5mjCfEK3M4zbIeo4mZfz+dLNhBzxTM9oxYLFWn/WLYwJJ9BJrkTol5kVM1ZX1q7qshTLKlKKF8j+EStyVZvB4y/bOfUEjQawbhr3t1yD+hK/CT2b3z/EupVQyNWU0ZZk5z8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nEVBPBaB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nEVBPBaB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28DC2C116C6; Tue, 27 Jan 2026 14:56:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1769525774; bh=oe6GLkZRubK79QrsXWLTFmDTkpUsXJTRLUbgP+ZUqvs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nEVBPBaBsncW6QMq8w5uD3iHFlwUoxLoRtvbpOuYPgr9Kg7/YfMxrn56wESSChSNg VVtfhHABM2LBzghFeMPY7zbBoNOZutQ+dsiOus2bJ/KM74kN5Q/OOAuXxgsTla43DP c+JVR0oAG+I9fjtJyaaTXj/k9M8OztsiBgX7oDs8= Date: Tue, 27 Jan 2026 15:56:11 +0100 From: Greg KH To: Henry Zhang Cc: speakup@linux-speakup.org, w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, linux-kernel@vger.kernel.org, Henry Zhang Subject: Re: [PATCH] speakup: Clarify bleep_time unit is milliseconds Message-ID: <2026012757-disparate-corset-6f48@gregkh> References: <20260126201707.1297665-1-zeri@umich.edu> <2026012759-disown-breath-fdd3@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2026012759-disown-breath-fdd3@gregkh> On Tue, Jan 27, 2026 at 03:55:07PM +0100, Greg KH wrote: > On Mon, Jan 26, 2026 at 03:17:07PM -0500, Henry Zhang wrote: > > The documentation had a TODO questioning whether the unit was in > > jiffies. The implementation in drivers/accessibility/speakup/main.c > > passes spk_bleep_time to msecs_to_jiffies(), confirming the unit is > > in milliseconds. > > > > Signed-off-by: Henry Zhang > > Does not match your From: line :( Which my scripts did not seem to object to, so nevermind :)