From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECC1627FB35 for ; Wed, 28 Jan 2026 03:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769572464; cv=none; b=R7MhIcWNOGw+BdJleB474Q/M31hnAnWi2Vpjfj+KBs7szcFCxCBGrh4NBXB44pJuCnrajZ6AuGMujWZSRgAAW81tmpbLLDwMbN2+D+XUd6s8M5o4i/4nkD91YVbgRhroTu7L7YtsF2CCt9G8SWVGabLc/39MduS47HlRxk3SEZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769572464; c=relaxed/simple; bh=lYwlvxqUpgGX7wOKbaU7gsIl4YwMPQONs1o2KRorJ+0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CBvlxBmp1DgzgZJkDH3hl8d53Wca6TyMgpzm1hR80WoFcVDFmjZoHMmGXuE1p2zd0wAD7N9xrKO1DbSXNM7WQSEzlmiACZYf3MuMZA79MWwfmHZhtlRtVUmb0LMj3DBJ4sBbk6j4kOVKZI5pDrCXkcnVVsBQKOgX7+7RBCq7Kt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=LU3xi9JT; arc=none smtp.client-ip=115.124.30.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="LU3xi9JT" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1769572454; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=Ys/bT7Q8nc4Iwjya0jTbe2+fND7tobnZr6Lk8bNOB9M=; b=LU3xi9JTTFWVqX2yU1/avFOOKSb2IVcD5tUiNoRq/HrrIJhzkeqPghoPVS4H5Kq6c/RC/Zg+n7wzifve6KQGIpoRbhbPxz1w45tPD6sNMGHUmssL7MubrSNvQTWvRyG53/VZTeGlOfNt4V6ysLP4Yuzm1VYqGU+OXwnzYZ+CGXE= Received: from x31i01179.sqa.na131.tbsite.net(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Wy20I4Y_1769572449 cluster:ay36) by smtp.aliyun-inc.com; Wed, 28 Jan 2026 11:54:13 +0800 From: Gao Xiang To: linux-erofs@lists.ozlabs.org Cc: LKML , Gao Xiang Subject: [PATCH] erofs: mark inodes without acls in erofs_read_inode() Date: Wed, 28 Jan 2026 11:54:08 +0800 Message-ID: <20260128035408.2172802-1-hsiangkao@linux.alibaba.com> X-Mailer: git-send-email 2.43.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Similar to commit 91ef18b567da ("ext4: mark inodes without acls in __ext4_iget()"), the ACL state won't be read when the file owner performs a lookup, and the RCU fast path for lookups won't work because the ACL state remains unknown. If there are no extended attributes, or if the xattr filter indicates that no ACL xattr is present, call cache_no_acl() directly. Signed-off-by: Gao Xiang --- fs/erofs/inode.c | 5 +++++ fs/erofs/xattr.c | 20 ++++++++++++++++++++ fs/erofs/xattr.h | 1 + 3 files changed, 26 insertions(+) diff --git a/fs/erofs/inode.c b/fs/erofs/inode.c index bce98c845a18..2e02d4b466ce 100644 --- a/fs/erofs/inode.c +++ b/fs/erofs/inode.c @@ -137,6 +137,11 @@ static int erofs_read_inode(struct inode *inode) err = -EFSCORRUPTED; goto err_out; } + + if (IS_ENABLED(CONFIG_EROFS_FS_POSIX_ACL) && + erofs_inode_has_noacl(inode, ptr, ofs)) + cache_no_acl(inode); + switch (inode->i_mode & S_IFMT) { case S_IFDIR: vi->dot_omitted = (ifmt >> EROFS_I_DOT_OMITTED_BIT) & 1; diff --git a/fs/erofs/xattr.c b/fs/erofs/xattr.c index 512b998bdfff..14d22adc1476 100644 --- a/fs/erofs/xattr.c +++ b/fs/erofs/xattr.c @@ -574,4 +574,24 @@ struct posix_acl *erofs_get_acl(struct inode *inode, int type, bool rcu) kfree(value); return acl; } + +bool erofs_inode_has_noacl(struct inode *inode, void *kaddr, unsigned int ofs) +{ + static const unsigned int bitmask = + BIT(21) | /* system.posix_acl_default */ + BIT(30); /* system.posix_acl_access */ + struct erofs_sb_info *sbi = EROFS_I_SB(inode); + const struct erofs_xattr_ibody_header *ih = kaddr + ofs; + + if (EROFS_I(inode)->xattr_isize < sizeof(*ih)) + return true; + + if (erofs_sb_has_xattr_filter(sbi) && !sbi->xattr_filter_reserved && + !check_add_overflow(ofs, sizeof(*ih), &ofs) && + ofs <= i_blocksize(inode)) { + if ((ih->h_name_filter & bitmask) == bitmask) + return true; + } + return false; +} #endif diff --git a/fs/erofs/xattr.h b/fs/erofs/xattr.h index 36f2667afc2d..a3ceefa1554d 100644 --- a/fs/erofs/xattr.h +++ b/fs/erofs/xattr.h @@ -30,4 +30,5 @@ struct posix_acl *erofs_get_acl(struct inode *inode, int type, bool rcu); #define erofs_get_acl (NULL) #endif +bool erofs_inode_has_noacl(struct inode *inode, void *kaddr, unsigned int ofs); #endif -- 2.43.5