From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDED21D5CC9
	for <linux-kernel@vger.kernel.org>; Wed, 28 Jan 2026 19:19:30 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1769627970; cv=none; b=KbXfXLbFmsbCfYSyvOXWkLRas8o5WqIDlZ5E5p64dUjkI714K/CP6JOPYF3LTaGQMTbA0qwZ/MaXvJzO074Yd3QnMM4oCU7hLL9qg+Md2hODshsedy7ib9/eBUcR6GE9tBNuxHvzs2c6Vm9R00c8taGlyCMTtHbyZnkKYB1w2l0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1769627970; c=relaxed/simple;
	bh=fnVrY/VJt1XOxXtUPFuhYIKdfkyVGkWAoedb2W8TjOI=;
	h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References:
	 Mime-Version:Content-Type; b=LcDcftgr5szbFYwxTmhD2z+BTPNSNfg1nQLVMFS947gG5hPfdjxDSdv+VKDObV1Fj+yWXXKNjmnaG4J5zCbT+Cjy0q4PI7pzcgjC8eBcADa9gw6MQOV/EHDlbNV2xrL183yx0R3anssOOhAX3aRNe1ZCuchZoFf+0EKIIGNLbno=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=TZjPbYgw; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="TZjPbYgw"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E379FC4CEF1;
	Wed, 28 Jan 2026 19:19:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
	s=korg; t=1769627970;
	bh=fnVrY/VJt1XOxXtUPFuhYIKdfkyVGkWAoedb2W8TjOI=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=TZjPbYgw8N/uC8YyD5VB2MGQnv5UPJAeHl2j+dVsVFgPzn5gKHCBwhRGA1ouhPIZM
	 Y6QHFbt3W0tu2LBc0xTlis3eEPXl9JsJ3cPvVZWFSfpbkwrHflIpTfHdFOBFaw3aIW
	 4jwroAj9qmlrnaiGPQ5aN2GYteZUnvayFkLMkuY0=
Date: Wed, 28 Jan 2026 11:19:29 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Baoquan He <bhe@redhat.com>
Cc: Li Chen <me@linux.beauty>, Mimi Zohar <zohar@linux.ibm.com>, Tushar
 Sugandhi <tusharsu@linux.microsoft.com>, Eric Biggers
 <ebiggers@kernel.org>, Alexander Graf <graf@amazon.com>, Steven Chen
 <chenste@linux.microsoft.com>, Coiby Xu <coxu@redhat.com>, Sourabh Jain
 <sourabhjain@linux.ibm.com>, Philipp Rudo <prudo@redhat.com>, Ricardo
 Ribalda <ribalda@chromium.org>, "Steven Rostedt (Google)"
 <rostedt@goodmis.org>, Ross Zwisler <zwisler@google.com>,
 kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kexec: derive purgatory entry from symbol
Message-Id: <20260128111929.73a13cc2d51ef113a586993e@linux-foundation.org>
In-Reply-To: <aXnWMmyUMdbrqAiu@MiWiFi-R3L-srv>
References: <20260128043511.316860-1-me@linux.beauty>
	<aXnWMmyUMdbrqAiu@MiWiFi-R3L-srv>
X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 28 Jan 2026 17:26:10 +0800 Baoquan He <bhe@redhat.com> wrote:

> On 01/28/26 at 12:35pm, Li Chen wrote:
> > kexec_load_purgatory() derives image->start by locating e_entry inside an
> > SHF_EXECINSTR section. If the purgatory object contains multiple executable
> > sections with overlapping sh_addr, the entrypoint check can match more than
> > once and trigger a WARN.
> > 
> > Derive the entry section from the purgatory_start symbol when present and
> > compute image->start from its final placement. Keep the existing e_entry
> > fallback for purgatories that do not expose the symbol.
> > 
> > WARNING: kernel/kexec_file.c:1009 at kexec_load_purgatory+0x395/0x3c0, CPU#10: kexec/1784
> > Call Trace:
> >  <TASK>
> >  bzImage64_load+0x133/0xa00
> >  __do_sys_kexec_file_load+0x2b3/0x5c0
> >  do_syscall_64+0x81/0x610
> >  entry_SYSCALL_64_after_hwframe+0x76/0x7e
> > 
> > Fixes: 8652d44f466a ("kexec: support purgatories with .text.hot sections")
> > Signed-off-by: Li Chen <me@linux.beauty>
> 
> LGTM,
> 
> Acked-by: Baoquan He <bhe@redhat.com>

Thanks.

> By the way, a warning need be 'Fixes' tag and back ported to stable
> kernel?

Yup.  I added the cc:stable.