From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3A9924CEEA for ; Wed, 28 Jan 2026 22:48:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769640535; cv=none; b=LJ60otcK3ItM8rXQgg7V0++unD/qRco3ZdZghgmTGPOPGKFXO0yvZIgIn+N/rjz7aRVzs9YGAAcxDMUe+QRhb4hw4wPsnOrDBE7zOIHRDgWJjdYrDYetZQ6OcprbN+nV+gk4Yw0rSC3Zi+CbMHbjF79D94r822Jo9aHOci5mZfI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769640535; c=relaxed/simple; bh=9lde7Ivrwg7Fj7JNiDH/ELhD3pjs8jGXKfeRyrJfImk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oeemH+SY+maDhwNjBQVaP4Avw/Fyjmx6JHcZpRBI9Z4PNPCUF9JbDjXDzkcVn9MwAW/i9a/CoT04lqYQZWwzxkwJvmSWT46JX4BQe67D6HCFEGmgAUkueM7RYibtAebd7haW69SYRlBd7zWPqTP7hxDHiBlkbGWZkrn785JyrxQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fBP4FP0U; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fBP4FP0U" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769640533; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZSit5hT7x15zRkxpWSCotyN0t1cBlE4U/MDOqNefmRs=; b=fBP4FP0UkIatUmdNXAYZm7NokRPMWa7Lmu9cZ6/uR/pC1Vmi9NBG+TB5skf+WAWNpLyWZt mndVw4AMAvvlOQbJCV9aYJ4IXNfgszYdH19EJ3vi/ZDcZkkmgH5CIjB0jPyeQYCkDuQlfp tyDpiKlpWOKSkdMsupAgiFvZNHkfAmM= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-Glz2ISrdM32urSl3tdKprQ-1; Wed, 28 Jan 2026 17:48:49 -0500 X-MC-Unique: Glz2ISrdM32urSl3tdKprQ-1 X-Mimecast-MFC-AGG-ID: Glz2ISrdM32urSl3tdKprQ_1769640528 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4235D18005AD; Wed, 28 Jan 2026 22:48:48 +0000 (UTC) Received: from pauld.westford.csb (unknown [10.22.89.161]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B8D2530001A2; Wed, 28 Jan 2026 22:48:45 +0000 (UTC) Date: Wed, 28 Jan 2026 17:48:43 -0500 From: Phil Auld To: linux-kernel@vger.kernel.org Cc: linux-tip-commits@vger.kernel.org, Gabriele Monaco , "Peter Zijlstra (Intel)" , x86@kernel.org Subject: Re: [tip: sched/core] sched: Fix build for modules using set_tsk_need_resched() Message-ID: <20260128224843.GA185446@pauld.westford.csb> References: <20260112140413.362202-1-gmonaco@redhat.com> <176851345987.510.6507406232761244840.tip-bot2@tip-bot2> <20260115233803.GD1039042@pauld.westford.csb> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260115233803.GD1039042@pauld.westford.csb> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Hi Peter and Gabriele, On Thu, Jan 15, 2026 at 06:38:03PM -0500 Phil Auld wrote: > On Thu, Jan 15, 2026 at 09:44:19PM -0000 tip-bot2 for Gabriele Monaco wrote: > > The following commit has been merged into the sched/core branch of tip: > > > > Commit-ID: 8d737320166bd145af70a3133a9964b00ca81cba > > Gitweb: https://git.kernel.org/tip/8d737320166bd145af70a3133a9964b00ca81cba > > Author: Gabriele Monaco > > AuthorDate: Mon, 12 Jan 2026 15:04:13 +01:00 > > Committer: Peter Zijlstra > > CommitterDate: Thu, 15 Jan 2026 22:41:26 +01:00 > > > > Thank you for both of these, Peter! Well, I think this one and the related one need to lose the _GPL because they are called from things, like wake_up_process(), which are exported without that restriction. This essentially adds _GPL to that and anything else that ends up in resched_curr(). I prefer to add new symbols _GPL too but this case seems different. Thoughts? I can spin up a patch against tip:sched/core if you want it. Cheers, Phil > > > sched: Fix build for modules using set_tsk_need_resched() > > > > Commit adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model") > > added a tracepoint to the need_resched action that can be triggered also > > by set_tsk_need_resched. > > This function was previously accessible from out-of-tree modules but > > it's no longer available because the __trace_set_need_resched() symbol > > is not exported (together with the tracepoint itself, which was exported > > in a separate patch) and building such modules fails. > > > > Export __trace_set_need_resched to modules to fix those build issues. > > > > Fixes: adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model") > > Signed-off-by: Gabriele Monaco > > Signed-off-by: Peter Zijlstra (Intel) > > Reviewed-by: Phil Auld > > Link: https://patch.msgid.link/20260112140413.362202-1-gmonaco@redhat.com > > --- > > kernel/sched/core.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index b033f97..3cca012 100644 > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -1139,6 +1139,7 @@ void __trace_set_need_resched(struct task_struct *curr, int tif) > > { > > trace_sched_set_need_resched_tp(curr, smp_processor_id(), tif); > > } > > +EXPORT_SYMBOL_GPL(__trace_set_need_resched); > > > > void resched_curr(struct rq *rq) > > { > > > > -- > --