mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Cosmin-Gabriel Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"magnus.damm" <magnus.damm@gmail.com>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: spi: renesas,rzv2h-rspi: allow multiple DMAs
Date: Thu, 29 Jan 2026 18:03:37 +0000	[thread overview]
Message-ID: <20260129-crispness-fit-4b573b563070@spud> (raw)
In-Reply-To: <TYRPR01MB156199346D508EFE1F0F94349859EA@TYRPR01MB15619.jpnprd01.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 2035 bytes --]

On Thu, Jan 29, 2026 at 05:55:21PM +0000, Cosmin-Gabriel Tanislav wrote:
> > From: Conor Dooley <conor@kernel.org>
> > Sent: Thursday, January 29, 2026 7:45 PM
> > 
> > On Wed, Jan 28, 2026 at 11:51:30PM +0200, Cosmin Tanislav wrote:
> > > All supported SoCs have multiple DMA controllers that can be used with
> > > the RSPI peripheral. The current bindings only allow a single pair of RX
> > > and TX DMAs.
> > >
> > > The DMA core allows specifying multiple DMAs with the same name, and it
> > > will pick the first available one.
> > >
> > > There is an exception in the base dt-schema rules specifically for
> > > allowing this behavior (dtschema/schemas/dma/dma.yaml).
> > >
> > > dma-names:
> > >   anyOf:
> > >     - uniqueItems: true
> > >     - items:
> > >         # Hack around Renesas bindings which repeat entries to support
> > >         # multiple possible DMA providers
> > >         enum: [rx, tx]
> > >
> > > Allow multiple DMAs to have the same name and only restrict the possible
> > > names of the DMA channels, not their count.
> > >
> > > For RZ/T2H and RZ/N2H SoCs, limit the number of DMA channels to 6, as
> > > they have 3 DMA controllers.
> > 
> > What's the rationale behind not setting minItems to 6 here
> > 
> > >
> > > For RZ/V2H and RZ/V2N SoCs, limit the number of DMA channels to 10, as
> > > they have 5 DMA controllers.
> > 
> > and to 10 here? Do any of the spi controllers on these SoCs not have the
> > ability to use all of the available dma controllers?
> > 
> 
> I left minItems to 2 in case it is necessary to wire up SPI to only a
> subset of the DMA controllers, maybe for performance reasons in a
> board-specific dts?
> 
> I know that dts is only supposed to describe the hardware itself, but for
> now this would be the only way to pre-select which DMA controller is used
> for a specific IP.
> 
> Let me know your thoughts.

Yeah, I can buy that argument.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-01-29 18:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28 21:51 [PATCH v3 0/3] Add DMA support for RZ/T2H RSPI Cosmin Tanislav
2026-01-28 21:51 ` [PATCH v3 1/3] dt-bindings: spi: renesas,rzv2h-rspi: allow multiple DMAs Cosmin Tanislav
2026-01-29 17:44   ` Conor Dooley
2026-01-29 17:55     ` Cosmin-Gabriel Tanislav
2026-01-29 18:03       ` Conor Dooley [this message]
2026-02-18  7:49   ` Krzysztof Kozlowski
2026-03-18 16:14   ` Geert Uytterhoeven
2026-01-28 21:51 ` [PATCH v3 2/3] arm64: dts: renesas: r9a09g077: wire up DMA support for SPI Cosmin Tanislav
2026-02-27 14:54   ` Geert Uytterhoeven
2026-01-28 21:51 ` [PATCH v3 3/3] arm64: dts: renesas: r9a09g087: " Cosmin Tanislav
2026-02-27 14:55   ` Geert Uytterhoeven
2026-02-25 19:07 ` (subset) [PATCH v3 0/3] Add DMA support for RZ/T2H RSPI Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260129-crispness-fit-4b573b563070@spud \
    --to=conor@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cosmin-gabriel.tanislav.xa@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®