From: Shenghui Shi <ssh.mediatek@gmail.com>
To: Frank.Li@nxp.com, vkoul@kernel.org
Cc: manivannan.sadhasivam@linaro.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, Shenghui Shi <brody.shi@m2semi.com>
Subject: [PATCH v2] dmaengine: dw-edma: fix MSI data programming for multi-IRQ case
Date: Thu, 29 Jan 2026 10:20:24 +0800 [thread overview]
Message-ID: <20260129022024.3995-1-brody.shi@m2semi.com> (raw)
When using MSI (not MSI-X) with multiple IRQs, the MSI data value
must be unique per vector to ensure correct interrupt delivery.
Currently, the driver fails to increment the MSI data per vector,
causing interrupts to be misrouted.
Fix this by caching the base MSI data and adjusting each vector's
data accordingly during IRQ setup.
This issue was reproduced and tested on:
- Device: [20e0:2502] (rev 01)
- Kernel: 6.8.0-90-generic
Fixes: e63d79d1ff04 ("dmaengine: dw-edma: Add Synopsys DesignWare eDMA IP core driver")
Signed-off-by: Shenghui Shi <brody.shi@m2semi.com>
---
drivers/dma/dw-edma/dw-edma-core.c | 25 +++++++++++++++++++++++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c
index 8e5f7defa..516770388 100644
--- a/drivers/dma/dw-edma/dw-edma-core.c
+++ b/drivers/dma/dw-edma/dw-edma-core.c
@@ -844,11 +844,15 @@ static int dw_edma_irq_request(struct dw_edma *dw,
{
struct dw_edma_chip *chip = dw->chip;
struct device *dev = dw->chip->dev;
+ struct msi_desc *msi_desc;
u32 wr_mask = 1;
u32 rd_mask = 1;
int i, err = 0;
u32 ch_cnt;
int irq;
+ u16 msi_base_data = 0;
+ bool msi_base_valid = false;
+ bool is_msix = false;
ch_cnt = dw->wr_ch_cnt + dw->rd_ch_cnt;
@@ -869,8 +873,15 @@ static int dw_edma_irq_request(struct dw_edma *dw,
return err;
}
- if (irq_get_msi_desc(irq))
+ if (irq_get_msi_desc(irq)) {
get_cached_msi_msg(irq, &dw->irq[0].msi);
+ msi_desc = irq_get_msi_desc(irq);
+ is_msix = msi_desc && msi_desc->pci.msi_attrib.is_msix;
+ if (!is_msix) {
+ msi_base_data = dw->irq[0].msi.data;
+ msi_base_valid = true;
+ }
+ }
dw->nr_irqs = 1;
} else {
@@ -896,8 +907,18 @@ static int dw_edma_irq_request(struct dw_edma *dw,
if (err)
goto err_irq_free;
- if (irq_get_msi_desc(irq))
+ if (irq_get_msi_desc(irq)) {
get_cached_msi_msg(irq, &dw->irq[i].msi);
+ msi_desc = irq_get_msi_desc(irq);
+ is_msix = msi_desc && msi_desc->pci.msi_attrib.is_msix;
+ if (!is_msix) {
+ if (!msi_base_valid) {
+ msi_base_data = dw->irq[i].msi.data;
+ msi_base_valid = true;
+ }
+ dw->irq[i].msi.data = (u16)(msi_base_data + i);
+ }
+ }
}
dw->nr_irqs = i;
--
2.49.0.windows.1
next reply other threads:[~2026-01-29 2:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 2:20 Shenghui Shi [this message]
2026-01-29 3:30 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129022024.3995-1-brody.shi@m2semi.com \
--to=ssh.mediatek@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=brody.shi@m2semi.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®