From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f65.google.com (mail-oa1-f65.google.com [209.85.160.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EAC337E303 for ; Thu, 29 Jan 2026 07:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769671909; cv=none; b=VzSlbLwYl1JD2d2VnE3Ql2KE8VHtDNuouED1rCylmNCus23jDGKBH+bjILdpEgYp8HcakyyH3DVuMRsXjliKxJ7xfOBfKB/ebgU+C48fpxUAfKtblCDCcYyQB/5aMxH5CUAqTL1LVFUJsipi3Bydc+/WcaINn4Si5M1ESi01J9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769671909; c=relaxed/simple; bh=oPoNMSRIYjoVgxOqsTJZZH37SevBPXkc7c0ZXJJFMTo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D+M5ij3IRLysZuzXkmHSKXnNFX2IayzBtYfq04m+mKnSw8TOosYIR7evxpmmF1FqOKm/x+gk7/Owkf82zlIohcx1f7k7lAwe1PrKX3hIwKkhwDTyZpkTBnydJcjuacwNAW19IKciJ+PaWaU4GzF2gLetXZZLwUEgDoy2r8GfCEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VTox9qvL; arc=none smtp.client-ip=209.85.160.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VTox9qvL" Received: by mail-oa1-f65.google.com with SMTP id 586e51a60fabf-4095b6f9c5aso407528fac.0 for ; Wed, 28 Jan 2026 23:31:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769671906; x=1770276706; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3xsJvAGVi9OUktE+8fXjWdBdWnD5PdumECdhR7oEDHI=; b=VTox9qvLvadJjLobuQbx4VbYxm742NT+f6mQhEjWdVS11/ai/HSaT5k91utkGPZlmD Nbk71CtYVR+Z2FIsCWYgIPHpEkx42AXrjarKOqwT+4KYKTAjs8n/5eAd0PplA33LzHnF wzDmrZT/3M/93fG3UyS3kKdDitPIhQJzUnJaTtcgvheverwRqRDu55rZLJIAgQwmv7FE x675QTazncJrliL0Kbt5gv12MoAArAW1ztcve56zlyeL+g75dXLGiG0+tAS1cO/O4G5N t42rTWjE+SWegjtJ08NUBmWu4z9wMuLFfN+AgLraD1rJVXjXJpNuTlC8PmhGLTCBAdLr 9HXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769671906; x=1770276706; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3xsJvAGVi9OUktE+8fXjWdBdWnD5PdumECdhR7oEDHI=; b=blJYmlM32w7lw6U6aQnPrlpto5g6U+aBT2YQuTlRR5LtAkd04kga+QTplL1Dw0nOLN zA0jFRmNj8b04jB3EjcgPpLPPl8rsU87CDVTsWqszPlOc/mJo7wuTLeagZ+x5dgjhEDG wwAuiUpXGNHM9PzPh2zNRElEVPtTzBrAK6/U+quOe6D/Qsu5ZTuS8N0GOmqZeyE4L2JJ Eyq2sIqRt9MbTkKfIquq4yjUXupGNopW0TikURkIRgVqgl1H2BbSP68skDERIglKy54G 21RTTLUCk0uW6/VdNw692LkwMwuJGSueHSsplquUbJRxk0u0ReNcyyXIosrQmKqpYMBw EPQA== X-Forwarded-Encrypted: i=1; AJvYcCXHlw3Xgje4rYXHCViXNVae9YB0JmE17CeiHO2fnu9TIq3XNZiY26dDloGx9EWOMhkfCdxr1fE9R2q0tN8=@vger.kernel.org X-Gm-Message-State: AOJu0YwnT0vDbhgdsxpr2GXfy/7Mf+Chy6II/z9jkb9fEpKDxxx9m66x CHQDEXBheoS8EecY6QZ5ryrS4IR5QbbmW2WyKnTe1wWJKhz5Ndfy30Wx X-Gm-Gg: AZuq6aJrnHOVBjiLmPvySSYhAxBs9SKj5XZ9HTtW73mwH1lFHPWppcgFCHFL/DOnZx5 k9d/IfeTLHa6lr1Tnyjr1325lXn+v7S2TNEiwQ46gF1hdW3OGdLa1CY8AZD+1OA9/n5uRNTws7P ajbEicZeljGaWMRWsdlT0GvSbBi7ZeE0he4xyD7L4zisZh2Kv5+3xmNce0k87rAHztYYUh8bESl H0riJXwAMLOrPaeoQS2fGeyDmNz8/x3e5xQ7XvoADMP0yGtfbo0NsbA5fnjubKHR61rSFYh4ARa buaWO5VIuMruWfuWLSAJG/lUBH9hwH2ZA1jpxa0EiK0irfUkNq+5d1rUJD5bsotD1+zDM3+woB6 Dy+oop5qUjxh+yRcV0/opQ1fpTiazDw3qzcgi0/LNkvD6V+Df5ajW69/c4B3mlqJv52KKDpPFH3 xaUxD284ie6wNQRJfCu9F/TWxCBTeQFvn6Q4Z7duOfzvC5OVtikMM= X-Received: by 2002:a05:6820:1f07:b0:659:9a49:8f6b with SMTP id 006d021491bc7-662f20b02camr4543783eaf.48.1769671906381; Wed, 28 Jan 2026 23:31:46 -0800 (PST) Received: from godzilla (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 006d021491bc7-662f982703fsm2843961eaf.0.2026.01.28.23.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 23:31:45 -0800 (PST) From: Jim Cromie To: gregkh@linuxfoundation.org Cc: Jim Cromie , Jason Baron , =?UTF-8?q?=C5=81ukasz=20Bartosik?= , Louis Chauvet , Bagas Sanjaya , Dave Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, Petr Mladek , Shuah Khan , linux-doc@vger.kernel.org, Jonathan Corbet , Ye Bin , Andrew Morton , linux-kernel@vger.kernel.org Subject: [PATCH v9 32/32] docs/dyndbg: add classmap info to howto Date: Thu, 29 Jan 2026 00:29:18 -0700 Message-ID: <20260129072932.2190803-33-jim.cromie@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129072932.2190803-1-jim.cromie@gmail.com> References: <20260129072932.2190803-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Describe the 3 API macros providing dynamic_debug's classmaps DYNAMIC_DEBUG_CLASSMAP_DEFINE - create & export a classmap DYNAMIC_DEBUG_CLASSMAP_USE - refer to exported map DYNAMIC_DEBUG_CLASSMAP_PARAM - bind control param to the classmap DYNAMIC_DEBUG_CLASSMAP_PARAM_REF + use module's storage - __drm_debug NB: The _DEFINE & _USE model makes the user dependent on the definer, just like EXPORT_SYMBOL(__drm_debug) already does. cc: linux-doc@vger.kernel.org Signed-off-by: Jim Cromie --- .../admin-guide/dynamic-debug-howto.rst | 132 ++++++++++++++++-- 1 file changed, 122 insertions(+), 10 deletions(-) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst index 0a42b9de55ac..734be0b5fe9a 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -146,6 +146,9 @@ keywords are:: "1-30" is valid range but "1 - 30" is not. +Keywords +-------- + The meanings of each keyword are: func @@ -194,16 +197,6 @@ format format "nfsd: SETATTR" // a neater way to match a format with whitespace format 'nfsd: SETATTR' // yet another way to match a format with whitespace -class - The given class_name is validated against each module, which may - have declared a list of known class_names. If the class_name is - found for a module, callsite & class matching and adjustment - proceeds. Examples:: - - class DRM_UT_KMS # a DRM.debug category - class JUNK # silent non-match - // class TLD_* # NOTICE: no wildcard in class names - line The given line number or range of line numbers is compared against the line number of each ``pr_debug()`` callsite. A single @@ -218,6 +211,25 @@ line line -1605 // the 1605 lines from line 1 to line 1605 line 1600- // all lines from line 1600 to the end of the file +class + + The given class_name is validated against each module, which may + have declared a list of class_names it accepts. If the class_name + accepted by a module, callsite & class matching and adjustment + proceeds. Examples:: + + class DRM_UT_KMS # a drm.debug category + class JUNK # silent non-match + // class TLD_* # NOTICE: no wildcard in class names + +.. note:: + + Unlike other keywords, classes are "name-to-change", not + "omitting-constraint-allows-change". See Dynamic Debug Classmaps + +Flags +----- + The flags specification comprises a change operation followed by one or more flag characters. The change operation is one of the characters:: @@ -239,6 +251,11 @@ The flags are:: l Include line number d Include call trace +.. note:: + + * To query without changing ``+_`` or ``-_``. + * To clear all flags ``=_`` or ``-fslmpt``. + For ``print_hex_dump_debug()`` and ``print_hex_dump_bytes()``, only the ``p`` flag has meaning, other flags are ignored. @@ -395,3 +412,98 @@ just a shortcut for ``print_hex_dump(KERN_DEBUG)``. For ``print_hex_dump_debug()``/``print_hex_dump_bytes()``, format string is its ``prefix_str`` argument, if it is constant string; or ``hexdump`` in case ``prefix_str`` is built dynamically. + +.. _dyndbg-classmaps: + +Dynamic Debug Classmaps +======================= + +The "class" keyword selects prdbgs based on author supplied, +domain-oriented names. This complements the nested-scope keywords: +module, file, function, line. + +The main difference from the others: classes must be named to be +changed. This protects them from unintended overwrite:: + + # IOW this cannot undo any drm.debug settings + :#> ddcmd -p + +This protection is needed; /sys/module/drm/parameters/debug is ABI. +drm.debug is authoritative when dyndbg is not used, dyndbg-under-DRM +is an implementation detail, and must not behave erratically, just +because another admin fed >control something unrelated. + +So each class must be enabled individually (no wildcards):: + + :#> ddcmd class DRM_UT_CORE +p + :#> ddcmd class DRM_UT_KMS +p + # or more selectively + :#> ddcmd class DRM_UT_CORE module drm +p + +That makes direct >control wordy and annoying, but it is a secondary +interface; it is not intended to replace the ABI, just slide in +underneath and reimplement the guaranteed behavior. So DRM would keep +using the convenient way, and be able to trust it:: + + :#> echo 0x1ff > /sys/module/drm/parameters/debug + +That said, since the sysfs/kparam is the ABI, if the author omits the +CLASSMAP_PARAM, theres no ABI to guard, and he probably wants a less +pedantic >control interface. In this case, protection is dropped. + +Dynamic Debug Classmap API +========================== + +DYNAMIC_DEBUG_CLASSMAP_DEFINE(clname,type,_base,classnames) - this maps +classnames (a list of strings) onto class-ids consecutively, starting +at _base. + +DYNAMIC_DEBUG_CLASSMAP_USE(clname) & _USE_(clname,_base) - modules +call this to refer to the var _DEFINEd elsewhere (and exported). + +DYNAMIC_DEBUG_CLASSMAP_PARAM(clname) - creates the sysfs/kparam, +maps/exposes bits 0..N as class-names. + +Classmaps are opt-in: modules invoke _DEFINE or _USE to authorize +dyndbg to update those named classes. "class FOO" queries are +validated against the classes defined or used by the module, this +finds the classid to alter; classes are not directly selectable by +their classid. + +Classnames are global in scope, so subsystems (module-groups) should +prepend a subsystem name; unqualified names like "CORE" are discouraged. + +NB: It is an inherent API limitation (due to class_id's int type) that +the following are possible: + + // these errors should be caught in review + __pr_debug_cls(0, "fake DRM_UT_CORE msg"); // this works + __pr_debug_cls(62, "un-known classid msg"); // this compiles, does nothing + +There are 2 types of classmaps: + +* DD_CLASS_TYPE_DISJOINT_BITS: classes are independent, like drm.debug +* DD_CLASS_TYPE_LEVEL_NUM: classes are relative, ordered (V3 > V2) + +DYNAMIC_DEBUG_CLASSMAP_PARAM - modelled after module_param_cb, it +refers to a DEFINEd classmap, and associates it to the param's +data-store. This state is then applied to DEFINEr and USEr modules +when they're modprobed. + +The PARAM interface also enforces the DD_CLASS_TYPE_LEVEL_NUM relation +amongst the contained classnames; all classes are independent in the +control parser itself. There is no implied meaning in names like "V4" +or "PL_ERROR" vs "PL_WARNING". + +Modules or subsystems (drm & drivers) can define multiple classmaps, +as long as they (all the classmaps) share the limited 0..62 +per-module-group _class_id range, without overlap. + +If a module encounters a conflict between 2 classmaps it is _USEing or +_DEFINEing, it can invoke the extended _USE_(name,_base) macro to +de-conflict the respective ranges. + +``#define DEBUG`` will enable all pr_debugs in scope, including any +class'd ones. This won't be reflected in the PARAM readback value, +but the class'd pr_debug callsites can be forced off by toggling the +classmap-kparam all-on then all-off. -- 2.52.0