From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA41D37A4AA for ; Thu, 29 Jan 2026 07:30:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769671813; cv=none; b=iRJvSDZPfkazduxmvIlYaF7Xcpp/NzZDGSw7coWe8D4d7wKTmEvpe+n4RdLh4CICpCFI/IX/mV8aOLsVavxz5SbrsI1yMJDdpAeE1MXJY0f+1chtnDqNbTCNIgqb5uMb4RswdroJm4j9BSVOvRM2w3+jLq+KSAARDFHOpixSXlA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769671813; c=relaxed/simple; bh=FmkY4SatpzjGfLIPpd6Gpluj/xLWyAKYAcW7/q3R5Ss=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e7nIqIjtZ1pOCBmIaKqWdRUrKxp/ExPpwXaAmhCoaXDrUMqw7QSS/wx+KAHxhZSbTkX2gUdO3LdccCxAGMkgLjkvRfEmmKQrUPSqcp6PXrRRnuf2StzFHhgut8UYsbzARK+dKH0QRBDw/xWrHWFSncVa939s90YQZkWy2SQoSmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GI4zLzLf; arc=none smtp.client-ip=209.85.167.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GI4zLzLf" Received: by mail-oi1-f173.google.com with SMTP id 5614622812f47-45c8b850f96so466724b6e.0 for ; Wed, 28 Jan 2026 23:30:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769671811; x=1770276611; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Dw9yO7mwTQnQ0r65U4QsCYOKxY/82LUhk+hkyZXe+sY=; b=GI4zLzLfLg9wQW/XRusozPfvZ1DFwfS0ZwVVQwbFdYFPRrNUG94RUMUfvsOX7pL3xw HQmaN1eV/z4I1RUBj453fbAA2Po4JyAABEVELH+L83g3NoPVKvHDghGIODYL8O21UzN6 WVz/qd1m6ShFxx1xSCilz8a2q4CHYF1WMf4JYJn0Ym1IJRHFNpEzrO0G9I5BG6/NzOMn ZJIuf8ixePm7Aa9GIFDsniLXdRUahebYhTZ0xeXQ44d5gFlADbn2ECi3eUfyIi9o9pU+ jbIkZBrLQJeKK8dA0r3PRiuskwoT7xY6cuxxmel/Z4PBfhi5KEoOgpB8eZRUyWWHNN1a IZtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769671811; x=1770276611; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Dw9yO7mwTQnQ0r65U4QsCYOKxY/82LUhk+hkyZXe+sY=; b=PBajMk4lDf1vcta1BxzwMvmVBgkXurk6mD3ZC908CqVqECGFOClrO8+HE2I6aiAR9s VWpnz6Ff0JV8jbtv6wqxbT57heZUWhX0rOX2c5I/1tdYvwm32YRwsUGVIVBVlCSfnYW5 05IpD8aVmMAJ94jX9md1NTgyPaeuV4thK+678iZKnAQWcVHlraH178DtgyB892ttMXRO UbEeDzhdqfiEn8GlSJE8ooQc9n1DsIAcPhnAUhTgSpa+OkzUhwA7CNxFa/1UjJb/tUBI HqIZJWgjxvOcd5/j3Di7H8cTK43FjTu0qxngCjU13N55XjG7ZTYnLcTKH67pavozTbiU 2YpQ== X-Forwarded-Encrypted: i=1; AJvYcCXS6nAl0U3Am3UwJHRRIfSguny5TU1rf/q0W+/EOIjmZ+uAPmUwnnpr/5WJ2BlmooFDD3iLgz1IMHGUTvQ=@vger.kernel.org X-Gm-Message-State: AOJu0YynNyTbCEf64nnIJ5+Cu1pmsja27DDvLxIrdsNOmVOJdElI+q1q U3RjRDQlKJlPULlPAVFek+xmNg5mm+MjryxcPQzenzbCBKpR7Gacooe+ X-Gm-Gg: AZuq6aKVUnW9iBES8apiaGLHp10usrpsGjJGpznezIH0n6dcYWRoQx5D/SL+/xnw+P+ cTBbCnMz8iZBiVS/7TBmE+VRiBdyO9DEC23LNgoqpkm36tdG0QbVu/yX8xOtaZkebh7ot9Qb3Z/ VY7lLi3650H6zoiAqTbRfrrvYRjHnHaGxMo0oNzSQX7x9M7NJpGEZ0rR2myA6/i4GCCmgJO4qCQ Gfy+J1x7jpC33Nn23fv0GpF7q8Waik13+G5oyndpRutgaf9HWiewdwHSIPp/4bCvh2cIsARSOyJ R1qYmZZpQxiihegnN45OyXYW4aMMGhGU6plgjktW8Kn3ELxE0RXgDTTUsAFMuw8HwuYqG59G97+ a4DkVT4TepdXyjEA33/iPrKDvCIpXLi3PxIYJMtQ+S1rE+GR7HVkr71J1Fz6dY1OvmJHICexXpZ u0rWLUpG666lkM+rF4dzJw/2vx8zFIs03lwqt+qRhOtNgctgYQXOA= X-Received: by 2002:a05:6808:18a9:b0:44d:bf83:d7f8 with SMTP id 5614622812f47-45efc4d5962mr4032674b6e.4.1769671810881; Wed, 28 Jan 2026 23:30:10 -0800 (PST) Received: from godzilla (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 5614622812f47-45f08f5ff30sm2718275b6e.16.2026.01.28.23.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 23:30:10 -0800 (PST) From: Jim Cromie To: gregkh@linuxfoundation.org Cc: Jim Cromie , Jason Baron , =?UTF-8?q?=C5=81ukasz=20Bartosik?= , Louis Chauvet , Bagas Sanjaya , Dave Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, Petr Mladek , Shuah Khan , linux-doc@vger.kernel.org, Jonathan Corbet , Ye Bin , Andrew Morton , linux-kernel@vger.kernel.org Subject: [PATCH v9 05/32] docs/dyndbg: explain flags parse 1st Date: Thu, 29 Jan 2026 00:28:51 -0700 Message-ID: <20260129072932.2190803-6-jim.cromie@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129072932.2190803-1-jim.cromie@gmail.com> References: <20260129072932.2190803-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When writing queries to >control, flags are parsed 1st, since they are the only required field, and they require specific compositions. So if the flags draw an error (on those specifics), then keyword errors aren't reported. This can be mildly confusing/annoying, so explain it instead. cc: linux-doc@vger.kernel.org Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- .../admin-guide/dynamic-debug-howto.rst | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst index 4b14d9fd0300..9c2f096ed1d8 100644 --- a/Documentation/admin-guide/dynamic-debug-howto.rst +++ b/Documentation/admin-guide/dynamic-debug-howto.rst @@ -109,10 +109,19 @@ The match-spec's select *prdbgs* from the catalog, upon which to apply the flags-spec, all constraints are ANDed together. An absent keyword is the same as keyword "*". - -A match specification is a keyword, which selects the attribute of -the callsite to be compared, and a value to compare against. Possible -keywords are::: +Note that since the match-spec can be empty, the flags are checked 1st, +then the pairs of keyword and value. Flag errs will hide keyword errs:: + + bash-5.2# ddcmd mod bar +foo + dyndbg: read 13 bytes from userspace + dyndbg: query 0: "mod bar +foo" mod:* + dyndbg: unknown flag 'o' + dyndbg: flags parse failed + dyndbg: processed 1 queries, with 0 matches, 1 errs + +So a match-spec is a keyword, which selects the attribute of the +callsite to be compared, and a value to compare against. Possible +keywords are:: match-spec ::= 'func' string | 'file' string | -- 2.52.0