From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD8762EAB71 for ; Thu, 29 Jan 2026 09:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769677586; cv=none; b=cXvzAqquMIWNVeaDAU6J++/MuhQvIRo6CqVOkc5Zsk5AjhOp33LkZvq2eYe4cqPR7WBso+FOe/vkmN8mjyylxUE+0XvwTWXJDh5JqV8PBXHtlgsegT/KBclhU/8h96lMS8b7YFJtE/sMtSQ4npBh+lP7kzb4WeqgAOqnNyj1LiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769677586; c=relaxed/simple; bh=R6dVrUcNBbpLQt3Rtteu0UsbahuTBhGADTZQ8hJ0c5k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ak8xzA75dI2Zua6PLP4GYpzlPE5mYZXLS5QMjOWbu1axdMqvGTYhQwvpKL5+TkAK0cl1xsm8lZkYV26kIhHwXIcYi0YGb3S26zEDeA8XTslOiHlbw2/yiGbVR0OZKwkA4optV/imLS/I/OAxq2tk1xqx/sx2jlLBByYmJl+YiYo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zacbowling.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hlcd3tHI; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zacbowling.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hlcd3tHI" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-2b73112ab62so805583eec.1 for ; Thu, 29 Jan 2026 01:06:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769677584; x=1770282384; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=DytMJO0WqVXchRW5Tcsc01QJ5SYiHM6gt4jb9e/3TBI=; b=hlcd3tHIRAwQRbR3pZY9gS+lqZlxkP+pAvtkXwAWPp8gO8D/Kzt5nqG8QVmhCyT83t r3KGl7rrXJG2DmbLN3LrYSLjffBq71NLmFy7Sz2arukaCq1MgUxgv99VZTNx1p8XxdF3 07ymXdo9N0f8OFjnzhwU5iZO4zzLIH2oJpIPBCFTckkkPpBzJKFoJNiZCBsgWGT3ofqr 7VWi/Afo27UMBXmBK9ngbQAHH418iiQ6qMbwfyj/iMIl8etoyNwt+89ZXONPkyHmsdJL QfKxDPHxsVX33p+Zn9PPQcReryCmHSPdWE4Zg28ObQdTf9Bw/EHIkiHqUr+syMLLRsNW ddNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769677584; x=1770282384; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DytMJO0WqVXchRW5Tcsc01QJ5SYiHM6gt4jb9e/3TBI=; b=psdVnkun3sDud9IIiYpBbvgf45q/oPH08b0pQK6aV+zY9axqcHji+1o1QNMoMCTb62 +ArsghEdJAs1fIeTD/eB/48H1ziNVNnb3uU53zyGXC6cAZjY6TbUkH9h1uwnfVj2IFmT hh1YvwrACedIJIeGjsQCiZNp1C9H6NRDgaUjBao4g+DQFwLbi81/GD2Ct1zsu+qoA+Z/ Vxq7gzSHZwETNPeK5SezJwkmGQuigOvC8n58TzDDPrP+J4xHsaymJgVOjRDUnM3I3X6o uAbDIXuyaLfu9CSnKDqj8rXqXbqOz2ZRtIea/vMbdqHCFdqoHBsWprXxnr96x+oLyMPc azzQ== X-Forwarded-Encrypted: i=1; AJvYcCWUySEozfrBVWRfmeiEyLAfVpATTUo1JL+p1vpf2woKPeX34lDXwKk/NgQKolgovsREsXSrK77JV2hL7o0=@vger.kernel.org X-Gm-Message-State: AOJu0YyyHoSimOVPrjMyoIq9K6AU2tdHCB37aZItAffSv6PwTr3hdyEq WBsHXZrx2JPnZmSTtoMc4woHRk7XgafqaIWXAr3VnT4q7Gmna8OM1nCN X-Gm-Gg: AZuq6aI8yJMxnOBJ4WiMZS0o9cvs+lKPUf1ZF6SAM4T0l4nqTxyL0nCf/IumUAV1SVa 3oHYhbPnisPqGnM1YUkSoTnwIHKOPD9whWkI57X2rAez/3qe8C8ux+TZbfmBsRD2A+WgNyiKzm2 1IsVdy5Gv0a68NWy84FVTYSFQNHSYkfNNS+IxN4z0BnI9hklSy4OBp099Mikt+zKQR0HwFWVSJ1 OBgDMTyu+N9TUPxfcFfsplVYCK5btYCK2Y6aAQhyfdiKwT8cAbM03xwo8KsGZBiPxhIOi1ggrOt L8eLz6X8aJdcGGh6FUnrXyIFLn7pk6IBZZ2LM2AtOCW/dOgnNXf77ADbIfrYOnoY2xp2Ty7o/zY zuu1uHN3mtSEyB38pUAOn5SJMJx/rv9PPfvmJFi67LP9b2K9QiZKzNi1nOslWO5X5L5tWfAAZgT 2WDJ9xsMjcmGCoCAL03oHGV4bH1/AEvWCMjrJ+nviY+mdARP5a5xj6JJYSA2r6/Q== X-Received: by 2002:a05:693c:310e:b0:2b7:2551:502f with SMTP id 5a478bee46e88-2b78da5a1b0mr4292742eec.35.1769677583860; Thu, 29 Jan 2026 01:06:23 -0800 (PST) Received: from zcache.home.zacbowling.com ([2001:5a8:60d:bc9:4a3c:9f7c:8037:90c1]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b7a1abe714sm6050559eec.20.2026.01.29.01.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 01:06:23 -0800 (PST) Sender: Zac Bowling From: Zac To: zac@zacbowling.com Cc: deren.wu@mediatek.com, kvalo@kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-wireless@vger.kernel.org, linux@frame.work, lorenzo@kernel.org, nbd@nbd.name, ryder.lee@mediatek.com, sean.wang@kernel.org, sean.wang@mediatek.com, zbowling@gmail.com Subject: [v7 PATCH 7/7] wifi: mt76: mt7925: add error logging for MLO ROC setup in set_links Date: Thu, 29 Jan 2026 01:05:22 -0800 Message-ID: <20260129090520.192374-3-zac@zacbowling.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260129084611.187744-1-zac@zacbowling.com> References: <20260129084611.187744-1-zac@zacbowling.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add error logging in mt7925_mac_set_links() when mt7925_set_mlo_roc() fails. Previously the error return was silently ignored since the callback function is void. The function now logs non-ENOLINK errors as warnings. ENOLINK errors are expected during link transitions when the link configuration is not yet ready, and mac80211 will retry the operation later. This complements the error handling changes in mt7925_mcu_set_mlo_roc() where WARN_ON_ONCE was replaced with proper -ENOLINK returns. Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt7925 device") Signed-off-by: Zac Bowling --- drivers/net/wireless/mediatek/mt76/mt7925/main.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/main.c b/drivers/net/wireless/mediatek/mt76/mt7925/main.c index 0b088c448151..769c09e99d48 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/main.c @@ -1048,11 +1048,16 @@ mt7925_mac_set_links(struct mt76_dev *mdev, struct ieee80211_vif *vif) if (band == NL80211_BAND_2GHZ || (band == NL80211_BAND_5GHZ && secondary_band == NL80211_BAND_6GHZ)) { + int ret; + mt7925_abort_roc(mvif->phy, &mvif->bss_conf); mt792x_mutex_acquire(dev); - mt7925_set_mlo_roc(mvif->phy, &mvif->bss_conf, sel_links); + ret = mt7925_set_mlo_roc(mvif->phy, &mvif->bss_conf, sel_links); + if (ret && ret != -ENOLINK) + dev_warn(dev->mt76.dev, + "MLO ROC setup failed in set_links: %d\n", ret); mt792x_mutex_release(dev); } -- 2.52.0