From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7C5A33CE83 for ; Thu, 29 Jan 2026 10:16:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769681786; cv=none; b=eDcILqfVgJwP81RqB8GBo8kVPHzMcv4SbqxqAwJbSAAw3DcLtfq42gVw2x2p3ky9Rd+P3r0T8hnNcdNCEgUoJTmNeElzZ3L495cJjNs9nHGNwRoZOPHVCztuB2aSO7kbtXC1sjP4NdQ/7esXTa09wUkVcrRLoIVjO+9rhZvxCxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769681786; c=relaxed/simple; bh=J/SoU3MkP2MY74o7Q2lAtkpaITboiBABKZxNYr/6I5g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZWF8eyaQwvqKuoJzn338fUFfijRfBeB3hBfErCUKQulxEhxie7emjVZLoYvKcdC9xfy0p9+vkX3ic1WqdD1Rg0LBV7wHPSHlOH9BEBnMXvOSZxAQ7HD3jXIXR4pK5wl9uvXvO2+jX+1E5UpcA0EuO0TIvyfJPmvmljWGP3mJHLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fn1LsHnT; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fn1LsHnT" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4806fbc6bf3so8216075e9.2 for ; Thu, 29 Jan 2026 02:16:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769681783; x=1770286583; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=scwnG4+Nck1/cLGODsLX+wXP9q98UaUDMSFVIL+kckU=; b=Fn1LsHnTZZuhO9s7j0iy8OLAOxLuTxc4NaiAm8OWogllw+3qIdTsjIrrLkumJZbYQP uc10GKVQX042Q1nfopJ6X9cSZcBnejfFHwB8RIMfhpoasVq/AuhiHbyT7313Dm7d+mCl yKh/OaIlCahvOQXlhSXCqlqBfnQ0s7nioVwho/6zDIScwqqLx784TtCgbsmJZRBwjUeL 0o0oXosFizz4ZI/ArNkSyG+c1PSBQLdX5LL4SsjsO9RZbj1S6lbbWw5F4cx9V1+WHg53 7nbZWohnXrE2Eic2UAozRFm8dcYA6xG69ScnwGNrquj4kzIHCNNCFq/Zuh8i8GOWZlqA ajig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769681783; x=1770286583; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=scwnG4+Nck1/cLGODsLX+wXP9q98UaUDMSFVIL+kckU=; b=lSWzt7sWAOPibolbhmh3vhsnn0PG6ptWdstGdEfbF5/3SRETZEcQYSwDa1FxNmnL4c bOnGCR8FIWZ2LYCC/75mILzwtstN+ypXokgkYheDJx9O5pW+Gs8pI3R7Xs74/aSmWsne vUTfxL3Hd744ePXuwrX3/ZF3j/A03gAC+LM+gSJ8EmAE7HUa85JmftzHMGjIGCbMyXn6 XSEb3FQC6Yj8IXtFCQBYpaD680IB8oM7Q+by9ws2hZmeAmB+pn4En0VbiZpQZEdDy5Bd tAxrVcOhgOmlOm91mk+RquaU8KatDwB/ZB+tpF3nWNLre4HNkSyJEtlZRQXVa8MhbgqC 12mg== X-Forwarded-Encrypted: i=1; AJvYcCWiEdtKPrwwuCzs3ZnqK34MsDnEoKiSHZaU2+4rQHMYNkJJOoSUmqUkWOg8jnCAk3GRaayS3LaciSGtqcU=@vger.kernel.org X-Gm-Message-State: AOJu0YxhinB76DjlHG5iGcwKqY5iKpkd76FEcGHjOz64ozpr6PqIzy2J WJ5mNkgU2kH5KtY8+7u+fNxZu1waQOHw/L4OsKb7B9xQIn+epNHAgpw5 X-Gm-Gg: AZuq6aJR7q0RYTlJcZZwUugV+YPSLvsA1sUk0ppJ46AMS6EBYfH+LoaZkFBgvcJk9Vt zTDEZ/VuZsT8ZI0w03TJlOMi8RDzGxTmNWYdJOzb7UKcB6uiB7FNWVCx0JtmaJoVzdpDmCU59A5 cxXFaWJ0bJr4cWp+JYp8cXLaehSuV98txlVH1m4C2Y3GJudDibnqAYAkjt3dVI5sMdRlPz7w3n1 0N9MCF5DT8PV3KC0bucBHHckQwDv2jNXA4qigjIyDrsYlEqKhL3KO6yOKOhZ1zFurUb3Vap1hBd sKH65Px8KFOB/agbAKLQIKEOHFX7YiIzBVYpZzVriI8dbS/sYWE9Qbjrdq6MBPSQzIzrt6LclgY wR7IookPrxaPVOG24VpDc6bmD9KOwgC88bQkGxPjSDNrzPxNaXAOQ0/T7163YI4gmBOAK4w0aMM RQMMNCWLCMzFM= X-Received: by 2002:a05:600c:8b84:b0:47e:e78a:c832 with SMTP id 5b1f17b1804b1-48069c82494mr90663755e9.37.1769681783205; Thu, 29 Jan 2026 02:16:23 -0800 (PST) Received: from nas.local ([2001:912:1ac0:1e00:c662:37ff:fe09:93df]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e132303fsm13413662f8f.36.2026.01.29.02.16.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 02:16:22 -0800 (PST) From: Damien Dejean To: andrew@lunn.ch, krzk+dt@kernel.org, robh@kernel.org, kuba@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, davem@davemloft.net, pabeni@redhat.com, hkallweit1@gmail.com, Damien Dejean Subject: [PATCH v4 4/4] net: phy: realtek: add RTL8224 polarity support Date: Thu, 29 Jan 2026 11:16:06 +0100 Message-ID: <20260129101606.33972-4-dam.dejean@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260129101606.33972-1-dam.dejean@gmail.com> References: <20260129101606.33972-1-dam.dejean@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The RTL8224 has a register to configure the polarity of every pair of each port. It provides device designers more flexbility when wiring the chip. Unfortunately, the register is left in an unknown state after a reset. Thus on devices where the bootloader don't initialize it, the driver has to do it to detect and use a link. The MDI polarity swap can be set in the device tree using the property enet-phy-lane-polarity. The u32 value is a bitfield where bit[0..3] control the polarity of pairs A..D. Signed-off-by: Damien Dejean --- drivers/net/phy/realtek/realtek_main.c | 39 +++++++++++++++++++++++++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realtek/realtek_main.c index 79c2762b610e..8013ba453f05 100644 --- a/drivers/net/phy/realtek/realtek_main.c +++ b/drivers/net/phy/realtek/realtek_main.c @@ -172,6 +172,7 @@ #define RTL8224_SRAM_RTCT_LEN(pair) (0x8028 + (pair) * 4) #define RTL8224_VND1_MDI_PAIR_SWAP 0xa90 +#define RTL8224_VND1_MDI_POLARITY_SWAP 0xa94 #define RTL8366RB_POWER_SAVE 0x15 #define RTL8366RB_POWER_SAVE_ON BIT(12) @@ -1855,9 +1856,45 @@ static int rtl8224_mdi_config_order(struct phy_device *phydev) RTL8224_VND1_MDI_PAIR_SWAP, val); } +static int rtl8224_mdi_config_polarity(struct phy_device *phydev) +{ + struct device_node *np = phydev->mdio.dev.of_node; + u8 port_offset = phydev->mdio.addr & 3; + u32 polarity = 0; + int ret, val; + + ret = of_property_read_u32(np, "enet-phy-lane-polarity", &polarity); + + /* Do nothing if the property is not present */ + if (ret == -EINVAL) + return 0; + + if (ret) + return ret; + + if (polarity & ~0xf) + return -EINVAL; + + val = __phy_package_read_mmd(phydev, 0, MDIO_MMD_VEND1, + RTL8224_VND1_MDI_POLARITY_SWAP); + if (val < 0) + return val; + + val &= ~(0xf << port_offset); + val |= polarity << port_offset; + return __phy_package_write_mmd(phydev, 0, MDIO_MMD_VEND1, + RTL8224_VND1_MDI_POLARITY_SWAP, val); +} + static int rtl8224_config_init(struct phy_device *phydev) { - return rtl8224_mdi_config_order(phydev); + int ret; + + ret = rtl8224_mdi_config_order(phydev); + if (ret) + return ret; + + return rtl8224_mdi_config_polarity(phydev); } static int rtl8224_probe(struct phy_device *phydev) -- 2.47.3