mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Williamson <alex@shazbot.org>
To: David Matlack <dmatlack@google.com>
Cc: Randy Dunlap <rdunlap@infradead.org>, Ted Logan <tedlogan@fb.com>,
	Shuah Khan <shuah@kernel.org>,
	Raghavendra Rao Ananta <rananta@google.com>,
	Alex Mastro <amastro@fb.com>,
	kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] vfio: selftests: fix format conversion compiler warning
Date: Thu, 29 Jan 2026 11:50:39 -0700	[thread overview]
Message-ID: <20260129115039.10fe3c76@shazbot.org> (raw)
In-Reply-To: <CALzav=cWEoydGBpf4j5gPWy0TzLoAPP3YeG3VocbeEzytHTFrw@mail.gmail.com>

On Wed, 28 Jan 2026 11:21:52 -0800
David Matlack <dmatlack@google.com> wrote:

> On Wed, Jan 28, 2026 at 11:12 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> > On 1/28/26 11:06 AM, David Matlack wrote:  
> > > On Wed, Jan 28, 2026 at 10:38 AM Ted Logan <tedlogan@fb.com> wrote:  
> > >>
> > >> Use the standard format conversion macro PRIx64 to generate the
> > >> appropriate format conversion for 64-bit integers. Fixes a compiler
> > >> warning with -Wformat on i386.
> > >>
> > >> Signed-off-by: Ted Logan <tedlogan@fb.com>
> > >> Reported-by: kernel test robot <lkp@intel.com>
> > >> Closes: https://lore.kernel.org/oe-kbuild-all/202601211830.aBEjmEFD-lkp@intel.com/  
> > >
> > > Thanks for the patch.
> > >
> > > I've been seeing these i386 reports as well. I find the PRIx64, etc.
> > > format specifiers make format strings very hard to read. And I think
> > > there were some other issues when building VFIO selftests with i386
> > > the last time I tried.
> > >
> > > I was thinking instead we should just not support i386 builds of VFIO
> > > selftests. But I hadn't gotten around to figuring out the right
> > > Makefile magic to make that happen.  
> >
> > There are other 32-bit CPUs besides i386.
> > Or do only support X86?  
> 
> At this point I would only call x86_64 and arm64 as supported. At
> least that is all I have access to and tested.
> 
> If there is legitimate desire to run these tests on 32-bit CPUs, then
> we can support it.
> 
> Alex, do you test on 32-bit CPUs?

No, I haven't tested 32-bit in a very long time.  I'd like to think it
works, but I'm not aware of any worthwhile use case.  Thanks,

Alex

  reply	other threads:[~2026-01-29 18:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28 18:37 Ted Logan
2026-01-28 19:06 ` David Matlack
2026-01-28 19:12   ` Randy Dunlap
2026-01-28 19:21     ` David Matlack
2026-01-29 18:50       ` Alex Williamson [this message]
2026-01-29 22:57         ` David Matlack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260129115039.10fe3c76@shazbot.org \
    --to=alex@shazbot.org \
    --cc=amastro@fb.com \
    --cc=dmatlack@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=rananta@google.com \
    --cc=rdunlap@infradead.org \
    --cc=shuah@kernel.org \
    --cc=tedlogan@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®