From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C56051DE2A5 for ; Thu, 29 Jan 2026 13:19:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769692779; cv=none; b=hL522rbWP3hbiO+bYdThexg0Jn8cRsWqdGxpgTnBBDmqg+D9vdkHtA2e8tSkFz/agqaZW+wgeOLqFSvE5/GkZ+ssnHuZJYhiCJhRlUmDgw5Hr9J8SppulASmkPYWQYTz/0Q4IVFr0GThu9N8VJnQkqa/1AFhtUa8Kszk+xqGgNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769692779; c=relaxed/simple; bh=Rt7oqf4nLVnHhwzd4aacoigz4YCbsGX4tp95FrniHnI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R42qlPfAESql0tA6NeBmsJZiQxmhF8KdP9L/PzUNYsA6ogfGwEyylXvV1NSms8pJJT5kUNwOZTX8kh/v9nbtVBExHjAfnz8ROZdViZH9Y/xvHArarJs+OewD1xChvW/aEQWSgyFE8CFIZsPdFW0R5nqfkP3HKDvQl4l7K3uCzoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=BhzkmNLG; arc=none smtp.client-ip=209.85.208.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="BhzkmNLG" Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-6582e8831aeso1633772a12.1 for ; Thu, 29 Jan 2026 05:19:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1769692776; x=1770297576; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oQZC8UCrEj4+vjvd4YboeC/yI3stsoKr6nmv+kw+WfY=; b=BhzkmNLGflSdbwicltqUk6uxakZmj4rsPDaLu1+Bfozc5RaCUC0Pjp3P/78nlQiow3 sV5NupYPsoYYFqq3A8nTEV8M/u7g4sCSxU5O02wTPG8VINiNKb5dcQY1SkKQjSzGF9f1 pfOaiQwEP7XlUYl7SuRIgtvD5jKXVWSa5p4D8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769692776; x=1770297576; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oQZC8UCrEj4+vjvd4YboeC/yI3stsoKr6nmv+kw+WfY=; b=UHJgE4nMpHC73+4Y1Sps1ZQDYhB7FnzQ4/EX4nAYUorx5sYgESDAX0KMigBs9AZtz0 H/iyGvj9iWzSmlnJwdlxJCjAl7fTiTLbzJCEUGqgs/5h2A331SYI+1bX7wq45eAYXiwR 8aXDN0yr4xMmKerLTwxYXOefj2O1ifxyPDf68O4yjv2d0KyK5WyHnUM3UHskoIwtFmx9 5ZlAFx0wmbiWpUu/R+WMbx40HtwqRy8kbyUT9VljJIWbxPC4okYNrfDOvVmty3wnVduj 7SBHdLwXl9HN+toUO7xWGsi87CEQ+JOuoMVN5mZKHVg2rjha8SO6tcMRWqAAZyb8JJw7 xSjA== X-Forwarded-Encrypted: i=1; AJvYcCWo9xZltpbt9S6Bcn0lE7Q5bcKBKAtYGlxjgaSQYPkYych3k3ELiwpGgHpBIQQfbdjvUlkyrfu/oRgwNQw=@vger.kernel.org X-Gm-Message-State: AOJu0YwtAbRlyPVYkHR5s1qrWtajgXMIuBSHMf7n8JAvbPhNT5w6Qa8R 6XqSEQiFZl9p/l+O15G71+sM/dfTuT1Mz2LGdKrY8DKHCucaB3GB4UvtJHpgjMgbaA== X-Gm-Gg: AZuq6aInIPsiHc9KDgHD4Ti0eeAlUkH2CzIUW1LnCPX9OgNjpdzFoKdfDo5wuPjLg2S tZanz1ISmwfE+UF5Cw2eYHfiR0adnwxvFnsz0fBwF5lj6GJEnD2TGJtSQEyvg2yYEG05dO5XsIO Z820VyBGjsY9Ajj2RRBUlNlFAF2IQ9jNZXhnzTsJmsn99RN6Z/04m7CVPqBR0sm2SsZq1qBq4ON PBPapMXERi5x3QephKw8vGXX8rRa+fls7/Rz6cG+3byKBtsU85pvE+ZY/nFDxF9AqcaX6bUnOzz UV6iNgqOxQhI+bRRsR39vpt+4oCtHJuvwaKDoTq3VU5YXdUOadJeTFkP5RYveFpNM2MHNmRk+Gr U1R9Boh7mIw85Zw4k4X+onWgOQleQo/TpvjIcEg0usSdBaqFM/mwwoF0XzoRxwddJXcfCUtLPJh G3xODZrgmtZqA/N/bU4nGmFeb6ALgLB/Vunw7TEQ4PS3VT2IHjG+6EPSL/ZDY8v12OG+G3VOMjY SfR9paH X-Received: by 2002:a17:907:1b24:b0:b88:716a:e4ae with SMTP id a640c23a62f3a-b8dab40f422mr631442966b.61.1769692776141; Thu, 29 Jan 2026 05:19:36 -0800 (PST) Received: from akuchynski.c.googlers.com.com (150.230.32.34.bc.googleusercontent.com. [34.32.230.150]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf1baa42sm262666666b.46.2026.01.29.05.19.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 05:19:35 -0800 (PST) From: Andrei Kuchynski To: Jameson Thies , Benson Leung , Abhishek Pandit-Subedi , Tzung-Bi Shih , Guenter Roeck Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, Andrei Kuchynski Subject: [PATCH 2/2] platform/chrome: cros_ec_typec: Reorder altmode registration Date: Thu, 29 Jan 2026 13:19:28 +0000 Message-ID: <20260129131928.794768-2-akuchynski@chromium.org> X-Mailer: git-send-email 2.53.0.rc1.217.geba53bf80e-goog In-Reply-To: <20260129131928.794768-1-akuchynski@chromium.org> References: <20260129131928.794768-1-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit By default, alternate mode priorities are set in registration order, with the last mode registered taking precedence. Changing the registration order of alternate modes prioritizes DisplayPort over Thunderbolt. Signed-off-by: Andrei Kuchynski --- drivers/platform/chrome/cros_ec_typec.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index d14bc90a62e6b..05d802c92075f 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -406,17 +406,6 @@ static int cros_typec_register_port_altmodes(struct cros_typec_data *typec, struct typec_altmode_desc desc; struct typec_altmode *amode; - /* All PD capable CrOS devices are assumed to support DP altmode. */ - memset(&desc, 0, sizeof(desc)); - desc.svid = USB_TYPEC_DP_SID; - desc.mode = USB_TYPEC_DP_MODE; - desc.vdo = DP_PORT_VDO; - amode = cros_typec_register_displayport(port, &desc, - typec->ap_driven_altmode); - if (IS_ERR(amode)) - return PTR_ERR(amode); - port->port_altmode[CROS_EC_ALTMODE_DP] = amode; - /* * Register TBT compatibility alt mode. The EC will not enter the mode * if it doesn't support it and it will not enter automatically by @@ -433,6 +422,17 @@ static int cros_typec_register_port_altmodes(struct cros_typec_data *typec, port->port_altmode[CROS_EC_ALTMODE_TBT] = amode; } + /* All PD capable CrOS devices are assumed to support DP altmode. */ + memset(&desc, 0, sizeof(desc)); + desc.svid = USB_TYPEC_DP_SID; + desc.mode = USB_TYPEC_DP_MODE; + desc.vdo = DP_PORT_VDO; + amode = cros_typec_register_displayport(port, &desc, + typec->ap_driven_altmode); + if (IS_ERR(amode)) + return PTR_ERR(amode); + port->port_altmode[CROS_EC_ALTMODE_DP] = amode; + port->state.alt = NULL; port->state.mode = TYPEC_STATE_USB; port->state.data = NULL; -- 2.53.0.rc1.217.geba53bf80e-goog