From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F76535DD19 for ; Thu, 29 Jan 2026 21:52:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723549; cv=none; b=ecte57sXShfy+BuLGurCswaZFcu503iydLmw5Xz9/v5IH6SJYj8gJljhetNZ2KiNzVCDfH/DhL7OnXtCaIeEBRgUxBUknBXVc4n5pXp+jRXf59m1jmY7Cm0HkuA3zxD0P8VF/PyhBgLNwVSWssU9J7KhgoIO3t4S1e90xYjZ/yI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769723549; c=relaxed/simple; bh=iweSHJtypL+EPMfaF3reSRoiAnkQsyy65w7ipUaRS5U=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SJy9jzHomMn+EeEMk9JH632BYlsLEpjZNawSrYs/nG/oo88jcQX7Nb9PlYQXyH/BtBI1eDj0siVNE1zm2Aze/xnEgulPIrKd97niQgnZIiOLPU9Kal7AGfj6y83SSHGBhaE8MwD+e/jCh662K5O4DGrqUNFZwe2ojZ3f8s6vZfM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=di9xeQC5; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="di9xeQC5" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4801eb2c0a5so13989525e9.3 for ; Thu, 29 Jan 2026 13:52:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769723547; x=1770328347; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ForbHPxhK2XNBAXRzpBPafliEsiPoSlc2Fuk+bA3eOE=; b=di9xeQC5wPWNKLnqEofm46wsWFvBqdx+kqN1tHkAjv8f9WMottwtxTpczH1ZAwEEHP apdBCIgVgbg7dygWKh1BCDe/G0wSUApYEB9AgXuQmQMMXW9wIilJix62pEVF/jy8g7S1 tmCys8tDKpEq+z69g2LZ6OfJnm1qudCEwH03T37Rpn8+4cyI56FeoVNPzjnUY6IDsy0P C5APVnm9EOfGY90MJ1w8BalUlCLV8yyemkROQIWtNt+Y5qN+tCaYJ1pbdQSpIny53lI5 DIk0L82HveOQ3KHdOLK+h8cQxuUUAfr8Lo2DAeDw477+3dxCrr284F3Z5SDn3OVoGwKh i6Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769723547; x=1770328347; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ForbHPxhK2XNBAXRzpBPafliEsiPoSlc2Fuk+bA3eOE=; b=dv4WF6eN+6BFB36NAy+jfEK/3v2mc6jXlNRKOjAk597+CHTnrZ6n4x7tHbWWKpd/C1 1Eqjz6/tKIBoKB2KKomFu+zP7lw6Y5Q9ZeMHgG4A0FqdxBKp5ICq7AhDHcZ2ndirzXJf fDD/2L6F/l7OGY6dT+PQ4P8o+fysGS+v5tI3cXjf7H31mOsDdHsbCKDLQA2HBtvmBNiE 0BsuFrGQXkzg3uPQS4HYS+MaXMb09o1Rbm9cJAlpu6lForfvi6+7PgJznaVKRel3uRKS K9kfvgaVB9y7u3AxcrYQ9oCuIhyqX1QNmusHgxnMaFhurVRAqTA8sfDqsfyeLYEb76Rs yccw== X-Forwarded-Encrypted: i=1; AJvYcCVaVcYbhomxxeIhu0eo1cQqj1+dEb/daeQ4iddhybanY5Al4gS6WQBOnrlmsfWcjur03RUho/s39RVRU84=@vger.kernel.org X-Gm-Message-State: AOJu0YxIOX0p1V7mEn9yCBOJ1H8pKggQLM+FJkyvmWQG7n+lAVNjrygF wTT4JNY0x6Grua1dk71W6GzcQsagGfBkmZAtbDA0EM/hSqLmqQMf47pM X-Gm-Gg: AZuq6aL5a0AVlvBajpT+jhQ5/kYrUh46bzV3+KHS3re3kWTSDLZS3jlM3XZFA2oonqM ROgIzwloj0dkpGcirCFv37Bva5lxnd9qrp6wQ7+ZJwoCwDpjtdasn0dwNnrpk5jfSzOcLmhg4VU gth6+IWU/4JlHpIdoZO/fEYDN4WlVhvxF89QN7eMbVJSBift5NYJvEUK/ybI9e3tYymvcM7QmLJ TOvA+hKFtDoxkRPrsFuKfb9vbTnge7YqiIBQ714pjFdWcPP45OtQfrUk+6HGz/vQne8mVdG9zry 31jbbA+o6k+wplY/+ta+Aa751qfVgO2rVqsFbvmeVE6MeSqYD/7aP8dfxOJCEOXyQZvFv7qFnRq cY2m4lrNB6P4lB90cKiMEEWyJCLJ57oc3GZvAFfKgd3Zd2C9KNvTL6JA49VqTCf0qWFLPuyAOE+ QGFtcWwqz7jcoWxvSnEQRvcTRImDGn/QZbrJbj4AsNSeAzZinH+WKb X-Received: by 2002:a05:600c:4f09:b0:477:755b:5587 with SMTP id 5b1f17b1804b1-482db44d1b1mr5930005e9.8.1769723546512; Thu, 29 Jan 2026 13:52:26 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482dbcf9c3fsm2626395e9.4.2026.01.29.13.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 13:52:26 -0800 (PST) Date: Thu, 29 Jan 2026 21:52:25 +0000 From: David Laight To: Kuppuswamy Sathyanarayanan Cc: "Rafael J . Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Srinivas Pandruvada , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/9] powercap: intel_rapl: Use GENMASK() and BIT() macros Message-ID: <20260129215225.33cce6dc@pumpkin> In-Reply-To: <20260129183646.558866-4-sathyanarayanan.kuppuswamy@linux.intel.com> References: <20260129183646.558866-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20260129183646.558866-4-sathyanarayanan.kuppuswamy@linux.intel.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 29 Jan 2026 10:36:40 -0800 Kuppuswamy Sathyanarayanan wrote: > Replace hardcoded bitmasks and bit shift operations with standard > GENMASK(), GENMASK_ULL(), BIT(), and BIT_ULL() macros for better > readability and to follow kernel coding conventions. > > No functional changes. Assuming that changing values to 'unsigned long' doesn't have any subtle side effects. ... > value = (ra.value & ENERGY_UNIT_MASK) >> ENERGY_UNIT_OFFSET; > - rd->energy_unit = ENERGY_UNIT_SCALE * 1000000 / (1 << value); > + rd->energy_unit = ENERGY_UNIT_SCALE * 1000000 / BIT(value); That should really be: rd->energy_unit = ENERGY_UNIT_SCALE * 1000000 >> value; While using BIT() for bit patterns is resonable, wholesale substition isn't really right - and that isn't a bit pattern. David