From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24F54346A0A for ; Fri, 30 Jan 2026 22:32:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769812361; cv=none; b=KcKx6dy0v7qwTchadVLtifvkXEjn24ekdTdPgX4DwDfskHd13HS7DTPjuJ0HyoDYPSYqXez0X2jyLVujEDhX78uGT08KA7HN7NkAvOeFt2cnxtVTjJF9x5B2vY8r7D1WaACCHJoyXRYRITqE3VNaxtxbUp3Z8gGYFm51oD+mf8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769812361; c=relaxed/simple; bh=VSbn+UuoIo7vv7MaKkxXYjSATwr1+7mAOV8uCQfu00A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kH8ZuMusq+0pX9kAGnkQAuvHCWH7PZE+L4SOQEx2WpvMIJ10O5FuUxc4x0JqgqihPmVFnuHGBAdtcTkUuAWgriTu9VOek5ib4YeitZo61rhO6RftIIBCSz67vDZfy3DbI6g1SH0Cj56FsEJ+pwhwA3WUI++IP8ifctOLuUYmWWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=K//PEDtc; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="K//PEDtc" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-124899ee9d3so1954005c88.0 for ; Fri, 30 Jan 2026 14:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1769812359; x=1770417159; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GV7Voi0nrInsLXEq5RkNoDVzXZs64tJ1PAjrF2nT2jo=; b=K//PEDtcfJqDtljpxhWATQfN7VxK77xZXE6o34Rhi9KgPcTVdRKUYSXMBoscCrT0dy brVumGILiMgBtcdC+PQwJ8lx+Gutv4FoLEnz36l2O76+nEHQMGyeLgA/E+dn9EMcRUBM SXjPaN4WvBVEYcSaSn5BWZIqOw2dHaSD/VHkntzzSD6LIHU5PFV5ROgSNUrKVCgqPAao Gf7RGRHcscy6J9LXOU8ShdM2sNdShzAV4QQCDBZ2CncEL26wCuPb54RJQlyRSIjf2AgY oOXoVIKtt+AfulPoS8tU+c5iUOwiisxgZeQ6lJ+FiVw6x7ncAHSlKzE3+RC+iPSlni8A JT7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769812359; x=1770417159; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GV7Voi0nrInsLXEq5RkNoDVzXZs64tJ1PAjrF2nT2jo=; b=ctf2HAC+MTPNYPouPN+tFsJTVGKaGMlNHyAhDGSbh/72RfTBLmmHEzsNimgVA2zqUt uIOSpwFUWsv+FG5W2DbmtLcvtL/SsVgBLqYsAVh7yzHsI7FQtDUhYF7QWuk7/GtQSBAs w2FaeFHNor/n5kiJFBuRd5lnWuqTkLJU6UOIvuLnWPX6hLslpRLIr8U31Hio/G8YOPgF LURim9AwtsWfor3x18pHYuJYJ4wVFY2wDc5N19aw6gLQ7bfWRPwu4sm6ISev1XLoOoUM cuRq50Y0FnHeO0x45AABPoJbY2plV2Qjn6BNgsyZVmemGeTaFKnM/YwHnxBz/Q3N9UJj u9MQ== X-Forwarded-Encrypted: i=1; AJvYcCWDWsurP+ektulI8SpxC24sRKDDLJRPs5LtSttNbGY6pxzFJAszbO3obqY2xmA5O97+i1Yin2aGQ46lEY0=@vger.kernel.org X-Gm-Message-State: AOJu0YzO6Fb2NGeeCz+4qf5jc+FD7ypVAiaT0k3fOb5KPM+1HKwkdi+V Mc8DXV80/e70zAhrrmtL1xjgufub+YQ1wtcX2yXIEltyJZZnq0AglcDqXZdLqU3Y3nA= X-Gm-Gg: AZuq6aLTEmq+hDCrEjDHqZIGGmWaD/Xe5kLl2SsR4OUmopMY0b22I2aTAnSI7EhDe4V x0jf0MIK1o3mJAcwfzrucywOrUITrv5RzZnygUqO4er2TWZ+DPel71uVDDoIUTNomF/1PBoKU9S rOTecxRnSOAF2oEFagJLwK/xR3nx/FO7ye7hZ4uq0I8+jSYXZD1NQqfj1UAQ8mocThG36Ps5T6q AC22BuO1YvmMa5afFNdNPm6Z6EHahSrfp4lYLGgnk9JM6nmcXGL9wRKP98xrjRoX8vgFe1yGzaA tOtACtJo8zry2rJmSsb8yzHMc/+gYgTfr4fftC6Y8kq4LbNbuLpSZvR5HRwFATic2W3wcvJAr6J JnsNjSfdmMuMZxaZ2yfBVMmWRucmMvMp8ZDsChqWTIOe87WChWm53XcNi5Q3Sb8joC7V+AAS2Fb 4CAZnap7lpTtdtyHXvL1DDwjlI+ohNqJ8= X-Received: by 2002:a05:7022:4185:b0:119:e569:f872 with SMTP id a92af1059eb24-125c19ce46amr1704042c88.15.1769812359007; Fri, 30 Jan 2026 14:32:39 -0800 (PST) Received: from medusa.lab.kspace.sh ([208.88.152.253]) by smtp.googlemail.com with UTF8SMTPSA id a92af1059eb24-124a9cdcbcfsm14084353c88.0.2026.01.30.14.32.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 14:32:38 -0800 (PST) Date: Fri, 30 Jan 2026 14:32:37 -0800 From: Mohamed Khalfella To: Sagi Grimberg Cc: Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Aaron Dailey , Randy Jennings , John Meneghini , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 09/14] nvme: Implement cross-controller reset completion Message-ID: <20260130223237.GG1710902-mkhalfella@purestorage.com> References: <20251126021250.2583630-1-mkhalfella@purestorage.com> <20251126021250.2583630-10-mkhalfella@purestorage.com> <9ac9b7c8-139f-48f9-bfd2-bfd03506abf0@grimberg.me> <20251231235136.GQ3864520-mkhalfella@purestorage.com> <14098277-cbcf-4397-bf72-f9cf1613789b@grimberg.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14098277-cbcf-4397-bf72-f9cf1613789b@grimberg.me> On Sun 2026-01-04 23:15:53 +0200, Sagi Grimberg wrote: > > > On 01/01/2026 1:51, Mohamed Khalfella wrote: > > On Sat 2025-12-27 12:24:17 +0200, Sagi Grimberg wrote: > >>> + log = kmalloc(sizeof(*log), GFP_KERNEL); > >>> + if (!log) > >>> + return; > >>> + > >>> + ret = nvme_get_log(ctrl, 0, NVME_LOG_CCR, 0x01, > >>> + 0x00, log, sizeof(*log), 0); > >>> + if (ret) > >>> + goto out; > >>> + > >>> + spin_lock_irqsave(&ctrl->lock, flags); > >>> + for (i = 0; i < le16_to_cpu(log->ne); i++) { > >>> + entry = &log->entries[i]; > >>> + if (entry->ccrs == 0) /* skip in progress entries */ > >>> + continue; > >> What does ccrs stand for? > > Cross-Controller Reset Status > > > > 0x00 -> In Progress > > 0x01 -> Success > > 0x02 -> Failed > > 0x03 - 0xff -> Reserved > > Let's add it as a proper enumeration please. > Done