From: Igor Korotin via B4 Relay <devnull+igor.korotin.linux.gmail.com@kernel.org>
To: "Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>
Cc: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-i2c@vger.kernel.org, markus.probst@posteo.de,
Igor Korotin <igor.korotin.linux@gmail.com>
Subject: [PATCH 4/5] rust: i2c: add I2C wrappers
Date: Sat, 31 Jan 2026 14:12:46 +0000 [thread overview]
Message-ID: <20260131-i2c-adapter-v1-4-5a436e34cd1a@gmail.com> (raw)
In-Reply-To: <20260131-i2c-adapter-v1-0-5a436e34cd1a@gmail.com>
From: Igor Korotin <igor.korotin.linux@gmail.com>
Add safe Rust wrappers for common I2C/SMbus operations on I2C clients.
These wrappers provide safe abstractions over low-level C API calls:
- SMbus byte operations: read/write byte and byte data
- SMbus word operations: read/write word data
- SMbus block operations: read/write I2C block data
- Master I2C operations: master receive and master send
All operations include proper error handling through the Result type.
Signed-off-by: Igor Korotin <igor.korotin.linux@gmail.com>
---
rust/helpers/helpers.c | 1 +
rust/helpers/i2c.c | 15 ++++++++
rust/kernel/i2c/client.rs | 92 +++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 108 insertions(+)
diff --git a/rust/helpers/helpers.c b/rust/helpers/helpers.c
index 79c72762ad9c..6f6b0ff8713a 100644
--- a/rust/helpers/helpers.c
+++ b/rust/helpers/helpers.c
@@ -29,6 +29,7 @@
#include "err.c"
#include "irq.c"
#include "fs.c"
+#include "i2c.c"
#include "io.c"
#include "jump_label.c"
#include "kunit.c"
diff --git a/rust/helpers/i2c.c b/rust/helpers/i2c.c
new file mode 100644
index 000000000000..05bbd26eaaf8
--- /dev/null
+++ b/rust/helpers/i2c.c
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#include <linux/i2c.h>
+
+__rust_helper int rust_helper_i2c_master_recv(const struct i2c_client *client,
+ char *buf, int count)
+{
+ return i2c_master_recv(client, buf, count);
+}
+
+__rust_helper int rust_helper_i2c_master_send(const struct i2c_client *client,
+ const char *buf, int count)
+{
+ return i2c_master_send(client, buf, count);
+}
diff --git a/rust/kernel/i2c/client.rs b/rust/kernel/i2c/client.rs
index a597793ff038..76fa01cb0351 100644
--- a/rust/kernel/i2c/client.rs
+++ b/rust/kernel/i2c/client.rs
@@ -140,6 +140,98 @@ unsafe impl Send for I2cClient {}
// (i.e. `I2cClient<Normal>) are thread safe.
unsafe impl Sync for I2cClient {}
+impl I2cClient<device::Normal> {
+ /// The C `i2c_smbus_read_byte` function wrapper for SMbus "read byte" protocol
+ pub fn i2c_smbus_read_byte(&self) -> Result<u8> {
+ // SAFETY: self is a valid reference to a I2cClient<Normal>
+ let result = unsafe { bindings::i2c_smbus_read_byte(self.as_raw()) };
+ to_result(result)?;
+ Ok(result as u8)
+ }
+
+ /// The C `i2c_smbus_write_byte` function wrapper for SMbus "write byte" protocol
+ pub fn i2c_smbus_write_byte(&self, value: u8) -> Result {
+ // SAFETY: self is a valid reference to a I2cClient<Normal>
+ to_result(unsafe { bindings::i2c_smbus_write_byte(self.as_raw(), value) })
+ }
+
+ /// The C `i2c_smbus_read_byte_data` function wrapper for SMbus "read byte" protocol
+ pub fn i2c_smbus_read_byte_data(&self, command: u8) -> Result<u8> {
+ // SAFETY: self is a valid reference to a I2cClient<Normal>
+ let result = unsafe { bindings::i2c_smbus_read_byte_data(self.as_raw(), command) };
+ to_result(result)?;
+ Ok(result as u8)
+ }
+
+ /// The C `i2c_smbus_write_byte_data` function wrapper for SMbus "write byte" protocol
+ pub fn i2c_smbus_write_byte_data(&self, command: u8, value: u8) -> Result {
+ // SAFETY: self is a valid reference to a I2cClient<Normal>
+ to_result(unsafe { bindings::i2c_smbus_write_byte_data(self.as_raw(), command, value) })
+ }
+
+ /// The C `i2c_smbus_read_word_data` function wrapper for SMbus "read word" protocol
+ pub fn i2c_smbus_read_word_data(&self, command: u8) -> Result<u16> {
+ // SAFETY: self is a valid reference to a I2cClient<Normal>
+ let result = unsafe { bindings::i2c_smbus_read_word_data(self.as_raw(), command) };
+ to_result(result)?;
+ Ok(result as u16)
+ }
+
+ /// The C `i2c_smbus_write_word_data` function wrapper for SMbus "write word" protocol
+ pub fn i2c_smbus_write_word_data(&self, command: u8, value: u16) -> Result {
+ // SAFETY: self is a valid reference to a I2cClient<Normal>
+ to_result(unsafe { bindings::i2c_smbus_write_word_data(self.as_raw(), command, value) })
+ }
+
+ /// The C `i2c_smbus_read_i2c_block_data` function wrapper for SMbus "block read" protocol
+ pub fn i2c_smbus_read_i2c_block_data(&self, command: u8, values: &mut [u8]) -> Result<usize> {
+ // SAFETY: self is a valid reference to a I2cClient<Normal>
+ let result = unsafe {
+ bindings::i2c_smbus_read_i2c_block_data(
+ self.as_raw(),
+ command,
+ values.len() as u8,
+ values.as_mut_ptr(),
+ )
+ };
+ to_result(result)?;
+ Ok(result as usize)
+ }
+
+ /// The C `i2c_smbus_write_i2c_block_data` function wrapper for SMbus "block write" protocol
+ pub fn i2c_smbus_write_i2c_block_data(&self, command: u8, values: &[u8]) -> Result {
+ // SAFETY: self is a valid reference to a I2cClient<Normal>
+ to_result(unsafe {
+ bindings::i2c_smbus_write_i2c_block_data(
+ self.as_raw(),
+ command,
+ values.len() as u8,
+ values.as_ptr(),
+ )
+ })
+ }
+
+ /// The C `i2c_master_recv` function wrapper to issue a single I2C message in master
+ /// receive mode
+ pub fn i2c_master_recv(&self, buf: &mut [u8]) -> Result<usize> {
+ // SAFETY: self is a valid reference to a I2cClient<Normal>
+ let result =
+ unsafe { bindings::i2c_master_recv(self.as_raw(), buf.as_mut_ptr(), buf.len() as i32) };
+ to_result(result)?;
+ Ok(result as usize)
+ }
+
+ /// The C `i2c_master_send` function wrapper to issue a single I2C message in master
+ /// transmit mode
+ pub fn i2c_master_send(&self, buf: &[u8]) -> Result<usize> {
+ // SAFETY: self is a valid reference to a I2cClient<Normal>
+ let result =
+ unsafe { bindings::i2c_master_send(self.as_raw(), buf.as_ptr(), buf.len() as i32) };
+ to_result(result)?;
+ Ok(result as usize)
+ }
+}
+
/// The registration of an i2c client device.
///
/// This type represents the registration of a [`struct i2c_client`]. When an instance of this
--
2.43.0
next prev parent reply other threads:[~2026-01-31 14:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 14:12 [PATCH 0/5] rust: extend I2C functionality Igor Korotin via B4 Relay
2026-01-31 14:12 ` [PATCH 1/5] rust: i2c: split client and adapter code into separate files Igor Korotin via B4 Relay
2026-01-31 14:12 ` [PATCH 2/5] rust: bits: add define_flags macro Igor Korotin via B4 Relay
2026-02-08 13:56 ` Daniel Almeida
2026-01-31 14:12 ` [PATCH 3/5] rust: i2c: Add I2C Adapter registration abstractions Igor Korotin via B4 Relay
2026-01-31 14:12 ` Igor Korotin via B4 Relay [this message]
2026-01-31 14:28 ` [PATCH 4/5] rust: i2c: add I2C wrappers Markus Probst
2026-02-04 16:49 ` Igor Korotin
2026-02-04 16:59 ` Danilo Krummrich
2026-02-08 12:44 ` Igor Korotin
2026-02-04 17:03 ` Danilo Krummrich
2026-01-31 14:12 ` [PATCH 5/5] samples: rust: add Rust I2C adapter registration sample Igor Korotin via B4 Relay
2026-01-31 14:26 ` [PATCH 0/5] rust: extend I2C functionality Danilo Krummrich
2026-02-08 12:34 ` Igor Korotin
2026-02-08 17:07 ` Danilo Krummrich
2026-02-09 11:31 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260131-i2c-adapter-v1-4-5a436e34cd1a@gmail.com \
--to=devnull+igor.korotin.linux.gmail.com@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=igor.korotin.linux@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=markus.probst@posteo.de \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®