From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24DC71A9F97 for ; Sat, 31 Jan 2026 15:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769872920; cv=none; b=CgsT98mXKjaDX/BrTDSctoLq8KSWbiczHiqFNW5zevK9vXUMFK49z2nkLPBWidqc4vF2JGG8f/wbQHVEqkrNwo0aK2N441EHJA1/A5iKzc0UYuHrlYxokKhOfpqjNtMQ99YMTUP2MBsCh2Il/ws4oTsbC/6pKq3IxzTWTep6DDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769872920; c=relaxed/simple; bh=GRH1peQPIv1+SlBs3S7nVfVFxwpsEB+llTfBFPuBhsg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hP1EtT81NJhyBGnbMZPNh47w0uvqbdMk5YAeHmlOPXN+us5xALWa6BoBogMFLgO+hHeZQkWQO6cSXDJDKI9CHsAAlVkvnXu7VXpo7FN8jKArxYuopTGcoZ4xd/ifvVr1+b4aXUGd4prszNS4OFZxfNVfvAHK46feR9/TDA4xTyA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=lsoB9Upx; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lsoB9Upx" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xZ6fjY0ejkdsWvIE5gCXzvUM45Jcv8l9zaXoD8/ppTc=; b=lsoB9UpxZ1/qwqcrtVQydIweYr QVtgnYtBmvxH3xiDWkFr1L0mhFb19EYUC3Trpwt81mpYEbtE/AGixMjBaaKM0kr63bTT5Pop45Bjp u4uP5240iar39NyLQVqmIAXLQey92uZ9+uIEmU600ZIgD1fw5ibkX1j26gEax6c9gCUUMlIgE8P0J uIBgxN8Cpplt+qX1O40+IcSuBbaHbgQFfdBbE39eYQe/L9FYfryk9AosmgmSH/nk97OQbNa6xiK0O yVCrLt10Hvn3xMYn6N/GLZqR5eLtePzorROgg0Oe45vwch0gxyPf09XQcu3j5zeS7nBhZm3Sk2q8O 0uuq8iQg==; Received: from 2001-1c00-8d85-5700-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:5700:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vmCn4-0000000DmNN-03XJ; Sat, 31 Jan 2026 15:21:38 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 19764300754; Sat, 31 Jan 2026 16:21:36 +0100 (CET) Date: Sat, 31 Jan 2026 16:21:35 +0100 From: Peter Zijlstra To: Zhang Qiao Cc: mingo@kernel.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, wangtao554@huawei.com, quzicheng@huawei.com, kprateek.nayak@amd.com, wuyun.abel@bytedance.com, dsmythies@telus.net, Hui Tang Subject: Re: [PATCH 4/4] sched/fair: Revert 6d71a9c61604 ("sched/fair: Fix EEVDF entity placement bug causing scheduling lag") Message-ID: <20260131152135.GA509491@noisy.programming.kicks-ass.net> References: <20260130093439.803225718@infradead.org> <20260130094608.304041157@infradead.org> <716f3b5a-8a82-88e1-b684-4723882a0d6b@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <716f3b5a-8a82-88e1-b684-4723882a0d6b@huawei.com> On Sat, Jan 31, 2026 at 09:47:07AM +0800, Zhang Qiao wrote: > > if (se->on_rq) { > > /* commit outstanding execution time */ > > update_curr(cfs_rq); > > - update_entity_lag(cfs_rq, se); > > - se->deadline -= se->vruntime; > > + avruntime = avg_vruntime(cfs_rq); > > + se->vlag = entity_lag(avruntime, se); > > > vlag is updated here. Considering vlag and vprot share the same union, updating > vlag will overwrite vprot. Is it right to call protect_slice() (which use vprot) > after this update? Oh you are quite right; I'm sure Ingo had a patch removing that union, but clearly that's not been merged yet. Sorry about that mistake; I'll make a new version on Monday. Thanks!