From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: light: bh1780: fix PM runtime leak on error path
Date: Sat, 31 Jan 2026 17:05:36 +0000 [thread overview]
Message-ID: <20260131170536.48a16474@jic23-huawei> (raw)
In-Reply-To: <CAD++jLnL6f0Jg0rcgqzkR=GE12JmbbJVcTzVyHYsr9r6d02fXg@mail.gmail.com>
On Fri, 30 Jan 2026 14:16:36 +0100
Linus Walleij <linusw@kernel.org> wrote:
> On Fri, Jan 30, 2026 at 12:31 PM Antoniu Miclaus
> <antoniu.miclaus@analog.com> wrote:
>
> > Move pm_runtime_put_autosuspend() before the error check to ensure
> > the PM runtime reference count is always decremented after
> > pm_runtime_get_sync(), regardless of whether the read operation
> > succeeds or fails.
> >
> > Fixes: 1f0477f18306 ("iio: light: new driver for the ROHM BH1780")
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
>
> This looks right!
> Reviewed-by: Linus Walleij <linusw@kernel.org>
I've applied this to my local tree for now. Given where we are in the
cycle this likely won't go out until after the merge window when
I have rebased on rc1.
Thanks,
Jonathan
>
> Yours,
> Linus Walleij
prev parent reply other threads:[~2026-01-31 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 11:30 Antoniu Miclaus
2026-01-30 13:16 ` Linus Walleij
2026-01-31 17:05 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260131170536.48a16474@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linusw@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sakari.ailus@linux.intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®