mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Usyskin <alexander.usyskin@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Menachem Adin <menachem.adin@intel.com>,
	Alexander Usyskin <alexander.usyskin@intel.com>,
	linux-kernel@vger.kernel.org,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: [char-misc-next 5/7] mei: convert PCI error to common errno
Date: Sun,  1 Feb 2026 11:43:56 +0200	[thread overview]
Message-ID: <20260201094358.1440593-6-alexander.usyskin@intel.com> (raw)
In-Reply-To: <20260201094358.1440593-1-alexander.usyskin@intel.com>

Ensure that callers receive only < 0 return value on error.
Convert PCI error returned by pci_read_config_dword()
to common errno before returning from function.

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
---
 drivers/misc/mei/hw-txe.c | 2 +-
 drivers/misc/mei/pci-me.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/mei/hw-txe.c b/drivers/misc/mei/hw-txe.c
index 008cb1ede56c..a83de653c603 100644
--- a/drivers/misc/mei/hw-txe.c
+++ b/drivers/misc/mei/hw-txe.c
@@ -653,7 +653,7 @@ static int mei_txe_fw_status(struct mei_device *dev,
 				       fw_src->status[i],
 				       fw_status->status[i], ret);
 		if (ret)
-			return ret;
+			return pcibios_err_to_errno(ret);
 	}
 
 	return 0;
diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c
index a75773cc8fb7..8d16bfa6027c 100644
--- a/drivers/misc/mei/pci-me.c
+++ b/drivers/misc/mei/pci-me.c
@@ -153,7 +153,7 @@ static int mei_me_read_fws(const struct mei_device *dev, int where, const char *
 
 	ret = pci_read_config_dword(pdev, where, val);
 	trace_mei_pci_cfg_read(&dev->dev, name, where, *val, ret);
-	return ret;
+	return pcibios_err_to_errno(ret);
 }
 
 /**
-- 
2.43.0


  parent reply	other threads:[~2026-02-01 10:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-01  9:43 [char-misc-next 0/7] mei: csc: support controller with separate PCI device Alexander Usyskin
2026-02-01  9:43 ` [char-misc-next 1/7] mei: me: use PCI_DEVICE_DATA macro Alexander Usyskin
2026-02-01  9:43 ` [char-misc-next 2/7] mei: fix idle print specifiers Alexander Usyskin
2026-02-01  9:43 ` [char-misc-next 3/7] mei: me: move trace into firmware status read Alexander Usyskin
2026-02-01  9:43 ` [char-misc-next 4/7] mei: trace: print return value of pci_cfg_read Alexander Usyskin
2026-02-01  9:43 ` Alexander Usyskin [this message]
2026-02-01  9:43 ` [char-misc-next 6/7] mei: csc: support controller with separate PCI device Alexander Usyskin
2026-02-01  9:43 ` [char-misc-next 7/7] mei: csc: wake device while reading firmware status Alexander Usyskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260201094358.1440593-6-alexander.usyskin@intel.com \
    --to=alexander.usyskin@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menachem.adin@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®