From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5C69D2D3725 for ; Mon, 2 Feb 2026 09:34:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770024867; cv=none; b=nXPlV6cw4bDjh72O+5n8292iwBIPR4/NvuhZqj/IujoevJSaUJjhzQnWzqHgPJvaDJrubCwfutL9RRq13AzU2NgJuimIxtAZroWOBZYF8SaIs3QE6QyvlNWXN9MHPOtV8nE2u82CT2NGrLbCBTeyosv8tT+henATM3LfeBAEKSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770024867; c=relaxed/simple; bh=DmjbDlzT0f1zqFRseblFfl6EnZmEnjYn41rANQon/5s=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=Bf6F5IWT6AF8e/4xe74TEns+b0fz4E9PMIMrnXZjLjUnumC6xi57Ac0TsC6S6tfjDMOGoGBE2+GWj3TAMnPjKW7UWzwp7yhXSdHuqVZ7t9nBJ0MYFUVL3mU3lIEUBFKXqw+M/FrgOR1IZSlmFwf8cXLC5jwtQYtDYOrXQwvVqLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DDE07339; Mon, 2 Feb 2026 01:34:17 -0800 (PST) Received: from e132581.arm.com (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8D6A93F740; Mon, 2 Feb 2026 01:34:22 -0800 (PST) From: Leo Yan Subject: [PATCH v3 0/8] coresight: Fix device registration and unregistration Date: Mon, 02 Feb 2026 09:33:56 +0000 Message-Id: <20260202-arm_coresight_refactor_dev_register-v3-0-03292470c48c@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAIVvgGkC/42NwQqDMBBEf6Xk3JQkaqA99T+KSNysugdN2UhoE f+9W6H3Ht8w82ZTGZkwq9tpU4yFMqVFoDqfFExhGVFTFFbOOG+sMzrw3EFizDROa8c4BFgTdxG LwEh5RdaD9WD8Nfa1jUpMT6nR63h5tMKT1BK/j9PivunP7//yF6eN7ptQgalrC7a5y+oCaVbtv u8fY2fSg9QAAAA= X-Change-ID: 20260120-arm_coresight_refactor_dev_register-f16c069db41d To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Greg Kroah-Hartman , Mathieu Poirier , Mao Jinlong Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Leo Yan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770024862; l=3686; i=leo.yan@arm.com; s=20250604; h=from:subject:message-id; bh=DmjbDlzT0f1zqFRseblFfl6EnZmEnjYn41rANQon/5s=; b=sfolEIqWg+TKNlD6h9rHtG9GR1b0ZhjO0l6tCFrV79wSrEpjRU0XYXVf1qsoaUPyUZ0T7eeDq rDVlEVCx93iDrNdYjHYoGRnOMpnafC0z7/gEwocZSq7pX/UwQ+16+8F X-Developer-Key: i=leo.yan@arm.com; a=ed25519; pk=k4BaDbvkCXzBFA7Nw184KHGP5thju8lKqJYIrOWxDhI= This series is to fix and refactor CoreSight device registration and unregistration, it can be divided into three small parts: Patches 01-03: Three fixes for memory leak, device reference and mutex protection. Patches 04-05: Move connection cleanup operations into coresight_remove_conns(). Patches 06-08: Refactor error handling in coresight_register(). This series is verified on Juno board with kmemleak detector. For kmemleak verifying: echo clear > /sys/kernel/debug/kmemleak insmod coresight modules rmmod coresight modules echo scan > /sys/kernel/debug/kmemleak The result shows no memory leak during a cycle of device registration and unregistration. --- Changes in v3: - Updated patch 01 to use coesight core layer for device index list (Suzuki). - Link to v2: https://lore.kernel.org/r/20260126-arm_coresight_refactor_dev_register-v2-0-b5a3c0441c15@arm.com Changes in v2: - Refined the commit log in patch 06 (Suzuki). - Unified to call coresight_unregister() for error handling (Suzuki). - Refactor connection and sysfs group release. - Link to v1: https://lore.kernel.org/linux-arm-kernel/20250512154108.23920-1-leo.yan@arm.com/ To: Suzuki K Poulose To: Mike Leach To: James Clark To: Alexander Shishkin To: Greg Kroah-Hartman To: Mathieu Poirier To: Mao Jinlong Cc: coresight@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Leo Yan --- Leo Yan (8): coresight: Fix memory leak in coresight_alloc_device_name() coresight: Get parent device reference after sink ID map allocation coresight: Protect unregistration with mutex coresight: Refactor output connection sysfs link cleanup coresight: Refactor sysfs connection group cleanup coresight: Move sink validation into etm_perf_add_symlink_sink() coresight: Do not mix success path with failure handling coresight: Unify error handling in coresight_register() drivers/hwtracing/coresight/coresight-catu.c | 4 +- drivers/hwtracing/coresight/coresight-core.c | 230 +++++++++++++-------- drivers/hwtracing/coresight/coresight-ctcu-core.c | 4 +- drivers/hwtracing/coresight/coresight-cti-core.c | 19 +- drivers/hwtracing/coresight/coresight-dummy.c | 7 +- drivers/hwtracing/coresight/coresight-etb10.c | 4 +- drivers/hwtracing/coresight/coresight-etm-perf.c | 5 +- drivers/hwtracing/coresight/coresight-funnel.c | 4 +- drivers/hwtracing/coresight/coresight-platform.c | 2 +- drivers/hwtracing/coresight/coresight-priv.h | 3 +- drivers/hwtracing/coresight/coresight-replicator.c | 4 +- drivers/hwtracing/coresight/coresight-stm.c | 4 +- drivers/hwtracing/coresight/coresight-tmc-core.c | 12 +- drivers/hwtracing/coresight/coresight-tnoc.c | 4 +- drivers/hwtracing/coresight/coresight-tpda.c | 4 +- drivers/hwtracing/coresight/coresight-tpdm.c | 4 +- drivers/hwtracing/coresight/coresight-tpiu.c | 4 +- drivers/hwtracing/coresight/ultrasoc-smb.c | 4 +- include/linux/coresight.h | 14 +- 19 files changed, 175 insertions(+), 161 deletions(-) --- base-commit: eebe8dbd8630f51cf70b1f68a440cd3d7f7a914d change-id: 20260120-arm_coresight_refactor_dev_register-f16c069db41d Best regards, -- Leo Yan