From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f179.google.com (mail-dy1-f179.google.com [74.125.82.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 943D91F181F for ; Mon, 2 Feb 2026 07:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770017054; cv=none; b=IYfp/3BaTJYKsCbrvH9XbHZtOmbB3P4QfJxesLxec9TkEy8adyyMFV7VG//6h4GPK1CpTP2qEy6Ara4fRai+Ew1LrwVqcFLY7V6xG/is9CdyDKWwK83ApHG5Py5eAd+QQjFBt13nXfblK+UZJ9qys5Qe9MBQYeqsZZUOIabaa0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770017054; c=relaxed/simple; bh=W0maPzPO5M3pfvomopBHHuSGpDn/zGTQOAOllm67+rw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rgw+66pdyMLDp4hYHAKqLkFsZl96v6DjGK0gbCGG4ameVrtViVf3VCO0RAWuZFunjIbyAweqvqH5ckW0L+6/ZzpFREJerki4alRDI5inGfd4NBcg/1CNAVxg67SNC6+VUNuPHbewGXl9AKPRSS5mE/3oRWwSoSBEBLvLWRzyRrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kKDWvOVC; arc=none smtp.client-ip=74.125.82.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kKDWvOVC" Received: by mail-dy1-f179.google.com with SMTP id 5a478bee46e88-2b785801c93so11390053eec.0 for ; Sun, 01 Feb 2026 23:24:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770017053; x=1770621853; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gRIVmJL3tSUzEWbmHeuBiYdL6z2LK0b9AkJ41US+kYI=; b=kKDWvOVCCNIoeUad7CWx1xVtm2e0S3rkpyUMAiy/fFMj9KoWEWRI6MFUcffclkRHxQ JIxbdRqvi/58wy72AW+mmh4Oz1dGmhR7dDIig5uusDawLVJ3WbCnsYIGJKSEIVQjkjZW TGdaf4S27Q2jN8cO3PfM635086Fc5eR4q2S67QL7r3hDPY2r7XAU4bIRkWaUuuZKs4P1 n3oZdokwpytTWtTmyCVTO3h64Vf7P6xWeoT6Tzf2RH2PlSgqqXMp/owr7frR/LRoMfxb c5EP3cT4GFMuzCFyuCYaseaEOJx5uE2lG4MDyt8JLLo71p7D0T5yjZrlpElZbsOQgO/g a0Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770017053; x=1770621853; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gRIVmJL3tSUzEWbmHeuBiYdL6z2LK0b9AkJ41US+kYI=; b=O1nk+z0fXr6EYW4QqP1HdW3a+R4IJ/kLUAZjn7QKk76hWTO70emVU9JSkdskgMpTbh yr6KQiwiJ1cCFnXzlaEgcbbP/VsJQoIMV/nLMhKTQGIrJF3xyp0ckCISWCXPO+sv6TyT lN/6025l+W+M81zCP6oPZFVE91JPiQRf4DxSZVoKPAMLWU7Yh8tlyyn/lVxUXvAV4u6G +3DSivM1/ccw3IczitkQG5EthmQvXnDjqbtrZw/2oOF2sV6sh8/tIC+O4oNPkCEuOebJ 1jlviBGwPAAvPC4kK8Ty2E6umBZvrpkWQYukJljQEdrX37+Nx4cT5oRbwH4IGtuiZ8S0 1BBw== X-Gm-Message-State: AOJu0YyvisSGbZKj94QKdLxt32D10JTy0CrbEn4EEKuJP86S5ZkcxzKi qzO0FxFphcnp73eExoJJ9EmvTXyUXA1Be1JAfg5sTWA8W876h12Zjex+pHpeqA== X-Gm-Gg: AZuq6aJXg0nPlV/PJWclQs8kIYGNQE7uNuxwM/X/BCC8Ct59lHnPYATztabj/nDfXTp un4rgCvAcEfazyaXvt2KJn78znvhv4c3WmCtLrftJg8QYEVeP+GlcYkc+wtl6SzUU1pqV6ZMtGC ikJUdWIpkYaA86QKx024+HG0j61xO0SmqoxXbQwzVESn0RxjVw6Lgr4+yVxMBnUB3ACaKH4fTpB cFuVMIw9FQRaM3KMB8lcIP+KeKS1ZWDBibH2Qt/vp87ImpACnSLXnebyzZpqmu3Ib2nvHOSnOJ8 P/Qi3RUDqasiLvMISV3k4/q7vKjZR9vYR1XbyDxjhXotojZdH44Pzm8MbR2gij1r52tBarZ9Qlk nKpDyT6FsYXcYOoEQaPJv5dCy/sATocxWL29D/g4c2MflPJQC+7TiypCuzcH4UupnfXbTDtOdC+ qJTDy11dBKU6J0ahuhJjlu1XJFQdDIT9l0ak1E/rX2KQ== X-Received: by 2002:a17:902:e801:b0:2a0:d59e:3c9e with SMTP id d9443c01a7336-2a8d80382dfmr111267515ad.33.1770011912514; Sun, 01 Feb 2026 21:58:32 -0800 (PST) Received: from localhost.localdomain ([116.128.244.171]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b4173a2sm139121185ad.30.2026.02.01.21.58.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 01 Feb 2026 21:58:32 -0800 (PST) From: Chengkaitao To: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, yangfeng@kylinos.cn, alexei.starovoitov@gmail.com Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Chengkaitao Subject: [PATCH RESEND v3 0/3] bpf/verifier: Expand the usage scenarios of bpf_kptr_xchg Date: Mon, 2 Feb 2026 13:58:15 +0800 Message-ID: <20260202055818.78231-1-pilgrimtao@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chengkaitao When using bpf_kptr_xchg, we triggered the following error: 31: (85) call bpf_kptr_xchg#194 function calls are not allowed while holding a lock bpf_kptr_xchg can now be used in lock-held contexts, so we extended its usage scope in [patch 1/2]. When writing test cases using bpf_kptr_xchg and bpf_rbtree_*, the following approach must be followed: bpf_spin_lock(&lock); rb_n = bpf_rbtree_root(&root); while (rb_n && can_loop) { rb_n = bpf_rbtree_remove(&root, rb_n); if (!rb_n) goto fail; tnode = container_of(rb_n, struct tree_node, node); node_data = bpf_kptr_xchg(&tnode->node_data, NULL); if (!node_data) goto fail; data = node_data->data; /* use data to do something */ node_data = bpf_kptr_xchg(&tnode->node_data, node_data); if (node_data) goto fail; bpf_rbtree_add(&root, rb_n, less); if (lookup_key < tnode->key) rb_n = bpf_rbtree_left(&root, rb_n); else rb_n = bpf_rbtree_right(&root, rb_n); } bpf_spin_unlock(&lock); The above illustrates a lock-remove-read-add-unlock workflow, which exhibits lower performance. To address this, we introduced support for a streamlined lock-read-unlock operation in [patch 2/2]. Changes in v3: - Fix compilation errors Changes in v2: - Allow using bpf_kptr_xchg even if the NON_OWN_REF flag is set - Add test case Link to V2: https://lore.kernel.org/all/20260201031607.32940-1-pilgrimtao@gmail.com/ Link to V1: https://lore.kernel.org/all/20260122081426.78472-1-pilgrimtao@gmail.com/ Chengkaitao (3): bpf/verifier: allow calling bpf_kptr_xchg while holding a lock bpf/verifier: allow using bpf_kptr_xchg even if the NON_OWN_REF flag is set selftests/bpf: Add supplementary tests for bpf_kptr_xchg kernel/bpf/verifier.c | 7 +- .../testing/selftests/bpf/prog_tests/rbtree.c | 6 + tools/testing/selftests/bpf/progs/bpf_misc.h | 4 + .../selftests/bpf/progs/rbtree_search_kptr.c | 164 ++++++++++++++++++ 4 files changed, 179 insertions(+), 2 deletions(-) create mode 100644 tools/testing/selftests/bpf/progs/rbtree_search_kptr.c -- 2.50.1 (Apple Git-155)