From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA99C2BF00B for ; Mon, 2 Feb 2026 11:26:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770031604; cv=none; b=TMPIsHHy2Ggjn5pxW6VFQHHuJ4OKHiozZX1g0RW94Ws2cisnY956JBFlH5kniYN2AMPDLoWsK3SLaCq9pvs4BqVFByeG0MbSKO2Pa6ji74Z82nT6rtgtic+8jo0O8rsF0Sax9Pd4D/at1qg53D7+MR1KHiKdFg513dULtOzY71M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770031604; c=relaxed/simple; bh=S/QN8g8DMBxAZXXJkR6/nu26Z91hENLpbI6EEZNmXHs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=eIkgsxIgOyIlEJTY1sPznY1xZJm29Fo6nXC2QLm9Bdqur4+x84LoEkwPFRqPc0dWGsHxqQykbAMLXNHKB+3TrK6M0vPFK/KnXxR3kz20rtqQOLLPZ0R3eQ1jR7+Wt+0Cg4995l7QU+AdlSN3jD5KmucvHL7d45LiYfatNp/spPo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Lp+Z0sXb; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IhJfwwuq; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Lp+Z0sXb"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IhJfwwuq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770031601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WFjDvdrRxVfmhlp8tolkgkwAJGMn1WaBNsOsOm3xh4U=; b=Lp+Z0sXbn6ChpHLzQyYYzOf3EssKTQVVx75Yc+SO1+8E+QWOTCZ/Nn0qvFDaILNr56mOmt 8qkxCf54gLRuig5WBYnYn2VbNdayx1zQDxCGLf19rT1ZAuPkH5sGuDqHXo7j3oSE+U86Jt HkDuezmTd6qiN1cBQKDK0rWN2XWGRXQ= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-322-ZtG66LstMjmpK6QnG9EIrg-1; Mon, 02 Feb 2026 06:26:40 -0500 X-MC-Unique: ZtG66LstMjmpK6QnG9EIrg-1 X-Mimecast-MFC-AGG-ID: ZtG66LstMjmpK6QnG9EIrg_1770031599 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-59de4460e35so2397766e87.3 for ; Mon, 02 Feb 2026 03:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770031599; x=1770636399; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WFjDvdrRxVfmhlp8tolkgkwAJGMn1WaBNsOsOm3xh4U=; b=IhJfwwuq7bBiII8pDOZisg4CCvgJ9oouFM90p3tznK/HBRCv+CFUMa8uhcJS3hdabk qRvpcKXbXfm7k8mKGfTDQ2T+C92n6bQ74IydNSYYwzUX1epv0WYynyVwG17J/rUq3mRa hgeP+IuXOydWR/PsE8danMd1x4BrJGrtM+7vZ8+lpbQxqGvXxpsAj7MgAdxhuXtv0e0w NNvIV872usR5cVTL4olQOe0/9t0Ot3qAVkhZ4oegSg+gq327sYdaxZbG/CyMNFlJE/Ys mXoq/FTdTrdS4pl1SUI3kIwYC9tXW+rxSNysj+4m/j0nhtsaa7BDumlOzESZPNmXaGJZ hNkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770031599; x=1770636399; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WFjDvdrRxVfmhlp8tolkgkwAJGMn1WaBNsOsOm3xh4U=; b=n59F3vyUUYIx8RLsqHNiSgrGj8iA1vigDzEDkO8cLFIkPPyywa5jw862OIR1fv95IY v+t6cOg4ot/iYXXqj4CscJdBLUflnJBi+MzF+VWc4uDlVM6ORYK711aWYe1Jd4QTvoNv GwH2ymZiGp/Si+ty9jefuEg0HkBXgv7odImworlsLo3FN84w2aM15ZBQBJ+GL7VMObqh eempW5pegxIPvYutYCIBQtBSX07rzq9YDZl/Z28Ed9j/bZwFxqAClGvl6m4prCcQ88q5 6Ev6d9Q46JcfSja9vlfLUnYi9JrFk/nletC8TUXgPRyfB0A/g5wrv6QUYJRuibiQt+xR Z8aQ== X-Gm-Message-State: AOJu0Yx5DhEleyvr+NNDGQ8tPDGI6FdW/uV3luFfcY0UooqULQf1if7q Hfzsc8QMeIhU/IcOM6xBHHoz8u7Vm3LAzabBpbt3HK17L8C3oo9jYLL+Kzky5ZTriRfZEWHHAIw U61SjFE8riiDPUwtUG2doLje7ZZcr32DGaQLz/T8BkMoqG4GsxqB6hDY/3klvRWrQ X-Gm-Gg: AZuq6aIoCBmbdYNTO6w5VTHoDtkDaKCcwLaA+D86lUcTEnQxBlFplyQslTQIc0zl059 FZ2P2fEWPR8EZGcuVyhfvoCNLUN6pZ3RYS9hembF9Bhv6RebngIFBsVraKlQGsa/OjjxUiol2vU VwuX+7OwrWjo0zfdrR4xNM1XfrnEdcv7O7R2z5L6SKFrrr2gUWPQ1CnE3TtWBrFJeEt20OWsPgk e8wDRXrkLqp+IU8bSa6X5FTnKrYzMN1ImSA8V5QvOk+hr3yxkyUHk2M+/jDv9Jo48k8cQwVigDk vEKPxOcwaW3czJcWlqKFhX8a/Q8yMpLZBXRv1QUpi0z8GHqDmCJHzvvKyRxVSHMsWeuS38T8od9 xM5SxQXoXz0Fwb9qpz7w03kcO X-Received: by 2002:a05:6512:3d93:b0:59b:9f92:301f with SMTP id 2adb3069b0e04-59e163ff690mr4203307e87.7.1770031598984; Mon, 02 Feb 2026 03:26:38 -0800 (PST) X-Received: by 2002:a05:6512:3d93:b0:59b:9f92:301f with SMTP id 2adb3069b0e04-59e163ff690mr4203300e87.7.1770031598523; Mon, 02 Feb 2026 03:26:38 -0800 (PST) Received: from fedora (85-23-51-1.bb.dnainternet.fi. [85.23.51.1]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e0a43e8ebsm3221336e87.55.2026.02.02.03.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 03:26:38 -0800 (PST) From: mpenttil@redhat.com To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?Mika=20Penttil=C3=A4?= Subject: [PATCH v4 0/3] Migrate on fault for device pages Date: Mon, 2 Feb 2026 13:26:19 +0200 Message-ID: <20260202112622.2104213-1-mpenttil@redhat.com> X-Mailer: git-send-email 2.50.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Mika Penttilä Currently, the way device page faulting and migration works is not optimal, if you want to do both fault handling and migration at once. Being able to migrate not present pages (or pages mapped with incorrect permissions, eg. COW) to the GPU requires doing either of the following sequences: 1. hmm_range_fault() - fault in non-present pages with correct permissions, etc. 2. migrate_vma_*() - migrate the pages Or: 1. migrate_vma_*() - migrate present pages 2. If non-present pages detected by migrate_vma_*(): a) call hmm_range_fault() to fault pages in b) call migrate_vma_*() again to migrate now present pages The problem with the first sequence is that you always have to do two page walks even when most of the time the pages are present or zero page mappings so the common case takes a performance hit. The second sequence is better for the common case, but far worse if pages aren't present because now you have to walk the page tables three times (once to find the page is not present, once so hmm_range_fault() can find a non-present page to fault in and once again to setup the migration). It is also tricky to code correctly. One page table walk could costs over 1000 cpu cycles on X86-64, which is a significant hit. We should be able to walk the page table once, faulting pages in as required and replacing them with migration entries if requested. Add a new flag to HMM APIs, HMM_PFN_REQ_MIGRATE, which tells to prepare for migration also during fault handling. Also, for the migrate_vma_setup() call paths, a flag, MIGRATE_VMA_FAULT, is added to tell to add fault handling to migrate. One extra benefit of migrating with hmm_range_fault() path is the migrate_vma.vma gets populated, so no need to retrieve that separataly. Tested in X86-64 VM with HMM test device, passing the selftests. Tested also rebased on the "Remove device private pages from physical address space" series: https://lore.kernel.org/linux-mm/20260130111050.53670-1-jniethe@nvidia.com/ plus a small patch to adjust with no problems. Changes v3-v4: - rebase on 6.19-rc8 - fixed issues found by kernel test robot with random configs - fixed typos Changes v2-v3: - rebase on 6.19-rc7 - fixed issues found by kernel test robot - fixed smatch issues reported by Dan Carpenter - fixes to lock handling (pmd/pte) on errors - added assertions for pmd/pte lock states - other issues discovered by Matthew, thanks! Changes v1-v2: - rebase on 6.19-rc6 - fixed issues found by kernel test robot - fixed locking (pmd/ptl) to cover handle_ and prepare_ regions parts if migrating - other issues discovered by Matthew, thanks! Changes RFC-v1: - rebase on 6.19-rc5 - adjust for the device THP - changes from feedback Revisions: - RFC https://lore.kernel.org/linux-mm/20250814072045.3637192-1-mpenttil@redhat.com/ - v1: https://lore.kernel.org/all/20260114091923.3950465-1-mpenttil@redhat.com/ - v2: https://lore.kernel.org/all/20260119112502.645059-1-mpenttil@redhat.com/ - v3: https://lore.kernel.org/all/20260126111939.1332983-2-mpenttil@redhat.com/ Mika Penttilä (3): mm: unified hmm fault and migrate device pagewalk paths mm: add new testcase for the migrate on fault case mm:/migrate_device.c: remove migrate_vma_collect_*() functions include/linux/hmm.h | 19 +- include/linux/migrate.h | 27 +- lib/test_hmm.c | 100 ++- lib/test_hmm_uapi.h | 19 +- mm/Kconfig | 2 + mm/hmm.c | 802 +++++++++++++++++++++++-- mm/migrate_device.c | 594 +++--------------- tools/testing/selftests/mm/hmm-tests.c | 54 ++ 8 files changed, 1034 insertions(+), 583 deletions(-) base-commit: 18f7fcd5e69a04df57b563360b88be72471d6b62 -- 2.50.0