From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3615330E0F5 for ; Mon, 2 Feb 2026 20:37:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770064676; cv=none; b=mCXsE4IoVkhf9h3bjrOig7b12NHLSRg0KY8WBAU5ECA83a7iLDHqgE8/RccgJSxPaQi/jo0TiTAhyXhSFqWJujqFNqQQvl88hVczFlYxfybk1/mgD7A7m/BUXAhloWfgCjVtOfJJccsvQyv/evHsu53kw0mD5h2NfAhF7inkwYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770064676; c=relaxed/simple; bh=M4B9HLYZdxbbPlzbT46MBLhmeAkacRlZ5SHiTjxYdO8=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=A10XuAWr5t9IM41NJIIMr0KSgV2L1s765vF4FG+Cj5Llcj2bgK++SC6b0SFfcSexxiGiv4cQ8aVEFF5FnCFiRX6ApLfWKAypO6A1JDWMzKKYQLd/EWwJc/ladJo7WCA5SFIn9MW8mEamx/o9P7zbTORCbnLCFyD3HlCM6BBnIn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=dkXj99+j; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="dkXj99+j" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98A6EC116C6; Mon, 2 Feb 2026 20:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1770064675; bh=M4B9HLYZdxbbPlzbT46MBLhmeAkacRlZ5SHiTjxYdO8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dkXj99+jwuh9C3LJ/Upnj0W/a15EdBKsjkApm0k3O9Y0rn5EB04UKXnG0uUf5CQdz N6W2rab03vRAF/6s8DVCMqIrooUwD/Aa7Dcv+0JBsJeJxszAOJkf/gxSKP4v33vlfp ZcUFD1VFMF/S7LFbdpIVCXTFekWHm+oHJk16kfy0= Date: Mon, 2 Feb 2026 12:37:54 -0800 From: Andrew Morton To: Arnd Bergmann Cc: Balbir Singh , Yang Yang , Wang Yaxin , Arnd Bergmann , xu xin , Kun Jiang , linux-kernel@vger.kernel.org Subject: Re: [PATCH] delayacct: fix uapi timespec64 definition Message-Id: <20260202123754.1bf674cd3b58ce0cb2cfa006@linux-foundation.org> In-Reply-To: <20260202095906.1344100-1-arnd@kernel.org> References: <20260202095906.1344100-1-arnd@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 2 Feb 2026 10:59:00 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > The custom definition of 'struct timespec64' is incompatible with > both the kernel's internal definition and the glibc type, at least > on big-endian targets that have the tv_nsec field in a different > place, and the definition clashes with any userspace that also > defines a timespec64 structure. > > Running the header check with -Wpadding enabled produces this output > that warns about the incorrect padding: > > usr/include/linux/taskstats.h:25:1: error: padding struct size to alignment boundary with 4 bytes [-Werror=padded] > > Remove the hack and instead use the regular __kernel_timespec > type that is meant to be used in uapi definitions. > Thanks. > @@ -251,14 +242,14 @@ struct taskstats { > __u64 irq_delay_min; > > /*v17: delay max timestamp record*/ > - struct timespec64 cpu_delay_max_ts; > - struct timespec64 blkio_delay_max_ts; > - struct timespec64 swapin_delay_max_ts; > - struct timespec64 freepages_delay_max_ts; > - struct timespec64 thrashing_delay_max_ts; > - struct timespec64 compact_delay_max_ts; > - struct timespec64 wpcopy_delay_max_ts; > - struct timespec64 irq_delay_max_ts; > + struct __kernel_timespec cpu_delay_max_ts; > + struct __kernel_timespec blkio_delay_max_ts; > + struct __kernel_timespec swapin_delay_max_ts; > + struct __kernel_timespec freepages_delay_max_ts; > + struct __kernel_timespec thrashing_delay_max_ts; > + struct __kernel_timespec compact_delay_max_ts; > + struct __kernel_timespec wpcopy_delay_max_ts; > + struct __kernel_timespec irq_delay_max_ts; > } __uapi_arch_align; There's no __uapi_arch_align here in any tree I looked at?